[obs-commits] [openSUSE/open-build-service] 30b039: [frontend] Refactor BsRequest#raisepriority
Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 30b03912fd62a7201673c1ab50da8645d7838086 https://github.com/openSUSE/open-build-service/commit/30b03912fd62a7201673c1... Author: Björn Geuken <bgeuken@suse.de> Date: 2017-10-12 (Thu, 12 Oct 2017) Changed paths: M src/api/app/models/bs_request.rb Log Message: ----------- [frontend] Refactor BsRequest#raisepriority This move the code that checks if we can raise the priority into a separate method. This allows us to shorten the raisepriority method quite some code duplication. Both methods are now private. Commit: 6d9c68484b911826a9f965fb1aecd627eb16ef84 https://github.com/openSUSE/open-build-service/commit/6d9c68484b911826a9f965... Author: Björn Geuken <bgeuken@suse.de> Date: 2017-10-12 (Thu, 12 Oct 2017) Changed paths: M src/api/app/models/bs_request.rb M src/api/spec/models/bs_request_spec.rb Log Message: ----------- [frontend] Create history element on priority raise Part of the bs request validation is to check, if the priority of a associated bs_request_action is higher than the priority of the bs_request. If that's the case, the priority of the bs_request get's raised. This wasn't logged via the history elements and might be one of the culprits of Issue#3897 – history elements were missing. Commit: 5f380bf32cec720010e88d28edaef73201a0d829 https://github.com/openSUSE/open-build-service/commit/5f380bf32cec720010e88d... Author: Björn Geuken <bgeuken@suse.de> Date: 2017-10-13 (Fri, 13 Oct 2017) Changed paths: M src/api/app/models/bs_request.rb M src/api/spec/models/bs_request_spec.rb Log Message: ----------- Merge pull request #3994 from bgeuken/refactor_raisepriority Refactor raisepriority and track automatic prio bumps via history element Compare: https://github.com/openSUSE/open-build-service/compare/23df98168ddf...5f380b...
participants (1)
-
Björn Geuken