Branch: refs/heads/master
Home: https://github.com/openSUSE/open-build-service
Commit: 5fc17b69b1d9ea129ce6780294560ae1aadc80ce
https://github.com/openSUSE/open-build-service/commit/5fc17b69b1d9ea129ce678...
Author: Björn Geuken
Date: 2018-02-28 (Wed, 28 Feb 2018)
Changed paths:
M src/api/.jshintrc
M src/api/app/assets/javascripts/webui/application/kiwi_editor.js
M src/api/app/assets/javascripts/webui/application/package.js
Log Message:
-----------
[ci] Add jshint rule: undef
This rule complains about any undefined js varaible. This helps to
prevent having global variables (leaks).
Commit: c5e45f9d0ae6ff3841cb35796412d27c1a598cb5
https://github.com/openSUSE/open-build-service/commit/c5e45f9d0ae6ff3841cb35...
Author: Björn Geuken
Date: 2018-02-28 (Wed, 28 Feb 2018)
Changed paths:
M src/api/.jshintrc
M src/api/app/assets/javascripts/webui/application/kiwi_editor.js
M src/api/app/assets/javascripts/webui/application/package.js
M src/api/app/assets/javascripts/webui/application/project.js
M src/api/app/assets/javascripts/webui/application/request.js
M src/api/app/controllers/webui/kiwi/images_controller.rb
M src/api/app/views/webui/kiwi/images/edit.html.haml
M src/api/app/views/webui/project/list.html.erb
M src/api/app/views/webui/project/subprojects.html.haml
M src/api/app/views/webui/user/show.html.haml
Log Message:
-----------
[frontend] Enable jshint rule: camelcase
For javascript camelcase is de facto the standard for variable and
function names. Let's align our code to it.
Commit: 5ec426ba46dfd76f342078c23c6f96fcaa8b5f66
https://github.com/openSUSE/open-build-service/commit/5ec426ba46dfd76f342078...
Author: Björn Geuken
Date: 2018-02-28 (Wed, 28 Feb 2018)
Changed paths:
M src/api/spec/models/branch_package_spec.rb
Log Message:
-----------
[frontend] Fix flickering test
We don't care about the identy of the *.attribs.length but it's actual
length.
====
1) BranchPackage#branch project without ImageTemplates attribute auto cleanup attribute is not set
Failure/Error: expect(project.attribs.length).to be(0)
expected #Integer:1 => 0
got #Integer:3 => 1
Compared using equal?, which compares object identity,
but expected and actual are not the same object. Use
`expect(actual).to eq(expected)` if you don't care about
object identity in this example.
# ./spec/models/branch_package_spec.rb:72:in `block (5 levels) in '
# ./spec/support/logging.rb:4:in `block (2 levels) in '
Commit: 99a70354169149be3073cf741466a7f1bc16b13f
https://github.com/openSUSE/open-build-service/commit/99a70354169149be3073cf...
Author: Ana María Martínez Gómez
Date: 2018-03-02 (Fri, 02 Mar 2018)
Changed paths:
M src/api/.jshintrc
M src/api/app/assets/javascripts/webui/application/kiwi_editor.js
M src/api/app/assets/javascripts/webui/application/package.js
M src/api/app/assets/javascripts/webui/application/project.js
M src/api/app/assets/javascripts/webui/application/request.js
M src/api/app/controllers/webui/kiwi/images_controller.rb
M src/api/app/views/webui/kiwi/images/edit.html.haml
M src/api/app/views/webui/project/list.html.erb
M src/api/app/views/webui/project/subprojects.html.haml
M src/api/app/views/webui/user/show.html.haml
M src/api/spec/models/branch_package_spec.rb
Log Message:
-----------
Merge pull request #4586 from bgeuken/add_jshint_rules
[ci] Add jshint rule: undef & camelcase
Compare: https://github.com/openSUSE/open-build-service/compare/5772b0253fd0...99a703...
Ana María Martínez Gómez