Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 245826688de66c180fce8cc293a3d8843bbeab38 https://github.com/openSUSE/open-build-service/commit/245826688de66c180fce8c... Author: Eduardo Navarro Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: M src/api/app/models/configuration.rb M src/api/spec/models/configuration_spec.rb Log Message: ----------- Move remaining configuration methods to class methods We don't need to retrieve the values stored in the singleton record of the table `configurations` in the database for none of the `accounts_editable?` and also `passwords_changable?` methods. Moving each method to the class methods section prevents from performing unneeded database queries. Commit: 39305ba2c172c2e5c466a036688cd622afb964a6 https://github.com/openSUSE/open-build-service/commit/39305ba2c172c2e5c466a0... Author: Eduardo Navarro Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: M src/api/app/controllers/webui/users_controller.rb M src/api/app/views/webui/user/_basic_info.html.haml M src/api/app/views/webui/user/_index_actions.html.haml M src/api/app/views/webui/user/_info.html.haml M src/api/app/views/webui/users/show.html.haml Log Message: ----------- Rewrite calls to Configuration class methods Before, some methods were defined in the Configuration ActiveRecord instance section. Later, those methods were moved to the class section. Adapt the calls to those moved methods. Commit: 264d47ecfd38315a8a1b16fc410c8f1138e0d868 https://github.com/openSUSE/open-build-service/commit/264d47ecfd38315a8a1b16... Author: Eduardo J Date: 2024-05-24 (Fri, 24 May 2024) Changed paths: M src/api/app/controllers/webui/users_controller.rb M src/api/app/models/configuration.rb M src/api/app/views/webui/user/_basic_info.html.haml M src/api/app/views/webui/user/_index_actions.html.haml M src/api/app/views/webui/user/_info.html.haml M src/api/app/views/webui/users/show.html.haml M src/api/spec/models/configuration_spec.rb Log Message: ----------- Merge pull request #16174 from eduardoj/refactoring/configuration_class_methods_ii Move configuration methods to class methods (II) Compare: https://github.com/openSUSE/open-build-service/compare/54e0bb1c1ba1...264d47... To unsubscribe from these emails, change your notification settings at https://github.com/openSUSE/open-build-service/settings/notifications