[obs-commits] [openSUSE/open-build-service] 084c32: [api] Hide sourcediffs in event mails in case of r...
Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 084c326fd77a277446b1e116878bbc0cea325a03 https://github.com/openSUSE/open-build-service/commit/084c326fd77a277446b1e1... Author: Björn Geuken <bgeuken@suse.de> Date: 2017-08-29 (Tue, 29 Aug 2017) Changed paths: M src/api/app/models/event/request.rb Log Message: ----------- [api] Hide sourcediffs in event mails in case of remote projects Fixes #3587 When generating a sourcediff OBS checks the source access. In case of remote projects this access check includes checking the write access of the logged in user. Since event mails are sent by delayed jobs, there is no user available to run the source access check against, which causes the delayed job to crash. A proper would require a bigger refactoring of the code that is involved here. For the time being we work around the issue by skipping the source diff generation for event emails that involve remote projects. Commit: 733d70dfa9d9dae0101cad311054de5a2eed262e https://github.com/openSUSE/open-build-service/commit/733d70dfa9d9dae0101cad... Author: Henne Vogelsang <hvogel@opensuse.org> Date: 2017-08-31 (Thu, 31 Aug 2017) Changed paths: M src/api/app/models/event/request.rb Log Message: ----------- Merge pull request #3697 from bgeuken/fix_issue_3587 [api] Hide sourcediffs in event mails in case of remote projects Compare: https://github.com/openSUSE/open-build-service/compare/0dc6173ba017...733d70...
participants (1)
-
Henne Vogelsang