[obs-commits] [openSUSE/open-build-service] 981297: [frontend] DRY code in BsRequest model
Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 98129723c49ae28bae20b6a47db1551d40e16c70 https://github.com/openSUSE/open-build-service/commit/98129723c49ae28bae20b6... Author: Björn Geuken <bgeuken@suse.de> Date: 2017-10-10 (Tue, 10 Oct 2017) Changed paths: M src/api/app/models/bs_request.rb Log Message: ----------- [frontend] DRY code in BsRequest model Move duplicated code for checking associated bs_request_actions into private method. Commit: ae97338d47a968d91521b98fd4b0ca77e21c94c5 https://github.com/openSUSE/open-build-service/commit/ae97338d47a968d91521b9... Author: Björn Geuken <bgeuken@suse.de> Date: 2017-10-11 (Wed, 11 Oct 2017) Changed paths: M src/api/app/models/bs_request.rb Log Message: ----------- [frontend] Move existing private methods together We already had some private methods that were marked as private individually. This will group them together to have a better overview of them. Commit: 15878f7e5ea828a40ff84e9bc2c600f9f912bbaf https://github.com/openSUSE/open-build-service/commit/15878f7e5ea828a40ff84e... Author: Björn Geuken <bgeuken@suse.de> Date: 2017-10-11 (Wed, 11 Oct 2017) Changed paths: M src/api/app/models/bs_request.rb Log Message: ----------- [frontend] Group class and instance methods together Commit: 050a39222ba095c7d462f263882c3727735759d9 https://github.com/openSUSE/open-build-service/commit/050a39222ba095c7d462f2... Author: Björn Geuken <bgeuken@suse.de> Date: 2017-10-11 (Wed, 11 Oct 2017) Changed paths: M src/api/app/models/bs_request.rb Log Message: ----------- [frontend] Cleanup usage of constants * Make IntermediateStates a local variable, since it was only used in one method. * Fix naming of ActionNotifyLimit constant and move it up to the other constants. Constants should be written in CAMEL_CASE;-) Commit: ec6d32762f20eaca3c87fef26645f2710b51774b https://github.com/openSUSE/open-build-service/commit/ec6d32762f20eaca3c87fe... Author: Björn Geuken <bgeuken@suse.de> Date: 2017-10-11 (Wed, 11 Oct 2017) Changed paths: M src/api/app/models/bs_request.rb Log Message: ----------- Merge pull request #3980 from bgeuken/refactor_bs_request_model Refactor bs request model Compare: https://github.com/openSUSE/open-build-service/compare/0ab7f3c74218...ec6d32...
participants (1)
-
Björn Geuken