Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 8b4d426e63a02440ca76359f6a163ae17cdd6ca3 https://github.com/openSUSE/open-build-service/commit/8b4d426e63a02440ca7635... Author: Henne Vogelsang Date: 2015-09-02 (Wed, 02 Sep 2015) Changed paths: M src/api/.rubocop.yml M src/api/app/controllers/source_controller.rb M src/api/app/controllers/webui/package_controller.rb M src/api/app/controllers/webui/project_controller.rb M src/api/app/controllers/webui/webui_controller.rb M src/api/app/helpers/webui/webui_helper.rb M src/api/app/models/architecture.rb M src/api/app/models/history_element.rb R src/api/app/models/history_element/all.rb R src/api/app/models/history_element/base.rb R src/api/app/models/history_element/request.rb R src/api/app/models/history_element/review.rb M src/api/app/models/project.rb M src/api/app/models/repository.rb M src/api/app/policies/project_policy.rb M src/api/app/views/shared/_involved_users.html.erb M src/api/app/views/shared/_repositories_flag_table.html.erb M src/api/app/views/webui/project/_add_maintained_project_dialog.html.erb M src/api/app/views/webui/project/_buildstatus.html.erb M src/api/app/views/webui/project/_delete_dialog.html.erb M src/api/app/views/webui/project/_edit_comment_form.html.erb M src/api/app/views/webui/project/_edit_repository.html.erb M src/api/app/views/webui/project/_form.html.erb M src/api/app/views/webui/project/_packages_table.html.erb M src/api/app/views/webui/project/_release_request_dialog.html.erb M src/api/app/views/webui/project/_remove_target_request_dialog.html.erb M src/api/app/views/webui/project/_tabs.html.erb M src/api/app/views/webui/project/add_repository.html.erb M src/api/app/views/webui/project/add_repository_from_default_list.html.erb M src/api/app/views/webui/project/edit.html.erb M src/api/app/views/webui/project/edit_comment_form.js.erb M src/api/app/views/webui/project/maintained_projects.html.erb M src/api/app/views/webui/project/meta.html.erb M src/api/app/views/webui/project/monitor.html.erb M src/api/app/views/webui/project/package_buildresult.html.erb M src/api/app/views/webui/project/prjconf.html.erb M src/api/app/views/webui/project/repositories.html.erb M src/api/app/views/webui/project/requests.html.erb M src/api/app/views/webui/project/show.html.erb M src/api/app/views/webui/project/status.html.erb M src/api/app/views/webui/project/subprojects.html.haml M src/api/config/routes.rb M src/api/test/fixtures/history_elements.yml M src/api/test/functional/request_controller_test.rb M src/api/test/functional/webui/add_repo_test.rb M src/api/test/functional/webui/project_controller_test.rb M src/api/test/functional/webui/project_edit_test.rb M src/api/test/unit/code_quality_test.rb Log Message: ----------- [webui][api] Get rid of WebuiProject in webui/project_controller.rb * Make some of the rubocop metric rules not fail * revoke requests when projects get deleted * Introduce set_project before_filter and use it * Limit :require_project before filter (and hence WebuiProject) to move_path_* The path_elements list of repositories needs a little more thought. acts_as_list would be an option but that means removing the uniqe key in the db for partent_id and position * Move all the support methods down in the file * Move some of the methods into the project model * authorize all calls that change the project * Rename CRUD the methods * Use strong parameters * Concat all the stupid history_element files into one for lazy loading * Also fix the history_elements fixtures, rake db:fixtures:load works again now... Commit: 0af6b5fe72eac0782bf6b84dacea0d04d4f1c2ec https://github.com/openSUSE/open-build-service/commit/0af6b5fe72eac0782bf6b8... Author: Henne Vogelsang Date: 2015-09-03 (Thu, 03 Sep 2015) Changed paths: M src/api/.rubocop.yml M src/api/app/controllers/source_controller.rb M src/api/app/controllers/webui/package_controller.rb M src/api/app/controllers/webui/project_controller.rb M src/api/app/controllers/webui/webui_controller.rb M src/api/app/helpers/webui/webui_helper.rb M src/api/app/models/architecture.rb M src/api/app/models/history_element.rb R src/api/app/models/history_element/all.rb R src/api/app/models/history_element/base.rb R src/api/app/models/history_element/request.rb R src/api/app/models/history_element/review.rb M src/api/app/models/project.rb M src/api/app/models/repository.rb M src/api/app/policies/project_policy.rb M src/api/app/views/shared/_involved_users.html.erb M src/api/app/views/shared/_repositories_flag_table.html.erb M src/api/app/views/webui/project/_add_maintained_project_dialog.html.erb M src/api/app/views/webui/project/_buildstatus.html.erb M src/api/app/views/webui/project/_delete_dialog.html.erb M src/api/app/views/webui/project/_edit_comment_form.html.erb M src/api/app/views/webui/project/_edit_repository.html.erb M src/api/app/views/webui/project/_form.html.erb M src/api/app/views/webui/project/_packages_table.html.erb M src/api/app/views/webui/project/_release_request_dialog.html.erb M src/api/app/views/webui/project/_remove_target_request_dialog.html.erb M src/api/app/views/webui/project/_tabs.html.erb M src/api/app/views/webui/project/add_repository.html.erb M src/api/app/views/webui/project/add_repository_from_default_list.html.erb M src/api/app/views/webui/project/edit.html.erb M src/api/app/views/webui/project/edit_comment_form.js.erb M src/api/app/views/webui/project/maintained_projects.html.erb M src/api/app/views/webui/project/meta.html.erb M src/api/app/views/webui/project/monitor.html.erb M src/api/app/views/webui/project/package_buildresult.html.erb M src/api/app/views/webui/project/prjconf.html.erb M src/api/app/views/webui/project/repositories.html.erb M src/api/app/views/webui/project/requests.html.erb M src/api/app/views/webui/project/show.html.erb M src/api/app/views/webui/project/status.html.erb M src/api/app/views/webui/project/subprojects.html.haml M src/api/config/routes.rb M src/api/test/fixtures/history_elements.yml M src/api/test/functional/request_controller_test.rb M src/api/test/functional/webui/add_repo_test.rb M src/api/test/functional/webui/project_controller_test.rb M src/api/test/functional/webui/project_edit_test.rb M src/api/test/unit/code_quality_test.rb Log Message: ----------- Merge pull request #1085 from hennevogel/refactoring_project_controller [webui][api] Get rid of WebuiProject in webui/project_controller.rb Compare: https://github.com/openSUSE/open-build-service/compare/855d64807dc3...0af6b5...