[openSUSE/open-build-service] ead574: Move the count of unread notifications to the cont...
Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: ead574c41b6f9f5bf721a70beb421eb54d68067f https://github.com/openSUSE/open-build-service/commit/ead574c41b6f9f5bf721a7... Author: Eduardo Navarro <enavarro@suse.com> Date: 2024-06-05 (Wed, 05 Jun 2024) Changed paths: M src/api/app/controllers/webui/users/notifications_controller.rb M src/api/app/controllers/webui/webui_controller.rb M src/api/app/views/layouts/webui/_bottom_navigation.html.haml M src/api/app/views/layouts/webui/_top_navigation.html.haml M src/api/app/views/layouts/webui/_unread_notifications_counter.html.haml M src/api/app/views/layouts/webui/webui.html.haml M src/api/app/views/webui/users/notifications/_update.js.erb Log Message: ----------- Move the count of unread notifications to the controller Prevent from performing an SQL query every time the partial is rendered. Instead, run the SQL query once in the controller and pass the result to the partial as a local variable. Commit: d095a810d0b3b2f6309fefe329ecbe7985e495bb https://github.com/openSUSE/open-build-service/commit/d095a810d0b3b2f6309fef... Author: Eduardo J <enavarro@suse.com> Date: 2024-06-05 (Wed, 05 Jun 2024) Changed paths: M src/api/app/controllers/webui/users/notifications_controller.rb M src/api/app/controllers/webui/webui_controller.rb M src/api/app/views/layouts/webui/_bottom_navigation.html.haml M src/api/app/views/layouts/webui/_top_navigation.html.haml M src/api/app/views/layouts/webui/_unread_notifications_counter.html.haml M src/api/app/views/layouts/webui/webui.html.haml M src/api/app/views/webui/users/notifications/_update.js.erb Log Message: ----------- Merge pull request #16258 from eduardoj/refactoring/unread_notifications Move the count of unread notifications to the controller Compare: https://github.com/openSUSE/open-build-service/compare/0dbad2871784...d095a8... To unsubscribe from these emails, change your notification settings at https://github.com/openSUSE/open-build-service/settings/notifications
participants (1)
-
Eduardo J.