[obs-commits] [openSUSE/open-build-service] 1ce746: First step on reducing webui_info in webui2
Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 1ce746ed40235215d52935147cfd2c5595cef40d https://github.com/openSUSE/open-build-service/commit/1ce746ed40235215d52935... Author: Stephan Kulow <coolo@suse.de> Date: 2019-05-14 (Tue, 14 May 2019) Changed paths: M src/api/app/controllers/webui/request_controller.rb M src/api/app/models/bs_request.rb M src/api/spec/models/bs_request_spec.rb M src/api/test/unit/bs_request_test.rb Log Message: ----------- First step on reducing webui_info in webui2 Move the important parts of webui_info into the controller, most work is still in webui_actions for now though Commit: 9ac681c93cd9d7ceab7be51c7841f9e008f56a99 https://github.com/openSUSE/open-build-service/commit/9ac681c93cd9d7ceab7be5... Author: Stephan Kulow <coolo@suse.de> Date: 2019-05-14 (Tue, 14 May 2019) Changed paths: M src/api/app/controllers/webui/request_controller.rb M src/api/app/views/webui2/webui/request/_review_tab.html.haml M src/api/app/views/webui2/webui/request/_show_side_links.html.haml M src/api/app/views/webui2/webui/request/show.html.haml Log Message: ----------- No longer need Review.webui_info Rely on the id of the Review record to be passed around instead of all the by_* attributes Commit: 6bbeeded1585383469feee10b17415ddb2c5a7ec https://github.com/openSUSE/open-build-service/commit/6bbeeded1585383469feee... Author: Stephan Kulow <coolo@suse.de> Date: 2019-05-14 (Tue, 14 May 2019) Changed paths: M src/api/app/controllers/webui/request_controller.rb M src/api/app/views/webui/request/show.html.erb M src/api/test/functional/request_controller_test.rb M src/api/test/unit/bs_request_test.rb Log Message: ----------- Merge BsRequest.webui_infos into controller It's just 2 methods Commit: 9616040fc5f6f3c9811a9755fede5556263bba44 https://github.com/openSUSE/open-build-service/commit/9616040fc5f6f3c9811a97... Author: Stephan Kulow <coolo@suse.de> Date: 2019-05-14 (Tue, 14 May 2019) Changed paths: M src/api/app/controllers/webui/request_controller.rb M src/api/app/models/bs_request.rb M src/api/app/views/webui/request/show.html.erb Log Message: ----------- Remove reviews_for_user_and_others We display all reviews anyway, so no need to split it Commit: 64bd704790bbcd5ede9add65d2b6970cbd1a75f1 https://github.com/openSUSE/open-build-service/commit/64bd704790bbcd5ede9add... Author: Henne Vogelsang <hvogel@opensuse.org> Date: 2019-05-15 (Wed, 15 May 2019) Changed paths: M src/api/app/controllers/webui/request_controller.rb M src/api/app/models/bs_request.rb M src/api/app/views/webui/request/show.html.erb M src/api/app/views/webui2/webui/request/_review_tab.html.haml M src/api/app/views/webui2/webui/request/_show_side_links.html.haml M src/api/app/views/webui2/webui/request/show.html.haml M src/api/spec/models/bs_request_spec.rb M src/api/test/functional/request_controller_test.rb M src/api/test/unit/bs_request_test.rb Log Message: ----------- Merge pull request #7486 from coolo/request_show Reduce webui_infos usage in request controller Compare: https://github.com/openSUSE/open-build-service/compare/d562d3a5e3d5...64bd70...
participants (1)
-
Henne Vogelsang