Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: a338ae9c800d4f07e0863a071da75cccb845f709 https://github.com/openSUSE/open-build-service/commit/a338ae9c800d4f07e0863a... Author: Steven R. Baker Date: 2024-06-17 (Mon, 17 Jun 2024) Changed paths: M src/api/app/models/event/base.rb Log Message: ----------- Prefer using constants directly, instead of converting the strings. This makes navigation and refactoring easier, and will also catch typos and other simple errors. We're calling `#constantize` on the strings anyhow, so this change is effectively identical in actual usage. Commit: 000e8c0ed9174570ba0ef33404752e9d58c6c26c https://github.com/openSUSE/open-build-service/commit/000e8c0ed9174570ba0ef3... Author: Steven R. Baker Date: 2024-06-17 (Mon, 17 Jun 2024) Changed paths: M src/api/app/models/event/added_user_to_group.rb M src/api/app/models/event/appeal_created.rb M src/api/app/models/event/base.rb M src/api/app/models/event/build_fail.rb M src/api/app/models/event/cleared_decision.rb M src/api/app/models/event/comment_for_package.rb M src/api/app/models/event/comment_for_project.rb M src/api/app/models/event/comment_for_request.rb M src/api/app/models/event/favored_decision.rb M src/api/app/models/event/relationship_create.rb M src/api/app/models/event/relationship_delete.rb M src/api/app/models/event/removed_user_from_group.rb M src/api/app/models/event/report_for_comment.rb M src/api/app/models/event/report_for_package.rb M src/api/app/models/event/report_for_project.rb M src/api/app/models/event/report_for_request.rb M src/api/app/models/event/report_for_user.rb M src/api/app/models/event/request_create.rb M src/api/app/models/event/request_statechange.rb M src/api/app/models/event/review_wanted.rb M src/api/app/models/event/service_fail.rb M src/api/app/models/event/workflow_run_fail.rb M src/api/app/views/webui/subscriptions/_subscriptions_form.html.haml Log Message: ----------- Move the notification explanation into the class itself. This is slightly cleanear design, and wound up being the only nice way to get rid of the magic strings. Commit: cd3d4eaa20d2043efe9d371c7689134bdd6aa5ad https://github.com/openSUSE/open-build-service/commit/cd3d4eaa20d2043efe9d37... Author: Steven R. Baker Date: 2024-06-17 (Mon, 17 Jun 2024) Changed paths: M src/api/app/models/event/added_user_to_group.rb M src/api/app/models/event/appeal_created.rb M src/api/app/models/event/base.rb M src/api/app/models/event/build_fail.rb M src/api/app/models/event/cleared_decision.rb M src/api/app/models/event/comment_for_package.rb M src/api/app/models/event/comment_for_project.rb M src/api/app/models/event/comment_for_request.rb M src/api/app/models/event/favored_decision.rb M src/api/app/models/event/relationship_create.rb M src/api/app/models/event/relationship_delete.rb M src/api/app/models/event/removed_user_from_group.rb M src/api/app/models/event/report_for_comment.rb M src/api/app/models/event/report_for_package.rb M src/api/app/models/event/report_for_project.rb M src/api/app/models/event/report_for_request.rb M src/api/app/models/event/report_for_user.rb M src/api/app/models/event/request_create.rb M src/api/app/models/event/request_statechange.rb M src/api/app/models/event/review_wanted.rb M src/api/app/models/event/service_fail.rb M src/api/app/models/event/workflow_run_fail.rb M src/api/app/views/webui/subscriptions/_subscriptions_form.html.haml Log Message: ----------- Merge pull request #16356 from srbaker/prefer-constants-for-referencing-classes Prefer constants for referencing classes. Compare: https://github.com/openSUSE/open-build-service/compare/14657597c8e0...cd3d4e... To unsubscribe from these emails, change your notification settings at https://github.com/openSUSE/open-build-service/settings/notifications