[openSUSE/open-build-service] c305be: Take out database queries from chart component...
Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: c305be39633086fa068ca59261adde88d4998ae3 https://github.com/openSUSE/open-build-service/commit/c305be39633086fa068ca5... Author: Eduardo Navarro <enavarro@suse.com> Date: 2023-11-23 (Thu, 23 Nov 2023) Changed paths: M src/api/app/components/chart_component.html.haml M src/api/app/components/chart_component.rb M src/api/app/controllers/webui/request_controller.rb A src/api/app/services/action_build_results_service/chart_data_extractor.rb M src/api/app/views/webui/request/beta_show.html.haml M src/api/spec/components/chart_component_spec.rb M src/api/spec/components/previews/chart_component_preview.rb A src/api/spec/services/action_build_results_service/chart_data_extractor_spec.rb Log Message: ----------- Take out database queries from chart component... ... into a service Reduce cognitive complexity of methods used by the component. Commit: 530a7d80c89aa9ee130e64c8fbb20331ce6ae79b https://github.com/openSUSE/open-build-service/commit/530a7d80c89aa9ee130e64... Author: ncounter <dleidi@suse.com> Date: 2023-11-23 (Thu, 23 Nov 2023) Changed paths: M src/api/app/services/action_build_results_service/chart_data_extractor.rb Log Message: ----------- Refactoring to simplify conditions logic Commit: 4d2b74b7c6c64395e6631b9af619401d1e4c1405 https://github.com/openSUSE/open-build-service/commit/4d2b74b7c6c64395e6631b... Author: ncounter <dleidi@suse.com> Date: 2023-11-23 (Thu, 23 Nov 2023) Changed paths: M src/api/app/services/action_build_results_service/chart_data_extractor.rb Log Message: ----------- Filtering and mapping before the loop Commit: e2de2f2b2cb4cac29efc170c5c081dab9f08f5f9 https://github.com/openSUSE/open-build-service/commit/e2de2f2b2cb4cac29efc17... Author: ncounter <dleidi@suse.com> Date: 2023-11-23 (Thu, 23 Nov 2023) Changed paths: M src/api/spec/services/action_build_results_service/chart_data_extractor_spec.rb Log Message: ----------- Add specs for empty build results case Commit: a41fb882ebbb6debf7a00c058cc5a57abb1331ad https://github.com/openSUSE/open-build-service/commit/a41fb882ebbb6debf7a00c... Author: ncounter <dleidi@suse.com> Date: 2023-11-23 (Thu, 23 Nov 2023) Changed paths: M src/api/app/controllers/webui/request_controller.rb M src/api/app/views/webui/request/beta_show.html.haml Log Message: ----------- Abstract naming Commit: e386506ca8feb419f7a0b669eaaeff1720f92b5c https://github.com/openSUSE/open-build-service/commit/e386506ca8feb419f7a0b6... Author: ncounter <dleidi@suse.com> Date: 2023-11-23 (Thu, 23 Nov 2023) Changed paths: M src/api/app/services/action_build_results_service/chart_data_extractor.rb Log Message: ----------- Do not use shared variable, return values instead Commit: 7599b52235d92525a998fd300891270afc8466d8 https://github.com/openSUSE/open-build-service/commit/7599b52235d92525a998fd... Author: Dario Leidi <dleidi@suse.com> Date: 2023-11-24 (Fri, 24 Nov 2023) Changed paths: M src/api/app/components/chart_component.html.haml M src/api/app/components/chart_component.rb M src/api/app/controllers/webui/request_controller.rb A src/api/app/services/action_build_results_service/chart_data_extractor.rb M src/api/app/views/webui/request/beta_show.html.haml M src/api/spec/components/chart_component_spec.rb M src/api/spec/components/previews/chart_component_preview.rb A src/api/spec/services/action_build_results_service/chart_data_extractor_spec.rb Log Message: ----------- Merge pull request #15221 from eduardoj/refactoring/chart_component_ii Reduce cognitive complexity of Chart component Compare: https://github.com/openSUSE/open-build-service/compare/afb4dd4588a4...7599b5...
participants (1)
-
Dario Leidi