[openSUSE/open-build-service] 40ee80: Gain space in the flash by reducing right padding
Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 40ee80a0b0dc46081f5750e89c4fd327cca3dae4 https://github.com/openSUSE/open-build-service/commit/40ee80a0b0dc46081f5750... Author: Saray Cabrera Padrón <scabrerapadron@suse.de> Date: 2021-10-21 (Thu, 21 Oct 2021) Changed paths: M src/api/app/assets/stylesheets/webui/flash.scss Log Message: ----------- Gain space in the flash by reducing right padding Commit: b6ab79a22001c19bba0d0e4fc52ea80a556821e3 https://github.com/openSUSE/open-build-service/commit/b6ab79a22001c19bba0d0e... Author: Saray Cabrera Padrón <scabrerapadron@suse.de> Date: 2021-10-25 (Mon, 25 Oct 2021) Changed paths: A src/api/app/helpers/webui/elisions_helper.rb M src/api/app/helpers/webui/webui_helper.rb Log Message: ----------- Move elide related methods to its own helper This way the elide methods can be used from different places like view or controllers by including this helper on them. Refactor the code a bit to avoid high CyclomaticComplexity. Commit: 8027f087d49cf7c33a475b5ec0c2c7959087d4ce https://github.com/openSUSE/open-build-service/commit/8027f087d49cf7c33a475b... Author: Saray Cabrera Padrón <scabrerapadron@suse.de> Date: 2021-10-25 (Mon, 25 Oct 2021) Changed paths: M src/api/app/controllers/webui/webui_controller.rb Log Message: ----------- Include ElisionsHelper in WebuiController So we can call elide methods in flash messages set in different controllers. Commit: 2e138de44885de651201075f6977580ac08409ed https://github.com/openSUSE/open-build-service/commit/2e138de44885de65120107... Author: Saray Cabrera Padrón <scabrerapadron@suse.de> Date: 2021-10-25 (Mon, 25 Oct 2021) Changed paths: M src/api/app/controllers/webui/attribute_controller.rb M src/api/app/controllers/webui/cloud/upload_jobs_controller.rb M src/api/app/controllers/webui/package_controller.rb M src/api/app/controllers/webui/patchinfo_controller.rb M src/api/app/controllers/webui/project_controller.rb M src/api/app/controllers/webui/projects/maintenance_incidents_controller.rb M src/api/app/controllers/webui/projects/public_key_controller.rb M src/api/app/controllers/webui/projects/ssl_certificate_controller.rb M src/api/app/controllers/webui/request_controller.rb M src/api/app/controllers/webui/requests/devel_project_changes_controller.rb M src/api/app/controllers/webui/staging/projects_controller.rb M src/api/app/controllers/webui/staging/workflows_controller.rb M src/api/app/controllers/webui/users/tokens_controller.rb M src/api/app/controllers/webui/webui_controller.rb Log Message: ----------- Elide project/package names set in flash messages The name of the project or package is usually on the page or was previously added by the user into a form. So the user doesn't need to rely on the flash message to know which project/package the application is talking about. So with elisions, we shorten the flash messages, which is especially useful in small screens. Commit: 31f26c34a311eac9eb06e549f00888932276194c https://github.com/openSUSE/open-build-service/commit/31f26c34a311eac9eb06e5... Author: Saray Cabrera Padrón <scabrerapadron@suse.de> Date: 2021-10-25 (Mon, 25 Oct 2021) Changed paths: M src/api/spec/controllers/webui/package_controller_spec.rb M src/api/spec/controllers/webui/projects/maintenance_incidents_controller_spec.rb M src/api/spec/features/webui/projects_spec.rb Log Message: ----------- Adapt specs to expect elisions Commit: 782e813dc616fb405c108f2d6a5076952a23a2d4 https://github.com/openSUSE/open-build-service/commit/782e813dc616fb405c108f... Author: Dani Donisa <daniel.donisa@suse.com> Date: 2021-10-26 (Tue, 26 Oct 2021) Changed paths: M src/api/app/assets/stylesheets/webui/flash.scss M src/api/app/controllers/webui/attribute_controller.rb M src/api/app/controllers/webui/cloud/upload_jobs_controller.rb M src/api/app/controllers/webui/package_controller.rb M src/api/app/controllers/webui/patchinfo_controller.rb M src/api/app/controllers/webui/project_controller.rb M src/api/app/controllers/webui/projects/maintenance_incidents_controller.rb M src/api/app/controllers/webui/projects/public_key_controller.rb M src/api/app/controllers/webui/projects/ssl_certificate_controller.rb M src/api/app/controllers/webui/request_controller.rb M src/api/app/controllers/webui/requests/devel_project_changes_controller.rb M src/api/app/controllers/webui/staging/projects_controller.rb M src/api/app/controllers/webui/staging/workflows_controller.rb M src/api/app/controllers/webui/users/tokens_controller.rb M src/api/app/controllers/webui/webui_controller.rb A src/api/app/helpers/webui/elisions_helper.rb M src/api/app/helpers/webui/webui_helper.rb M src/api/spec/controllers/webui/package_controller_spec.rb M src/api/spec/controllers/webui/projects/maintenance_incidents_controller_spec.rb M src/api/spec/features/webui/projects_spec.rb Log Message: ----------- Merge pull request #11765 from saraycp/elide_flash Elide project/package names in flash messages Compare: https://github.com/openSUSE/open-build-service/compare/8a566510ea5a...782e81...
participants (1)
-
Dani Donisa