[obs-commits] [openSUSE/open-build-service] 9438e0: Replace inproper usage of text-primary
Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 9438e0b7afae5c5d5ce90ef639db13087442610b https://github.com/openSUSE/open-build-service/commit/9438e0b7afae5c5d5ce90e... Author: Björn Geuken <bgeuken@suse.de> Date: 2018-11-02 (Fri, 02 Nov 2018) Changed paths: M src/api/app/helpers/webui/packages/job_history_helper.rb M src/api/app/views/webui2/shared/_flag_popover.html.haml M src/api/app/views/webui2/shared/_repositories_flag_table_column.html.haml M src/api/app/views/webui2/status_messages/_item.html.haml Log Message: ----------- Replace inproper usage of text-primary As @hellcp pointed out the actual primary color might change over time. Thus we drop the usage of text-primary where we want greeb colooring. Since we decided that we don't want to define additional color variables we use the text-success when we want green coloring, eg. succeeded build states or enabled flags. Part of #6091 Commit: d76874cb68fce1a32acac80256300ac59611b655 https://github.com/openSUSE/open-build-service/commit/d76874cb68fce1a32acac8... Author: Björn Geuken <bgeuken@suse.de> Date: 2018-11-02 (Fri, 02 Nov 2018) Changed paths: M src/api/app/helpers/webui/buildresult_helper.rb M src/api/app/views/webui2/shared/_open_requests.html.haml M src/api/app/views/webui2/status_messages/_item.html.haml M src/api/app/views/webui2/webui/attribute/_form.html.haml M src/api/app/views/webui2/webui/main/_status_messages.html.haml M src/api/app/views/webui2/webui/package/side_links/_show_derived_packages.html.haml M src/api/app/views/webui2/webui/package/side_links/_show_devel_package.html.haml M src/api/app/views/webui2/webui/package/side_links/_show_developed_packages.html.haml M src/api/app/views/webui2/webui/package/side_links/_show_inherited_from_project.html.haml M src/api/app/views/webui2/webui/package/side_links/_show_linkinfo.html.haml M src/api/app/views/webui2/webui/package/side_links/_show_patchinfo.html.haml Log Message: ----------- Use text-info for coloring elements that inform users We have beeeen using the secondory color before. Which kinda worked because it's blue. But as soon as we change the secondary color we would have to update this. Kudos goes to @hellcp for pointing this out. Part of #6091 Commit: eed4c044c36553623cab673a381f7d28ecd773a0 https://github.com/openSUSE/open-build-service/commit/eed4c044c36553623cab67... Author: Björn Geuken <bgeuken@suse.de> Date: 2018-11-02 (Fri, 02 Nov 2018) Changed paths: M src/api/app/helpers/webui/buildresult_helper.rb M src/api/app/helpers/webui/packages/job_history_helper.rb M src/api/app/views/webui2/shared/_flag_popover.html.haml M src/api/app/views/webui2/shared/_open_requests.html.haml M src/api/app/views/webui2/shared/_repositories_flag_table_column.html.haml M src/api/app/views/webui2/status_messages/_item.html.haml M src/api/app/views/webui2/webui/attribute/_form.html.haml M src/api/app/views/webui2/webui/main/_status_messages.html.haml M src/api/app/views/webui2/webui/package/side_links/_show_derived_packages.html.haml M src/api/app/views/webui2/webui/package/side_links/_show_devel_package.html.haml M src/api/app/views/webui2/webui/package/side_links/_show_developed_packages.html.haml M src/api/app/views/webui2/webui/package/side_links/_show_inherited_from_project.html.haml M src/api/app/views/webui2/webui/package/side_links/_show_linkinfo.html.haml M src/api/app/views/webui2/webui/package/side_links/_show_patchinfo.html.haml Log Message: ----------- Merge pull request #6154 from bgeuken/update_colors_in_webui2 Replace usage of text-secondary and text-primary for coloring elements that present actions and information Compare: https://github.com/openSUSE/open-build-service/compare/39dbc818a748...eed4c0... **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.
participants (1)
-
Björn Geuken