[obs-commits] [openSUSE/open-build-service] 5f2141: Drop unused exceptions from status message control...
Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 5f214178f4064ab47cfed730bca05815de5f1c12 https://github.com/openSUSE/open-build-service/commit/5f214178f4064ab47cfed7... Author: Björn Geuken <bgeuken@suse.de> Date: 2018-08-30 (Thu, 30 Aug 2018) Changed paths: M src/api/app/controllers/status_controller.rb Log Message: ----------- Drop unused exceptions from status message controller * NotSubmitRequest * MultipleNotSupported * NotFoundError Co-authored-by: Victor Pereira <vpereira@suse.com> Commit: 433c94083e84371516d396c5344607f158e6bfef https://github.com/openSUSE/open-build-service/commit/433c94083e84371516d396... Author: Björn Geuken <bgeuken@suse.de> Date: 2018-08-30 (Thu, 30 Aug 2018) Changed paths: M ReleaseNotes-2.10 M src/api/app/controllers/status_controller.rb A src/api/app/controllers/status_messages_controller.rb R src/api/app/views/status/_messages.xml.builder A src/api/app/views/status_messages/index.xml.builder M src/api/config/routes.rb M src/api/test/functional/status_controller_test.rb Log Message: ----------- Move status messages related actions to their own controller These actions are all responsible for a single object and deserve their own controller. In addition we: * Changed action name and route of "update" action which is actually a create (for creating one or multiple status messages) * Dropped public routes for status messages. Public routes are only used for innterconnects. We don't need to cover status messages for that (aka. it's not used for that purpose) Co-authored-by: Victor Pereira <vpereira@suse.com> Commit: c6b9d722f7f21329f3ba0bab0e5da89756df4b24 https://github.com/openSUSE/open-build-service/commit/c6b9d722f7f21329f3ba0b... Author: Björn Geuken <bgeuken@suse.de> Date: 2018-08-30 (Thu, 30 Aug 2018) Changed paths: A src/api/spec/controllers/status_messages_controller_spec.rb Log Message: ----------- Add tests for index and show action of status message controller Co-authored-by: Victor Pereira <vpereira@suse.com> Commit: 38f2ce1ebfe9521c373dd66066142c1283cab1a9 https://github.com/openSUSE/open-build-service/commit/38f2ce1ebfe9521c373dd6... Author: Björn Geuken <bgeuken@suse.de> Date: 2018-08-31 (Fri, 31 Aug 2018) Changed paths: M src/api/app/controllers/status_messages_controller.rb Log Message: ----------- Refactor creation of status messages in controller The method call is simple enough to not generate a helper method. Co-authored-by: Victor Pereira <vpereira@suse.com> Commit: b4843320837f9134b95e1740f69ed64c96ce951c https://github.com/openSUSE/open-build-service/commit/b4843320837f9134b95e17... Author: Björn Geuken <bgeuken@suse.de> Date: 2018-08-31 (Fri, 31 Aug 2018) Changed paths: M src/api/app/controllers/status_messages_controller.rb M src/api/spec/controllers/status_messages_controller_spec.rb Log Message: ----------- Respond with created status messages when using the API Instead of returing with a generic "<status code='ok'/>" we now return the XML representation of the created objects. This allows to identify the created messages (via their id) and check the content of the created messages. Commit: 670b23095acebea6b6e1dd5df29e670aa34154d9 https://github.com/openSUSE/open-build-service/commit/670b23095acebea6b6e1dd... Author: Björn Geuken <bgeuken@suse.de> Date: 2018-08-31 (Fri, 31 Aug 2018) Changed paths: M docs/api/api/api.txt Log Message: ----------- Update API documentation of status message routes * Add undocumented routes * Update existing routes Commit: 6a0b0d469779afd6c61ca27f9ddb66fa5dd9dea0 https://github.com/openSUSE/open-build-service/commit/6a0b0d469779afd6c61ca2... Author: Björn Geuken <bgeuken@suse.de> Date: 2018-08-31 (Fri, 31 Aug 2018) Changed paths: M ReleaseNotes-2.10 M docs/api/api/api.txt M src/api/app/controllers/status_controller.rb A src/api/app/controllers/status_messages_controller.rb R src/api/app/views/status/_messages.xml.builder A src/api/app/views/status_messages/index.xml.builder M src/api/config/routes.rb A src/api/spec/controllers/status_messages_controller_spec.rb M src/api/test/functional/status_controller_test.rb Log Message: ----------- Merge pull request #5739 from bgeuken/refactor_status_controller Refactor status controller Compare: https://github.com/openSUSE/open-build-service/compare/3f6c08bbd69c...6a0b0d... **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.
participants (1)
-
Björn Geuken