[obs-commits] [openSUSE/open-build-service] a790ff: [api][webui] Enable rubocop rule to enforce using ...
Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: a790ffd22f21642f43f593bf7427f4d6c053c90a https://github.com/openSUSE/open-build-service/commit/a790ffd22f21642f43f593... Author: Björn Geuken <bgeuken@suse.de> Date: 2016-11-01 (Tue, 01 Nov 2016) Changed paths: M src/api/.rubocop.yml M src/api/.rubocop_todo.yml M src/api/Gemfile M src/api/Rakefile M src/api/app/controllers/about_controller.rb M src/api/app/controllers/application_controller.rb M src/api/app/controllers/architectures_controller.rb M src/api/app/controllers/attribute_controller.rb M src/api/app/controllers/build_controller.rb M src/api/app/controllers/configurations_controller.rb M src/api/app/controllers/distributions_controller.rb M src/api/app/controllers/group_controller.rb M src/api/app/controllers/issue_trackers_controller.rb M src/api/app/controllers/issues_controller.rb M src/api/app/controllers/main_controller.rb M src/api/app/controllers/message_controller.rb M src/api/app/controllers/person_controller.rb M src/api/app/controllers/public_controller.rb M src/api/app/controllers/published_controller.rb M src/api/app/controllers/request_controller.rb M src/api/app/controllers/search_controller.rb M src/api/app/controllers/source_controller.rb M src/api/app/controllers/statistics_controller.rb M src/api/app/controllers/tag_controller.rb M src/api/app/controllers/test_controller.rb M src/api/app/controllers/trigger_controller.rb M src/api/app/controllers/webui/apidocs_controller.rb M src/api/app/controllers/webui/attribute_controller.rb M src/api/app/controllers/webui/feeds_controller.rb M src/api/app/controllers/webui/main_controller.rb M src/api/app/controllers/webui/monitor_controller.rb M src/api/app/controllers/webui/package_controller.rb M src/api/app/controllers/webui/patchinfo_controller.rb M src/api/app/controllers/webui/project_controller.rb M src/api/app/controllers/webui/repositories_controller.rb M src/api/app/controllers/webui/request_controller.rb M src/api/app/controllers/webui/user_controller.rb M src/api/app/controllers/webui/webui_controller.rb M src/api/app/controllers/wizard_controller.rb M src/api/app/helpers/flag_helper.rb M src/api/app/helpers/maintenance_helper.rb M src/api/app/helpers/webui/issue_tracker_helper.rb M src/api/app/helpers/webui/package_helper.rb M src/api/app/helpers/webui/patchinfo_helper.rb M src/api/app/helpers/webui/project_helper.rb M src/api/app/indices/package_index.rb M src/api/app/indices/project_index.rb M src/api/app/jobs/project_status_calculator.rb M src/api/app/mixins/build_log_support.rb M src/api/app/mixins/has_attributes.rb M src/api/app/mixins/has_ratings.rb M src/api/app/models/architecture.rb M src/api/app/models/attrib.rb M src/api/app/models/attrib_namespace.rb M src/api/app/models/attrib_type.rb M src/api/app/models/backend_file.rb M src/api/app/models/binary_release.rb M src/api/app/models/branch_package.rb M src/api/app/models/bs_request.rb M src/api/app/models/bs_request_action.rb M src/api/app/models/bs_request_action_accept_info.rb M src/api/app/models/bs_request_action_add_role.rb M src/api/app/models/bs_request_action_maintenance_incident.rb M src/api/app/models/bs_request_action_maintenance_release.rb M src/api/app/models/bs_request_action_set_bugowner.rb M src/api/app/models/channel.rb M src/api/app/models/channel_binary.rb M src/api/app/models/comment.rb M src/api/app/models/download_repository.rb M src/api/app/models/flag.rb M src/api/app/models/full_text_search.rb M src/api/app/models/group.rb M src/api/app/models/group_maintainer.rb M src/api/app/models/groups_user.rb M src/api/app/models/issue.rb M src/api/app/models/issue_tracker.rb M src/api/app/models/linked_project.rb M src/api/app/models/maintained_project.rb M src/api/app/models/maintenance_incident.rb M src/api/app/models/message.rb M src/api/app/models/owner.rb M src/api/app/models/package.rb M src/api/app/models/patchinfo.rb M src/api/app/models/path_element.rb M src/api/app/models/product.rb M src/api/app/models/project.rb M src/api/app/models/rating.rb M src/api/app/models/release_target.rb M src/api/app/models/repository.rb M src/api/app/models/review.rb M src/api/app/models/role.rb M src/api/app/models/service.rb M src/api/app/models/static_permission.rb M src/api/app/models/status_message.rb M src/api/app/models/tag.rb M src/api/app/models/tagging.rb M src/api/app/models/unregistered_user.rb M src/api/app/models/user.rb M src/api/app/models/user_ldap_strategy.rb M src/api/config/application.rb M src/api/config/deploy.rb M src/api/config/initializers/activexml.rb M src/api/config/initializers/session_store.rb M src/api/config/initializers/wrap_parameters.rb M src/api/db/migrate/20120529150500_spaces_in_tracker_regexen.rb M src/api/db/migrate/20121120124300_add_owner_root_project_attrib_type.rb M src/api/db/migrate/20121121142111_watchlist_use_ids.rb M src/api/db/migrate/20130618083665_add_obsname_configuration.rb M src/api/db/migrate/20130621083665_add_attrib_issues.rb M src/api/db/migrate/20130626160000_attribute_issue_marker.rb M src/api/db/migrate/20130702083665_options_yml_to_configuration.rb M src/api/db/migrate/20130807071147_add_delta_to_projects_and_packages.rb M src/api/db/migrate/20131006162847_create_sessions.rb M src/api/db/migrate/20131023063641_add_obs_branch_repositories_attribute.rb M src/api/db/migrate/20140123063641_auto_cleanup_attribute.rb M src/api/db/migrate/20140213101042_add_admin_email_configuration.rb M src/api/db/migrate/20140218174400_cleanup_empty_projects.rb M src/api/db/migrate/20140219185200_disable_publish_for_branches.rb M src/api/db/migrate/20140624101042_add_package_tracking.rb M src/api/db/migrate/20140704101043_remove_unique_index_from_attrib_values.rb M src/api/db/migrate/20140827105426_add_index_for_product_tracking.rb M src/api/db/migrate/20140908135426_incident_priority_attribute.rb M src/api/db/migrate/20140916135426_project_maintains.rb M src/api/db/migrate/20141002231042_add_default_tracker_configuration.rb M src/api/db/migrate/20141022105426_add_index_for_history.rb M src/api/db/migrate/20141107135426_embargo_attribute.rb M src/api/db/migrate/20141110105426_fix_product_media_uniq_index.rb M src/api/db/migrate/20141201135426_make_origin_older_attribute.rb M src/api/db/migrate/20141202135426_add_makeoriginolder_option.rb M src/api/db/migrate/20141208135426_add_channel_target_disable_option.rb M src/api/db/migrate/20150127135426_add_channel_index.rb M src/api/db/migrate/20150227063641_add_obs_branch_skip_repositories_attribute.rb M src/api/db/migrate/20150625105426_multiple_incident_counters.rb M src/api/db/migrate/20160808135426_planned_release_attribute.rb M src/api/lib/activexml/node.rb M src/api/lib/activexml/transport.rb A src/api/lib/prometheus_registry.rb M src/api/lib/tasks/capistrano.rake M src/api/lib/tasks/cleanup_sessions.rake M src/api/lib/tasks/databases.rake M src/api/lib/tasks/delayed_job.rake M src/api/lib/tasks/extract.rake M src/api/lib/tasks/history.rake M src/api/lib/tasks/sprites.rake M src/api/lib/workers/accept_requests.rb M src/api/lib/xpath_engine.rb M src/api/script/import M src/api/spec/controllers/webui/user_controller_spec.rb M src/api/spec/features/webui/attributes_spec.rb M src/api/spec/features/webui/comments_spec.rb M src/api/spec/features/webui/groups_spec.rb M src/api/spec/features/webui/login_spec.rb M src/api/spec/features/webui/main_page_spec.rb M src/api/spec/features/webui/notifications_spec.rb M src/api/spec/features/webui/packages_spec.rb M src/api/spec/features/webui/projects_spec.rb M src/api/spec/features/webui/repositories_spec.rb M src/api/spec/features/webui/requests_spec.rb M src/api/spec/features/webui/sign_up_spec.rb M src/api/spec/features/webui/watchlists_spec.rb M src/api/spec/spec_helper.rb M src/api/spec/support/database_cleaner.rb M src/api/spec/support/vcr.rb M src/api/test/activexml_matcher.rb M src/api/test/functional/about_controller_test.rb M src/api/test/functional/attributes_test.rb M src/api/test/functional/binary_release_test.rb M src/api/test/functional/branch_publish_flag_test.rb M src/api/test/functional/build_controller_test.rb M src/api/test/functional/channel_maintenance_test.rb M src/api/test/functional/configurations_controller_test.rb M src/api/test/functional/cross_build_test.rb M src/api/test/functional/distributions_controller_test.rb M src/api/test/functional/group_request_test.rb M src/api/test/functional/group_test.rb M src/api/test/functional/interconnect_test.rb M src/api/test/functional/issue_controller_test.rb M src/api/test/functional/issue_trackers_controller_test.rb M src/api/test/functional/kgraft_maintenance_test.rb M src/api/test/functional/maintenance_test.rb M src/api/test/functional/message_controller_test.rb M src/api/test/functional/person_controller_test.rb M src/api/test/functional/product_test.rb M src/api/test/functional/public_controller_test.rb M src/api/test/functional/published_controller_test.rb M src/api/test/functional/read_permission_test.rb M src/api/test/functional/release_management_test.rb M src/api/test/functional/request_controller_test.rb M src/api/test/functional/search_controller_test.rb M src/api/test/functional/source_controller_test.rb M src/api/test/functional/source_services_test.rb M src/api/test/functional/statistics_controller_test.rb M src/api/test/functional/status_controller_test.rb M src/api/test/functional/tag_controller_test.rb M src/api/test/functional/webui/apidocs_controller_test.rb M src/api/test/functional/webui/attributes_test.rb M src/api/test/functional/webui/create_test.rb M src/api/test/functional/webui/owner_search_test.rb M src/api/test/functional/webui/package_branch_test.rb M src/api/test/functional/webui/package_create_test.rb M src/api/test/functional/webui/package_edit_source_test.rb M src/api/test/functional/webui/package_edit_test.rb M src/api/test/functional/webui/project_controller_test.rb M src/api/test/functional/webui/search_controller_test.rb M src/api/test/functional/webui/users_test.rb M src/api/test/functional/wizard_controller_test.rb M src/api/test/functional/zzz_post_consistency_test.rb M src/api/test/unit/attribute_test.rb M src/api/test/unit/binary_release.rb M src/api/test/unit/bs_request_test.rb M src/api/test/unit/build_flag_test.rb M src/api/test/unit/code_quality_test.rb M src/api/test/unit/debug_flag_test.rb M src/api/test/unit/flag_test.rb M src/api/test/unit/issue_test.rb M src/api/test/unit/project_test.rb M src/api/test/unit/publish_flag_test.rb M src/api/test/unit/role_test.rb M src/api/test/unit/tag_test.rb M src/api/test/unit/user_test.rb M src/api/test/unit/validator_test.rb Log Message: ----------- [api][webui] Enable rubocop rule to enforce using ruby1.9 hash syntax (foo: 'bar') Commit: 48734f73147b5479033f3cdf136a194a75877ed8 https://github.com/openSUSE/open-build-service/commit/48734f73147b5479033f3c... Author: Björn Geuken <bgeuken@suse.de> Date: 2016-11-01 (Tue, 01 Nov 2016) Changed paths: M src/api/app/jobs/project_status_calculator.rb M src/api/app/models/bs_request_action_delete.rb M src/api/app/models/full_text_search.rb M src/api/app/models/package.rb Log Message: ----------- [api][webui] Rubocop: Apply ruby19_no_mixed_keys rule for HashSyntax cop This means that in cases where we have a stringified key, the whole hash needs to be in hash rocket syntax. Commit: 65289de770ec4a64a0b0d7fb80034f1ae6429f58 https://github.com/openSUSE/open-build-service/commit/65289de770ec4a64a0b0d7... Author: Ana María Martínez Gómez <ammartinez@suse.de> Date: 2016-11-02 (Wed, 02 Nov 2016) Changed paths: M src/api/.rubocop.yml M src/api/.rubocop_todo.yml M src/api/Gemfile M src/api/Rakefile M src/api/app/controllers/about_controller.rb M src/api/app/controllers/application_controller.rb M src/api/app/controllers/architectures_controller.rb M src/api/app/controllers/attribute_controller.rb M src/api/app/controllers/build_controller.rb M src/api/app/controllers/configurations_controller.rb M src/api/app/controllers/distributions_controller.rb M src/api/app/controllers/group_controller.rb M src/api/app/controllers/issue_trackers_controller.rb M src/api/app/controllers/issues_controller.rb M src/api/app/controllers/main_controller.rb M src/api/app/controllers/message_controller.rb M src/api/app/controllers/person_controller.rb M src/api/app/controllers/public_controller.rb M src/api/app/controllers/published_controller.rb M src/api/app/controllers/request_controller.rb M src/api/app/controllers/search_controller.rb M src/api/app/controllers/source_controller.rb M src/api/app/controllers/statistics_controller.rb M src/api/app/controllers/tag_controller.rb M src/api/app/controllers/test_controller.rb M src/api/app/controllers/trigger_controller.rb M src/api/app/controllers/webui/apidocs_controller.rb M src/api/app/controllers/webui/attribute_controller.rb M src/api/app/controllers/webui/feeds_controller.rb M src/api/app/controllers/webui/main_controller.rb M src/api/app/controllers/webui/monitor_controller.rb M src/api/app/controllers/webui/package_controller.rb M src/api/app/controllers/webui/patchinfo_controller.rb M src/api/app/controllers/webui/project_controller.rb M src/api/app/controllers/webui/repositories_controller.rb M src/api/app/controllers/webui/request_controller.rb M src/api/app/controllers/webui/user_controller.rb M src/api/app/controllers/webui/webui_controller.rb M src/api/app/controllers/wizard_controller.rb M src/api/app/helpers/flag_helper.rb M src/api/app/helpers/maintenance_helper.rb M src/api/app/helpers/webui/issue_tracker_helper.rb M src/api/app/helpers/webui/package_helper.rb M src/api/app/helpers/webui/patchinfo_helper.rb M src/api/app/helpers/webui/project_helper.rb M src/api/app/indices/package_index.rb M src/api/app/indices/project_index.rb M src/api/app/jobs/project_status_calculator.rb M src/api/app/mixins/build_log_support.rb M src/api/app/mixins/has_attributes.rb M src/api/app/mixins/has_ratings.rb M src/api/app/models/architecture.rb M src/api/app/models/attrib.rb M src/api/app/models/attrib_namespace.rb M src/api/app/models/attrib_type.rb M src/api/app/models/backend_file.rb M src/api/app/models/binary_release.rb M src/api/app/models/branch_package.rb M src/api/app/models/bs_request.rb M src/api/app/models/bs_request_action.rb M src/api/app/models/bs_request_action_accept_info.rb M src/api/app/models/bs_request_action_add_role.rb M src/api/app/models/bs_request_action_delete.rb M src/api/app/models/bs_request_action_maintenance_incident.rb M src/api/app/models/bs_request_action_maintenance_release.rb M src/api/app/models/bs_request_action_set_bugowner.rb M src/api/app/models/channel.rb M src/api/app/models/channel_binary.rb M src/api/app/models/comment.rb M src/api/app/models/download_repository.rb M src/api/app/models/flag.rb M src/api/app/models/full_text_search.rb M src/api/app/models/group.rb M src/api/app/models/group_maintainer.rb M src/api/app/models/groups_user.rb M src/api/app/models/issue.rb M src/api/app/models/issue_tracker.rb M src/api/app/models/linked_project.rb M src/api/app/models/maintained_project.rb M src/api/app/models/maintenance_incident.rb M src/api/app/models/message.rb M src/api/app/models/owner.rb M src/api/app/models/package.rb M src/api/app/models/patchinfo.rb M src/api/app/models/path_element.rb M src/api/app/models/product.rb M src/api/app/models/project.rb M src/api/app/models/rating.rb M src/api/app/models/release_target.rb M src/api/app/models/repository.rb M src/api/app/models/review.rb M src/api/app/models/role.rb M src/api/app/models/service.rb M src/api/app/models/static_permission.rb M src/api/app/models/status_message.rb M src/api/app/models/tag.rb M src/api/app/models/tagging.rb M src/api/app/models/unregistered_user.rb M src/api/app/models/user.rb M src/api/app/models/user_ldap_strategy.rb M src/api/config/application.rb M src/api/config/deploy.rb M src/api/config/initializers/activexml.rb M src/api/config/initializers/session_store.rb M src/api/config/initializers/wrap_parameters.rb M src/api/db/migrate/20120529150500_spaces_in_tracker_regexen.rb M src/api/db/migrate/20121120124300_add_owner_root_project_attrib_type.rb M src/api/db/migrate/20121121142111_watchlist_use_ids.rb M src/api/db/migrate/20130618083665_add_obsname_configuration.rb M src/api/db/migrate/20130621083665_add_attrib_issues.rb M src/api/db/migrate/20130626160000_attribute_issue_marker.rb M src/api/db/migrate/20130702083665_options_yml_to_configuration.rb M src/api/db/migrate/20130807071147_add_delta_to_projects_and_packages.rb M src/api/db/migrate/20131006162847_create_sessions.rb M src/api/db/migrate/20131023063641_add_obs_branch_repositories_attribute.rb M src/api/db/migrate/20140123063641_auto_cleanup_attribute.rb M src/api/db/migrate/20140213101042_add_admin_email_configuration.rb M src/api/db/migrate/20140218174400_cleanup_empty_projects.rb M src/api/db/migrate/20140219185200_disable_publish_for_branches.rb M src/api/db/migrate/20140624101042_add_package_tracking.rb M src/api/db/migrate/20140704101043_remove_unique_index_from_attrib_values.rb M src/api/db/migrate/20140827105426_add_index_for_product_tracking.rb M src/api/db/migrate/20140908135426_incident_priority_attribute.rb M src/api/db/migrate/20140916135426_project_maintains.rb M src/api/db/migrate/20141002231042_add_default_tracker_configuration.rb M src/api/db/migrate/20141022105426_add_index_for_history.rb M src/api/db/migrate/20141107135426_embargo_attribute.rb M src/api/db/migrate/20141110105426_fix_product_media_uniq_index.rb M src/api/db/migrate/20141201135426_make_origin_older_attribute.rb M src/api/db/migrate/20141202135426_add_makeoriginolder_option.rb M src/api/db/migrate/20141208135426_add_channel_target_disable_option.rb M src/api/db/migrate/20150127135426_add_channel_index.rb M src/api/db/migrate/20150227063641_add_obs_branch_skip_repositories_attribute.rb M src/api/db/migrate/20150625105426_multiple_incident_counters.rb M src/api/db/migrate/20160808135426_planned_release_attribute.rb M src/api/lib/activexml/node.rb M src/api/lib/activexml/transport.rb A src/api/lib/prometheus_registry.rb M src/api/lib/tasks/capistrano.rake M src/api/lib/tasks/cleanup_sessions.rake M src/api/lib/tasks/databases.rake M src/api/lib/tasks/delayed_job.rake M src/api/lib/tasks/extract.rake M src/api/lib/tasks/history.rake M src/api/lib/tasks/sprites.rake M src/api/lib/workers/accept_requests.rb M src/api/lib/xpath_engine.rb M src/api/script/import M src/api/spec/controllers/webui/user_controller_spec.rb M src/api/spec/features/webui/attributes_spec.rb M src/api/spec/features/webui/comments_spec.rb M src/api/spec/features/webui/groups_spec.rb M src/api/spec/features/webui/login_spec.rb M src/api/spec/features/webui/main_page_spec.rb M src/api/spec/features/webui/notifications_spec.rb M src/api/spec/features/webui/packages_spec.rb M src/api/spec/features/webui/projects_spec.rb M src/api/spec/features/webui/repositories_spec.rb M src/api/spec/features/webui/requests_spec.rb M src/api/spec/features/webui/sign_up_spec.rb M src/api/spec/features/webui/watchlists_spec.rb M src/api/spec/spec_helper.rb M src/api/spec/support/database_cleaner.rb M src/api/spec/support/vcr.rb M src/api/test/activexml_matcher.rb M src/api/test/functional/about_controller_test.rb M src/api/test/functional/attributes_test.rb M src/api/test/functional/binary_release_test.rb M src/api/test/functional/branch_publish_flag_test.rb M src/api/test/functional/build_controller_test.rb M src/api/test/functional/channel_maintenance_test.rb M src/api/test/functional/configurations_controller_test.rb M src/api/test/functional/cross_build_test.rb M src/api/test/functional/distributions_controller_test.rb M src/api/test/functional/group_request_test.rb M src/api/test/functional/group_test.rb M src/api/test/functional/interconnect_test.rb M src/api/test/functional/issue_controller_test.rb M src/api/test/functional/issue_trackers_controller_test.rb M src/api/test/functional/kgraft_maintenance_test.rb M src/api/test/functional/maintenance_test.rb M src/api/test/functional/message_controller_test.rb M src/api/test/functional/person_controller_test.rb M src/api/test/functional/product_test.rb M src/api/test/functional/public_controller_test.rb M src/api/test/functional/published_controller_test.rb M src/api/test/functional/read_permission_test.rb M src/api/test/functional/release_management_test.rb M src/api/test/functional/request_controller_test.rb M src/api/test/functional/search_controller_test.rb M src/api/test/functional/source_controller_test.rb M src/api/test/functional/source_services_test.rb M src/api/test/functional/statistics_controller_test.rb M src/api/test/functional/status_controller_test.rb M src/api/test/functional/tag_controller_test.rb M src/api/test/functional/webui/apidocs_controller_test.rb M src/api/test/functional/webui/attributes_test.rb M src/api/test/functional/webui/create_test.rb M src/api/test/functional/webui/owner_search_test.rb M src/api/test/functional/webui/package_branch_test.rb M src/api/test/functional/webui/package_create_test.rb M src/api/test/functional/webui/package_edit_source_test.rb M src/api/test/functional/webui/package_edit_test.rb M src/api/test/functional/webui/project_controller_test.rb M src/api/test/functional/webui/search_controller_test.rb M src/api/test/functional/webui/users_test.rb M src/api/test/functional/wizard_controller_test.rb M src/api/test/functional/zzz_post_consistency_test.rb M src/api/test/unit/attribute_test.rb M src/api/test/unit/binary_release.rb M src/api/test/unit/bs_request_test.rb M src/api/test/unit/build_flag_test.rb M src/api/test/unit/code_quality_test.rb M src/api/test/unit/debug_flag_test.rb M src/api/test/unit/flag_test.rb M src/api/test/unit/issue_test.rb M src/api/test/unit/project_test.rb M src/api/test/unit/publish_flag_test.rb M src/api/test/unit/role_test.rb M src/api/test/unit/tag_test.rb M src/api/test/unit/user_test.rb M src/api/test/unit/validator_test.rb Log Message: ----------- Merge pull request #2277 from bgeuken/rubocop_hash_syntax [api][webui] Enable rubocop rule to enforce using ruby1.9 hash syntax (foo: 'bar') Compare: https://github.com/openSUSE/open-build-service/compare/6502aa216e33...65289d...
participants (1)
-
Ana María Martínez Gómez