Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 9dad7aa1e4cb6680de3c2993fd2dd5a889f07183 https://github.com/openSUSE/open-build-service/commit/9dad7aa1e4cb6680de3c29... Author: Saray Cabrera Padrón Date: 2019-06-17 (Mon, 17 Jun 2019) Changed paths: M src/api/app/models/relationship.rb M src/api/spec/models/relationship_spec.rb Log Message: ----------- Avoid associating a nobody user with a project or package Strange way to define a custom validation, it raises an exception instead of adding errors as usual because the error doesn't reach the view due to the Relationship::AddRole@add_role handling. Co-authored-by: David Kang Commit: 970ca30a824f1958b56bfdbd4d509517527b8573 https://github.com/openSUSE/open-build-service/commit/970ca30a824f1958b56bfd... Author: Saray Cabrera Padrón Date: 2019-06-17 (Mon, 17 Jun 2019) Changed paths: A src/api/app/validators/allowed_user_validator.rb Log Message: ----------- Add a custom validation to check allowed users for associations There are many resources that can set a relationship with a user. However, users like '_nobody_' should be banned for that. Commit: aea4810e6596bcd0c2ada7b2d04b27d8c3c721e5 https://github.com/openSUSE/open-build-service/commit/aea4810e6596bcd0c2ada7... Author: Saray Cabrera Padrón Date: 2019-06-17 (Mon, 17 Jun 2019) Changed paths: M src/api/app/models/groups_user.rb M src/api/spec/models/group_spec.rb Log Message: ----------- Avoid adding a banned user as member of a group Uses a custom validation to check if the user is one of the banned users. Commit: 5fc48250b80e8f079b7322ed3d6e9fbfd3ccab1c https://github.com/openSUSE/open-build-service/commit/5fc48250b80e8f079b7322... Author: Saray Cabrera Padrón Date: 2019-06-17 (Mon, 17 Jun 2019) Changed paths: M src/api/app/models/review.rb M src/api/spec/models/review_spec.rb Log Message: ----------- Avoid adding a banned user as reviewer Uses a custom validation to check if the user is one of the banned users. Co-authored-by: David Kang Commit: 3d610c1930d212853a3140b4c67d6d3e04269ee3 https://github.com/openSUSE/open-build-service/commit/3d610c1930d212853a3140... Author: Dany Marcoux Date: 2019-06-18 (Tue, 18 Jun 2019) Changed paths: M src/api/app/models/groups_user.rb M src/api/app/models/relationship.rb M src/api/app/models/review.rb A src/api/app/validators/allowed_user_validator.rb M src/api/spec/models/group_spec.rb M src/api/spec/models/relationship_spec.rb M src/api/spec/models/review_spec.rb Log Message: ----------- Merge pull request #7777 from saraycp/bug_nobody Avoid having associations with user _nodody_ Compare: https://github.com/openSUSE/open-build-service/compare/13729fbab42e...3d610c...