[obs-commits] [openSUSE/open-build-service] aa99ad: [api] Validate uniqueness of bs request actions
Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: aa99adb3b9426597d1cb289c89998465a8d27102 https://github.com/openSUSE/open-build-service/commit/aa99adb3b9426597d1cb28... Author: Björn Geuken <bgeuken@suse.de> Date: 2017-04-03 (Mon, 03 Apr 2017) Changed paths: M src/api/app/models/bs_request_action.rb Log Message: ----------- [api] Validate uniqueness of bs request actions Commit: 23d9e23799ada1d24eca252094b6f307d3949932 https://github.com/openSUSE/open-build-service/commit/23d9e23799ada1d24eca25... Author: Björn Geuken <bgeuken@suse.de> Date: 2017-04-03 (Mon, 03 Apr 2017) Changed paths: M src/api/spec/models/bs_request_spec.rb Log Message: ----------- [ci] Fix naming of BsRequest spec Commit: 08aacbc2cfb29a102c6e051921d04e4d27f3eca1 https://github.com/openSUSE/open-build-service/commit/08aacbc2cfb29a102c6e05... Author: Björn Geuken <bgeuken@suse.de> Date: 2017-04-03 (Mon, 03 Apr 2017) Changed paths: M src/api/spec/models/bs_request_action_spec.rb Log Message: ----------- [ci] Add uniqueness validation for bs request actions Using the inbuild rspec validation test helper didn't work, because of the association ot BsRequestType named 'type'. ===== 1) BsRequestAction validates uniquness of type among bs requests Failure/Error: type_to_class_name(type_name.to_sym) || super ActiveRecord::SubclassNotFound: The single-table inheritance mechanism failed to locate the subclass: 'an arbitrary value'. This error is raised because the column 'type' is reserved for storing the class in case of inheritance. Please rename this column if you didn't intend it to be used for storing the inheritance class or overwrite BsRequestAction.inheritance_column to use another column for that information. # ./app/models/bs_request_action.rb:87:in `find_sti_class' # ./spec/models/bs_request_action_spec.rb:7:in `block (2 levels) in <top (required)>' # ./spec/support/logging.rb:4:in `block (2 levels) in <top (required)>' # ------------------ # --- Caused by: --- # NameError: # wrong constant name an arbitrary value # ./app/models/bs_request_action.rb:87:in `find_sti_class' Commit: 658f1e9f717fe55664cbe057d8b381cbc0f2a4b6 https://github.com/openSUSE/open-build-service/commit/658f1e9f717fe55664cbe0... Author: Henne Vogelsang <hvogel@opensuse.org> Date: 2017-04-04 (Tue, 04 Apr 2017) Changed paths: M src/api/app/models/bs_request_action.rb M src/api/spec/models/bs_request_action_spec.rb M src/api/spec/models/bs_request_spec.rb Log Message: ----------- Merge pull request #2916 from bgeuken/avoid_double_release_ Avoid double release Compare: https://github.com/openSUSE/open-build-service/compare/e40b9b1e0815...658f1e...
participants (1)
-
Henne Vogelsang