[obs-commits] [openSUSE/open-build-service] 118bfc: [webui] Fix previous / next link for watching mult...
Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 118bfc74632b425316d424d7c2514821ecc7bf92 https://github.com/openSUSE/open-build-service/commit/118bfc74632b425316d424... Author: Björn Geuken <bgeuken@suse.de> Date: 2016-05-02 (Mon, 02 May 2016) Changed paths: M src/api/app/views/webui/request/show.html.erb Log Message: ----------- [webui] Fix previous / next link for watching multiple BS requests Commit: 5de350054f6c38e2528d71f03f40bf1ac11a2d2a https://github.com/openSUSE/open-build-service/commit/5de350054f6c38e2528d71... Author: Björn Geuken <bgeuken@suse.de> Date: 2016-05-02 (Mon, 02 May 2016) Changed paths: M src/api/app/controllers/webui/request_controller.rb Log Message: ----------- [webui] Refactor handling index parameter Commit: 9e7f662b277b46d4a2d2b905f5fb6b0c9dda5f36 https://github.com/openSUSE/open-build-service/commit/9e7f662b277b46d4a2d2b9... Author: Björn Geuken <bgeuken@suse.de> Date: 2016-05-02 (Mon, 02 May 2016) Changed paths: M src/api/app/controllers/webui/request_controller.rb Log Message: ----------- [webui] Remove superflous code Our routes require to have a number parameter. Thus the check isn't needed. Requests without a number will get a 404. Commit: be164fd0d07f3d2ba5a4328266047eeb9ea78105 https://github.com/openSUSE/open-build-service/commit/be164fd0d07f3d2ba5a432... Author: Björn Geuken <bgeuken@suse.de> Date: 2016-05-02 (Mon, 02 May 2016) Changed paths: M src/api/app/controllers/webui/request_controller.rb Log Message: ----------- [webui] Fix next / previous links of Bs Requests The links and stored session lists were still using ids, while we recently changed to use the number attribute as (external) identifier. Commit: e832b24ec78d207b26a5a81d97b5b2fd3f28a226 https://github.com/openSUSE/open-build-service/commit/e832b24ec78d207b26a5a8... Author: Björn Geuken <bgeuken@suse.de> Date: 2016-05-02 (Mon, 02 May 2016) Changed paths: M src/api/app/controllers/webui/request_controller.rb Log Message: ----------- [webui] Ensure numbers in session[:request_numbers] are unique session[:request_numbers] are used for allowing users to go through a number of requests belonging to a project. Since the implementation of selecting the next or previous item of that list is using it's index, having duplicates causes a loop which ignores requests that are not enclosed by the duplicates. Eg. [10, 5, 10, 3] would never reach 3. Commit: d656f26b9f820f31cba59112d6c0da1e1fb9ba6b https://github.com/openSUSE/open-build-service/commit/d656f26b9f820f31cba591... Author: Björn Geuken <bgeuken@suse.de> Date: 2016-05-02 (Mon, 02 May 2016) Changed paths: M src/api/app/controllers/webui/request_controller.rb Log Message: ----------- [webui] Cleanup setting elide variable in controller Commit: 856e8858a35e300d230ef7c9d7cd637f20090704 https://github.com/openSUSE/open-build-service/commit/856e8858a35e300d230ef7... Author: Björn Geuken <bgeuken@suse.de> Date: 2016-05-03 (Tue, 03 May 2016) Changed paths: M src/api/test/functional/webui/request_controller_test.rb Log Message: ----------- [ci] Add test for going through request list Commit: e362f8f812f3882a829eeab41b8ce6dd62b505a8 https://github.com/openSUSE/open-build-service/commit/e362f8f812f3882a829eea... Author: Moisés Déniz Alemán <mdeniz@users.noreply.github.com> Date: 2016-05-09 (Mon, 09 May 2016) Changed paths: M src/api/app/controllers/webui/request_controller.rb M src/api/app/views/webui/request/show.html.erb M src/api/test/functional/webui/request_controller_test.rb Log Message: ----------- Merge pull request #1773 from bgeuken/bsrequest_show LGTM :+1: Compare: https://github.com/openSUSE/open-build-service/compare/7ea129022c03...e362f8...
participants (1)
-
Moisés Déniz Alemán