[obs-commits] [openSUSE/open-build-service] c8d0a1: [api] Remove limit paramether from jobhistory_list
Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: c8d0a107bd89bdfe256a92bd8da9170d3c61af1a https://github.com/openSUSE/open-build-service/commit/c8d0a107bd89bdfe256a92... Author: Ana María Martínez Gómez <ammartinez@suse.de> Date: 2018-09-04 (Tue, 04 Sep 2018) Changed paths: M src/api/app/models/package.rb M src/api/lib/backend/api/build_results/job_history.rb Log Message: ----------- [api] Remove limit paramether from jobhistory_list The paramether was not used. Move it as default to `all_for_package`, this method is usign the limit, so it can not be removed from there even if 100 is the default in the backend. It is anyway not bad to have a second check in the frontend. Commit: e535b475cc49873cd4e3586c3d1d69857e1492f2 https://github.com/openSUSE/open-build-service/commit/e535b475cc49873cd4e358... Author: Ana María Martínez Gómez <ammartinez@suse.de> Date: 2018-09-04 (Tue, 04 Sep 2018) Changed paths: M src/api/app/controllers/webui/packages/job_history_controller.rb M src/api/app/models/package.rb M src/api/spec/models/package_spec.rb Log Message: ----------- [api] package as param instead of an options hash As it is always set in the `set_package` filter. Commit: cb9995280a6e6be90ccbdc0cc268622285d4bed0 https://github.com/openSUSE/open-build-service/commit/cb9995280a6e6be90ccbdc... Author: Ana María Martínez Gómez <ammartinez@suse.de> Date: 2018-09-04 (Tue, 04 Sep 2018) Changed paths: M src/api/app/controllers/webui/packages/job_history_controller.rb M src/api/app/models/package.rb Log Message: ----------- [api] Pass names to jobhistory_list Pass project name as is the only thing needed and by coherence with the other paramethers. Rename attributes in jobhistory_list to make clear they are just strings with the name and not objects. Commit: bbb4a444e594a7e9d05fd185881f18b15ac37b23 https://github.com/openSUSE/open-build-service/commit/bbb4a444e594a7e9d05fd1... Author: Ana María Martínez Gómez <ammartinez@suse.de> Date: 2018-09-05 (Wed, 05 Sep 2018) Changed paths: M src/api/app/controllers/webui/packages/job_history_controller.rb M src/api/app/models/package.rb M src/api/spec/models/package_spec.rb Log Message: ----------- [api] Make jobhistory_list a class method Because we are not using the instance attributes. Commit: 12e65aeccc0c6d7699c3001d3277d98406b00e93 https://github.com/openSUSE/open-build-service/commit/12e65aeccc0c6d7699c300... Author: Dany Marcoux <dmarcoux@posteo.de> Date: 2018-09-07 (Fri, 07 Sep 2018) Changed paths: M src/api/app/controllers/webui/packages/job_history_controller.rb M src/api/app/models/package.rb M src/api/lib/backend/api/build_results/job_history.rb M src/api/spec/models/package_spec.rb Log Message: ----------- Merge pull request #5170 from Ana06/options [api] Refactor option assignation as in PR review Compare: https://github.com/openSUSE/open-build-service/compare/8b28a60b5db2...12e65a... **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.
participants (1)
-
Dany Marcoux