Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 022ef27c6b523736d0eedc423afc7e7bbacc7e46 https://github.com/openSUSE/open-build-service/commit/022ef27c6b523736d0eedc... Author: Björn Geuken Date: 2017-11-29 (Wed, 29 Nov 2017) Changed paths: M src/api/spec/controllers/webui/request_controller_spec.rb Log Message: ----------- [ci] Restructure blocks of request show action ... in a coherent way. Pair-programming with @DavidKang, @Ana06, @evanrolfe. Commit: 89a79c06a6c44cfe7f542b990675b8ba3e27f059 https://github.com/openSUSE/open-build-service/commit/89a79c06a6c44cfe7f542b... Author: Björn Geuken Date: 2017-11-29 (Wed, 29 Nov 2017) Changed paths: M src/api/spec/controllers/webui/request_controller_spec.rb Log Message: ----------- [ci] Move factory creation into let statement Creation of variables should be in let statements, so the code is easier to read. Mob-programming with @DavidKang, @Ana06, @evanrolfe. Commit: 22ee8dd8b19c4111e10fa7020ea1734a728550d2 https://github.com/openSUSE/open-build-service/commit/22ee8dd8b19c4111e10fa7... Author: Björn Geuken Date: 2017-11-29 (Wed, 29 Nov 2017) Changed paths: M src/api/spec/controllers/webui/request_controller_spec.rb Log Message: ----------- [ci] Refactor usage of let statement for requests Instead of deleting relations inside the let, we do it separately to not hiding the side effect when creating instances. Mob-programming with @DavidKang, @Ana06, @evanrolfe. Commit: 359b33bff760ed9ae10426aef1f8a0d28f7887ca https://github.com/openSUSE/open-build-service/commit/359b33bff760ed9ae10426... Author: Björn Geuken Date: 2017-11-29 (Wed, 29 Nov 2017) Changed paths: M src/api/spec/controllers/webui/request_controller_spec.rb Log Message: ----------- [ci] Extend tests for modifying requests Mob-programming with @DavidKang, @Ana06, @evanrolfe. Commit: 87e1ffc289a23770a36b39ac10f0770be55c2168 https://github.com/openSUSE/open-build-service/commit/87e1ffc289a23770a36b39... Author: Björn Geuken Date: 2017-11-29 (Wed, 29 Nov 2017) Changed paths: M src/api/spec/controllers/webui/request_controller_spec.rb Log Message: ----------- [ci] Split it blocks with newlines Commit: 7c212e4829c69ca966e3f21f7485c6ebfb3f5465 https://github.com/openSUSE/open-build-service/commit/7c212e4829c69ca966e3f2... Author: Björn Geuken Date: 2017-11-29 (Wed, 29 Nov 2017) Changed paths: A src/api/spec/cassettes/Webui_RequestController/GET_show/when_there_are_no_package_maintainers/does_not_show_a_hint_to_project_maintainers_by_default.yml A src/api/spec/cassettes/Webui_RequestController/GET_show/when_there_are_package_maintainers/shows_a_hint_to_project_maintainers.yml Log Message: ----------- [ci] Add missing cassettes Commit: 50ad1f377786061865ccea439bf699472ecf8d18 https://github.com/openSUSE/open-build-service/commit/50ad1f377786061865ccea... Author: Björn Geuken Date: 2017-11-29 (Wed, 29 Nov 2017) Changed paths: M src/api/spec/controllers/webui/request_controller_spec.rb Log Message: ----------- [ci] rspec: Move get request into before block ... to be consistent with the rest of OBS. Commit: 339d6e326fecdb8ffdbeee4d3e0efa85d5acd92d https://github.com/openSUSE/open-build-service/commit/339d6e326fecdb8ffdbeee... Author: Björn Geuken Date: 2017-11-29 (Wed, 29 Nov 2017) Changed paths: A src/api/spec/cassettes/Webui_RequestController/GET_show/when_there_are_no_package_maintainers/does_not_show_a_hint_to_project_maintainers_by_default.yml A src/api/spec/cassettes/Webui_RequestController/GET_show/when_there_are_package_maintainers/shows_a_hint_to_project_maintainers.yml M src/api/spec/controllers/webui/request_controller_spec.rb Log Message: ----------- Merge pull request #4155 from bgeuken/request_test Request test Compare: https://github.com/openSUSE/open-build-service/compare/6c98163c2123...339d6e...