[obs-commits] [openSUSE/open-build-service] 475816: [frontend] Fix crash when configuring exchange opt...
Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 475816cc84b79bce95ad9a1e557ae3303bb2d8c0 https://github.com/openSUSE/open-build-service/commit/475816cc84b79bce95ad9a... Author: Björn Geuken <bgeuken@suse.de> Date: 2017-10-17 (Tue, 17 Oct 2017) Changed paths: M src/api/lib/rabbitmq_bus.rb Log Message: ----------- [frontend] Fix crash when configuring exchange options for RabbitMQ Bunny, the library we use for using rabbitmq, only accepts hash keys that are symbols. Any key that is not a symbol doesn't get applied by bunny. OBS was using with_indifferent_access for any hash passed to bunny to ensure that the bunny recognizes the hash as 'symbolized'. However with_indifferent_access creates and returns an ActiveSupport::HashWithIndifferentAccess instance, which isn't something bunny knows how to deal with. Therefore it still failed to apply the options. The solution is to use the symbolize_keys method to ensure that all hash keys are symbols, before passing them to bunny. Kudos goes to @coolo for debugging this. Commit: b74a8ac7254cea1167e34b8376be37f2b29b75b1 https://github.com/openSUSE/open-build-service/commit/b74a8ac7254cea1167e34b... Author: Moisés Déniz Alemán <mdeniz@suse.com> Date: 2017-10-17 (Tue, 17 Oct 2017) Changed paths: M src/api/lib/rabbitmq_bus.rb Log Message: ----------- Merge pull request #4025 from bgeuken/rabbitmq_fix [frontend] Fix crash when configuring exchange options for RabbitMQ Compare: https://github.com/openSUSE/open-build-service/compare/ffee0b151e6b...b74a8a...
participants (1)
-
Moisés Déniz Alemán