[obs-commits] [openSUSE/open-build-service] 73fdee: [dist] Use multiple arguments in our Rakefile
Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 73fdee2ad19ac3f9258c714866018f11331a8483 https://github.com/openSUSE/open-build-service/commit/73fdee2ad19ac3f9258c71... Author: Björn Geuken <bgeuken@suse.de> Date: 2018-06-01 (Fri, 01 Jun 2018) Changed paths: M Rakefile Log Message: ----------- [dist] Use multiple arguments in our Rakefile This prevents us from interpolating user input. Our rakefile is passing certain environment variables to the docker-compose command. Since we were not escaping these parameters it was possible to manipulate or break the command, eg. by having a ' character in a commit message. Found due to a failure in travis: rake docker:test:lint ... sh: 7: Syntax error: Unterminated quoted string Commit: f5240ba0cb39cd8ea321ebe18502a338c1da78d8 https://github.com/openSUSE/open-build-service/commit/f5240ba0cb39cd8ea321eb... Author: Ana María Martínez Gómez <ammartinez@suse.de> Date: 2018-06-01 (Fri, 01 Jun 2018) Changed paths: M Rakefile Log Message: ----------- Merge pull request #5064 from bgeuken/fix_escaping_in_rakefile Use multiple arguments in our Rakefile Compare: https://github.com/openSUSE/open-build-service/compare/27ddd392ff3e...f5240b... **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.
participants (1)
-
Ana María Martínez Gómez