Branch: refs/heads/master Home: https://github.com/openSUSE/osc Commit: acbd2c17c7649c825f3afb6593aec8df1e77c6ca https://github.com/openSUSE/osc/commit/acbd2c17c7649c825f3afb6593aec8df1e77c... Author: Marcus Huewe Date: 2016-06-02 (Thu, 02 Jun 2016) Changed paths: M osc/core.py Log Message: ----------- Revert "Simplify core.http_request" This reverts commit c53a7681ef289181b03e1077efbfd246bf1247f6 (for now!). It seems to break local obs instances (see issue #202) (this needs further debugging). Moreover, it breaks the python 3.4 - excerpt from a travis run: ====================================================================== ERROR: test_added_missing2 (test_commit.TestCommit) ---------------------------------------------------------------------- Traceback (most recent call last): File "/opt/python/3.4.2/lib/python3.4/urllib/request.py", line 1111, in do_request_ mv = memoryview(data) TypeError: memoryview: _io.BufferedReader object does not have the buffer interface During handling of the above exception, another exception occurred: Traceback (most recent call last): File "/home/travis/build/openSUSE/osc/tests/common.py", line 122, in wrapped_test_method test_method(*args) File "/home/travis/build/openSUSE/osc/tests/common.py", line 122, in wrapped_test_method test_method(*args) File "/home/travis/build/openSUSE/osc/tests/common.py", line 122, in wrapped_test_method test_method(*args) File "/home/travis/build/openSUSE/osc/tests/common.py", line 122, in wrapped_test_method test_method(*args) File "/home/travis/build/openSUSE/osc/tests/common.py", line 122, in wrapped_test_method test_method(*args) File "/home/travis/build/openSUSE/osc/tests/test_commit.py", line 290, in test_added_missing2 p.commit() File "/home/travis/build/openSUSE/osc/tests/osc/core.py", line 1471, in commit self.put_source_file(filename, tdir) File "/home/travis/build/openSUSE/osc/tests/osc/core.py", line 1319, in put_source_file http_PUT(u, file = tfilename) File "/home/travis/build/openSUSE/osc/tests/osc/core.py", line 3243, in http_PUT def http_PUT(*args, **kwargs): return http_request('PUT', *args, **kwargs) File "/home/travis/build/openSUSE/osc/tests/osc/core.py", line 3231, in http_request fd = urlopen(req, data=data) File "/opt/python/3.4.2/lib/python3.4/urllib/request.py", line 153, in urlopen return opener.open(url, data, timeout) File "/opt/python/3.4.2/lib/python3.4/urllib/request.py", line 453, in open req = meth(req) File "/opt/python/3.4.2/lib/python3.4/urllib/request.py", line 1116, in do_request_ data)) ValueError: Content-Length should be specified for iterable data of type <_io.BufferedReader name='/tmp/osc_test571whun4/osctest/added_missing/.osc/_in_commit/bar'>