Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 4fa71c6328452d5c0e7cfaa610a8dea356312201 https://github.com/openSUSE/open-build-service/commit/4fa71c6328452d5c0e7cfa... Author: Christian Bruckmayer <cbruckmayer@suse.com> Date: 2018-07-03 (Tue, 03 Jul 2018) Changed paths: M src/api/app/models/bs_request_action_delete.rb A src/api/spec/cassettes/BsRequestActionDelete/_sourcediff/for_package/1_1_2_1.yml A src/api/spec/cassettes/BsRequestActionDelete/_sourcediff/for_project/1_1_1_1.yml A src/api/spec/cassettes/BsRequestActionDelete/_sourcediff/for_repository/1_1_3_1.yml M src/api/spec/factories/bs_requests.rb A src/api/spec/models/bs_request_action_delete_spec.rb Log Message: ----------- [webui][api] Fix delete request diff for packages The if statements were completely messed up. This got introduced by a refactoring in 214ba835ddcb6fc02a216dd3108c27c1ad12f724. The DiffError should only raise if there is no package and no repository (messed with the unless). Also the guard clause should only return and empty string if there is no target_package. In case there is package, we can do a normal diff. Fix #5107 Commit: 147572cbb916d28e76a68a82c281856f1075ed18 https://github.com/openSUSE/open-build-service/commit/147572cbb916d28e76a68a... Author: Christian Bruckmayer <cbruckmayer@suse.com> Date: 2018-07-03 (Tue, 03 Jul 2018) Changed paths: M src/api/app/models/bs_request_action_delete.rb A src/api/spec/cassettes/BsRequestActionDelete/_sourcediff/for_package/1_1_2_1.yml A src/api/spec/cassettes/BsRequestActionDelete/_sourcediff/for_project/1_1_1_1.yml A src/api/spec/cassettes/BsRequestActionDelete/_sourcediff/for_repository/1_1_3_1.yml M src/api/spec/factories/bs_requests.rb A src/api/spec/models/bs_request_action_delete_spec.rb Log Message: ----------- Merge pull request #5274 from ChrisBr/bug/delete_request [webui][api] Fix delete request diff for packages Compare: https://github.com/openSUSE/open-build-service/compare/2185da93954e...147572... **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.