Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: f5f4f66da9f8231cd8206b72a5a52a9ac9605dbd https://github.com/openSUSE/open-build-service/commit/f5f4f66da9f8231cd8206b... Author: Saray Cabrera Padrón <scabrerapadron@suse.de> Date: 2024-09-11 (Wed, 11 Sep 2024) Changed paths: M src/api/app/models/notification_report.rb Log Message: ----------- Drop NotificationReport#description for Event::ReportForUser The definition of the `description` is moved to the component, so we no longer need it in the model. In fact, the case contained the two conditions "case 'Event::ReportForUser'" by mistake. The first one was already removed and the second one is removed now. Commit: 8c55201b74f06ce0f785128d884d336c80f98142 https://github.com/openSUSE/open-build-service/commit/8c55201b74f06ce0f78512... Author: Saray Cabrera Padrón <scabrerapadron@suse.de> Date: 2024-09-11 (Wed, 11 Sep 2024) Changed paths: R src/api/app/components/notification_component.html.haml R src/api/app/components/notification_component.rb M src/api/app/helpers/webui/notification_helper.rb A src/api/app/views/webui/users/notifications/_notification.html.haml M src/api/app/views/webui/users/notifications/_notifications_list.html.haml Log Message: ----------- Get rid of NotificationComponent That component contained the whole notifications view and it wasn't reusable. So it made little sense to keep it as a component. The code is moved to partials and helpers. Commit: 6eb4f4384848fc4ce9c5f7e8bb6e2a809c1d8699 https://github.com/openSUSE/open-build-service/commit/6eb4f4384848fc4ce9c5f7... Author: Saray Cabrera Padrón <scabrerapadron@suse.de> Date: 2024-09-11 (Wed, 11 Sep 2024) Changed paths: R src/api/spec/components/notification_component_spec.rb M src/api/spec/features/webui/users/notifications_spec.rb Log Message: ----------- Move component spec to feature spec Commit: 7e5c6914119418ff632377a744b258dc2d0a5c19 https://github.com/openSUSE/open-build-service/commit/7e5c6914119418ff632377... Author: Saray Cabrera Padrón <scabrerapadron@suse.de> Date: 2024-09-11 (Wed, 11 Sep 2024) Changed paths: M src/api/spec/helpers/webui/notification_helper_spec.rb Log Message: ----------- Add Notification helper specs Commit: d3c09a091baa69de0cecd3c46e0f865b37460e31 https://github.com/openSUSE/open-build-service/commit/d3c09a091baa69de0cecd3... Author: Saray Cabrera Padrón <scabrerapadron@suse.de> Date: 2024-09-11 (Wed, 11 Sep 2024) Changed paths: M src/api/.rubocop_todo.yml Log Message: ----------- Update Rubocop TODO Commit: d475a74d32f64c0ffce93878cb086f00b6f9d06f https://github.com/openSUSE/open-build-service/commit/d475a74d32f64c0ffce938... Author: Saray Cabrera Padrón <scabrerapadron@suse.com> Date: 2024-09-12 (Thu, 12 Sep 2024) Changed paths: M src/api/.rubocop_todo.yml R src/api/app/components/notification_component.html.haml R src/api/app/components/notification_component.rb M src/api/app/helpers/webui/notification_helper.rb M src/api/app/models/notification_report.rb A src/api/app/views/webui/users/notifications/_notification.html.haml M src/api/app/views/webui/users/notifications/_notifications_list.html.haml R src/api/spec/components/notification_component_spec.rb M src/api/spec/features/webui/users/notifications_spec.rb M src/api/spec/helpers/webui/notification_helper_spec.rb Log Message: ----------- Merge pull request #16471 from saraycp/remove_notification_component Remove notification component Compare: https://github.com/openSUSE/open-build-service/compare/6a3a4fc4a50e...d475a7... To unsubscribe from these emails, change your notification settings at https://github.com/openSUSE/open-build-service/settings/notifications