Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 7071b3cd5834506b547d9658cddab8ee7ded04e2 https://github.com/openSUSE/open-build-service/commit/7071b3cd5834506b547d96... Author: Björn Geuken <bgeuken@suse.de> Date: 2019-01-31 (Thu, 31 Jan 2019) Changed paths: M src/api/app/assets/stylesheets/webui/application/request.scss M src/api/app/controllers/webui/request_controller.rb M src/api/app/helpers/webui/request_helper.rb M src/api/app/views/webui/request/show.html.erb M src/api/spec/controllers/webui/request_controller_spec.rb M src/api/spec/features/webui/requests_spec.rb Log Message: ----------- Partially re-write modify_review action * Remove index from parameters. This action always processes one review at a time. There was no need to add an index to the parameters. * Move setting of hidden field tags to a helper to dry the code. * Directly access parameters we need instead of looping over all of them. * Drop code for setting review state 'new'. That was not possible via the UI anyway. Commit: 16e718c76aecf6b51ca87704e6a9aaa04d2dfa1e https://github.com/openSUSE/open-build-service/commit/16e718c76aecf6b51ca877... Author: Victor Pereira <vpereirabr@gmail.com> Date: 2019-02-01 (Fri, 01 Feb 2019) Changed paths: M src/api/app/assets/stylesheets/webui/application/request.scss M src/api/app/controllers/webui/request_controller.rb M src/api/app/helpers/webui/request_helper.rb M src/api/app/views/webui/request/show.html.erb M src/api/spec/controllers/webui/request_controller_spec.rb M src/api/spec/features/webui/requests_spec.rb Log Message: ----------- Merge pull request #6874 from bgeuken/update_modify_review_action Partially re-write modify_review action Compare: https://github.com/openSUSE/open-build-service/compare/a895e359aa74...16e718...