[obs-commits] [openSUSE/open-build-service] 1ed16c: [ci] Don't reseed the database on every test start
Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 1ed16c9c34f280dcf1ea631e6ff94f3c203d9591 https://github.com/openSUSE/open-build-service/commit/1ed16c9c34f280dcf1ea63... Author: Stephan Kulow <coolo@suse.de> Date: 2018-07-21 (Sat, 21 Jul 2018) Changed paths: M src/api/spec/support/database_cleaner.rb Log Message: ----------- [ci] Don't reseed the database on every test start As followup on #5327 - reseeding the database on every test run is super conservative and steals a lot of developer time for the sake of being safe on very rare test crashes Truncating the static tables is good enough for normal test crashes. The model tests run in transactions, so don't interfere with the database - but are the ones most likely to break. And in case the database is busted, recreating it is just as fast/slow as what we basically did before every test run. The reseeding takes on my system ~10 seconds - and according to dmarcoux's comment in 5327 on his it's a minute. So drop it Commit: d5f869090626b843951051263c7ccbb4725be087 https://github.com/openSUSE/open-build-service/commit/d5f869090626b843951051... Author: Henne Vogelsang <hvogel@opensuse.org> Date: 2018-07-22 (Sun, 22 Jul 2018) Changed paths: M src/api/spec/support/database_cleaner.rb Log Message: ----------- Merge pull request #5434 from coolo/dont_reseed [ci] Don't reseed the database on every test start Compare: https://github.com/openSUSE/open-build-service/compare/48c0340ef8cb...d5f869... **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.
participants (1)
-
Henne Vogelsang