Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: edc93d80e3630aaf9d16658365a7bc3a9f65ec2d https://github.com/openSUSE/open-build-service/commit/edc93d80e3630aaf9d1665... Author: Björn Geuken Date: 2017-10-09 (Mon, 09 Oct 2017) Changed paths: M src/api/app/controllers/webui/request_controller.rb Log Message: ----------- [api] Remove duplicated code from request controller There already is a before_action that makes sure a bs_request was found. The code is of the before_action is even identical to the dropped code. Commit: 802f2c903da811d708b1a8fa32cc1324f7f056ba https://github.com/openSUSE/open-build-service/commit/802f2c903da811d708b1a8... Author: Björn Geuken Date: 2017-10-09 (Mon, 09 Oct 2017) Changed paths: M src/api/app/controllers/webui/request_controller.rb M src/api/app/views/webui/request/_recent_events_table.html.erb M src/api/app/views/webui/request/show.html.erb M src/api/spec/controllers/webui/request_controller_spec.rb Log Message: ----------- [api] Rename variable: @bsreq -> @bs_request Commit: cac9d208a6096d099cfb417375db06f069cef1cd https://github.com/openSUSE/open-build-service/commit/cac9d208a6096d099cfb41... Author: Björn Geuken Date: 2017-10-09 (Mon, 09 Oct 2017) Changed paths: M src/api/app/controllers/webui/request_controller.rb Log Message: ----------- [api] Re-use before_action to DRY code With this commit we will use the existing require_request before_action and remove the code that took care of this before from the show action. Commit: 1861973c26b0f9a2c78eb9ba6705c691d06b4ec0 https://github.com/openSUSE/open-build-service/commit/1861973c26b0f9a2c78eb9... Author: Björn Geuken Date: 2017-10-09 (Mon, 09 Oct 2017) Changed paths: M src/api/app/controllers/webui/request_controller.rb Log Message: ----------- [webui] Make before_action private Commit: beed676906d7fabb994f681315400ad0aafd6e5d https://github.com/openSUSE/open-build-service/commit/beed676906d7fabb994f68... Author: David Kang Date: 2017-10-09 (Mon, 09 Oct 2017) Changed paths: M src/api/app/controllers/webui/request_controller.rb M src/api/app/views/webui/request/_recent_events_table.html.erb M src/api/app/views/webui/request/show.html.erb M src/api/spec/controllers/webui/request_controller_spec.rb Log Message: ----------- Merge pull request #3963 from bgeuken/refactor_request_controller Refactor request controller Compare: https://github.com/openSUSE/open-build-service/compare/57e69b01c20c...beed67...