Branch: refs/heads/master
Home: https://github.com/openSUSE/open-build-service
Commit: 8f5a76c0c65d9718f596aa394b041e3158c2a506
https://github.com/openSUSE/open-build-service/commit/8f5a76c0c65d9718f596aa...
Author: Lukas Krause
Date: 2021-09-10 (Fri, 10 Sep 2021)
Changed paths:
A src/api/app/controllers/concerns/triggerable.rb
M src/api/app/controllers/trigger_controller.rb
Log Message:
-----------
Move token preperation logic to a concern
The methods to authorize and set the package/project
from a token is also required in the webui controller.
Therefore moving it to a concern in order to reuse them.
Commit: 0eb73e566e20cbb2944e2f255b9c5be983d843b6
https://github.com/openSUSE/open-build-service/commit/0eb73e566e20cbb2944e2f...
Author: Lukas Krause
Date: 2021-09-10 (Fri, 10 Sep 2021)
Changed paths:
M src/api/app/assets/javascripts/webui/autocomplete.js
A src/api/app/controllers/webui/users/token_triggers_controller.rb
M src/api/app/policies/token_policy.rb
A src/api/app/views/webui/users/token_triggers/_breadcrumb_items.html.haml
A src/api/app/views/webui/users/token_triggers/show.html.haml
M src/api/app/views/webui/users/tokens/index.html.haml
M src/api/config/routes/webui_routes.rb
Log Message:
-----------
Trigger tokens through webui
* Add controller and views to trigger tokens through the webui
* Adapt autocomplete javascript to support `:package` and `:project`
param names
* Add corresponding policies
Commit: 9b958b3ed9d67730108d5715c55f70676e2662e4
https://github.com/openSUSE/open-build-service/commit/9b958b3ed9d67730108d57...
Author: Lukas Krause
Date: 2021-09-10 (Fri, 10 Sep 2021)
Changed paths:
A src/api/spec/cassettes/Webui_Users_TokenTriggersController/PUT_update/rebuild_token/when_token_is_valid_and_associated_package_exist/flashes_success_and_redirects_to_token_path.yml
A src/api/spec/cassettes/Webui_Users_TokenTriggersController/PUT_update/rebuild_token/when_token_is_valid_and_package/project_provided_exist/flashes_success_and_redirects_to_token_path.yml
A src/api/spec/cassettes/Webui_Users_TokenTriggersController/PUT_update/release_token/when_there_are_no_release_targets/flashes_an_error.yml
A src/api/spec/cassettes/Webui_Users_TokenTriggersController/PUT_update/release_token/when_token_is_valid_and_associated_package_exist/flashes_success_and_redirects_to_token_path.yml
A src/api/spec/cassettes/Webui_Users_TokenTriggersController/PUT_update/release_token/when_user_has_no_rights_for_source/flashes_an_error.yml
A src/api/spec/cassettes/Webui_Users_TokenTriggersController/PUT_update/release_token/when_user_has_no_rights_for_target/flashes_an_error.yml
A src/api/spec/cassettes/Webui_Users_TokenTriggersController/PUT_update/service_token/when_package_does_not_provide_a_service/flashes_an_error.yml
A src/api/spec/cassettes/Webui_Users_TokenTriggersController/PUT_update/service_token/when_package_provides_a_service/flashes_success_and_redirects_to_token_path.yml
A src/api/spec/cassettes/Webui_Users_TokenTriggersController/PUT_update/when_package_or_project_params_are_not_provided/flashes_error_when_package_param_is_missing.yml
A src/api/spec/cassettes/Webui_Users_TokenTriggersController/PUT_update/when_package_or_project_params_are_not_provided/flashes_error_when_project_param_is_missing.yml
A src/api/spec/controllers/webui/users/token_triggers_controller_spec.rb
Log Message:
-----------
Add controller spec for trigger tokens webui
Commit: bc130438edcecbd896957afacf607d3a7765ca6b
https://github.com/openSUSE/open-build-service/commit/bc130438edcecbd896957a...
Author: Lukas Krause
Date: 2021-09-10 (Fri, 10 Sep 2021)
Changed paths:
A src/api/spec/policies/token_policy_spec.rb
Log Message:
-----------
Add token policy spec for webui_trigger and show
Commit: c05b6827339cabf8043d2166e9d0482a3b7be289
https://github.com/openSUSE/open-build-service/commit/c05b6827339cabf8043d21...
Author: Lukas Krause
Date: 2021-09-10 (Fri, 10 Sep 2021)
Changed paths:
M src/api/app/controllers/concerns/triggerable.rb
A src/api/spec/controllers/concerns/triggerable_spec.rb
M src/api/spec/controllers/trigger_controller_spec.rb
Log Message:
-----------
Test triggerable concern isolated
Commit: 1aa38e356108c22de7364abbe3e46783c1809ac5
https://github.com/openSUSE/open-build-service/commit/1aa38e356108c22de7364a...
Author: Lukas Krause
Date: 2021-09-10 (Fri, 10 Sep 2021)
Changed paths:
M src/api/spec/cassettes/TriggerController/_create/with_HTTP_X-Pagure-Signature-256_http_header/behaves_like_it_verifies_the_signature/when_signature_is_valid/1_4_3_1_1_1.yml
A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X-Pagure-Signature-256_http_header/behaves_like_it_verifies_the_signature/when_signature_is_valid/1_5_3_1_1_1.yml
M src/api/spec/cassettes/TriggerController/_create/with_HTTP_X-Pagure-Signature-256_http_header/behaves_like_it_verifies_the_signature/when_token_is_invalid/renders_an_error_with_an_invalid_signature.yml
M src/api/spec/cassettes/TriggerController/_create/with_HTTP_X-Pagure-Signature-256_http_header/behaves_like_it_verifies_the_signature/when_token_is_invalid/renders_an_error_with_an_invalid_token.yml
M src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_HUB_SIGNATURE_256_http_header/behaves_like_it_verifies_the_signature/when_signature_is_valid/1_4_2_1_1_1.yml
A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_HUB_SIGNATURE_256_http_header/behaves_like_it_verifies_the_signature/when_signature_is_valid/1_5_2_1_1_1.yml
M src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_HUB_SIGNATURE_256_http_header/behaves_like_it_verifies_the_signature/when_token_is_invalid/renders_an_error_with_an_invalid_signature.yml
M src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_HUB_SIGNATURE_256_http_header/behaves_like_it_verifies_the_signature/when_token_is_invalid/renders_an_error_with_an_invalid_token.yml
M src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_OBS_SIGNATURE_http_header/behaves_like_it_verifies_the_signature/when_signature_is_valid/1_4_1_1_1_1.yml
A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_OBS_SIGNATURE_http_header/behaves_like_it_verifies_the_signature/when_signature_is_valid/1_5_1_1_1_1.yml
M src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_OBS_SIGNATURE_http_header/behaves_like_it_verifies_the_signature/when_token_is_invalid/renders_an_error_with_an_invalid_signature.yml
M src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_OBS_SIGNATURE_http_header/behaves_like_it_verifies_the_signature/when_token_is_invalid/renders_an_error_with_an_invalid_token.yml
R src/api/spec/cassettes/TriggerController/_rebuild/authentication_token_is_invalid/1_1_1_1.yml
A src/api/spec/cassettes/TriggerController/_rebuild/authentication_token_is_invalid/1_2_1_1.yml
R src/api/spec/cassettes/TriggerController/_rebuild/when_token_is_valid/1_1_2_1.yml
A src/api/spec/cassettes/TriggerController/_rebuild/when_token_is_valid/1_2_2_1.yml
R src/api/spec/cassettes/TriggerController/_release/for_inexistent_project/1_2_1_1.yml
A src/api/spec/cassettes/TriggerController/_release/for_inexistent_project/1_3_1_1.yml
R src/api/spec/cassettes/TriggerController/_release/when_there_are_no_release_targets/1_2_5_1.yml
A src/api/spec/cassettes/TriggerController/_release/when_there_are_no_release_targets/1_3_5_1.yml
M src/api/spec/cassettes/TriggerController/_release/when_token_is_valid_and_package_exists/1_2_2_1.yml
A src/api/spec/cassettes/TriggerController/_release/when_token_is_valid_and_package_exists/1_3_2_1.yml
R src/api/spec/cassettes/TriggerController/_release/when_user_has_no_rights_for_source/1_2_3_1.yml
A src/api/spec/cassettes/TriggerController/_release/when_user_has_no_rights_for_source/1_3_3_1.yml
R src/api/spec/cassettes/TriggerController/_release/when_user_has_no_rights_for_target/1_2_4_1.yml
R src/api/spec/cassettes/TriggerController/_release/when_user_has_no_rights_for_target/1_2_4_2.yml
A src/api/spec/cassettes/TriggerController/_release/when_user_has_no_rights_for_target/1_3_4_1.yml
A src/api/spec/cassettes/TriggerController/_release/when_user_has_no_rights_for_target/1_3_4_2.yml
M src/api/spec/cassettes/TriggerController/_runservice/1_3_1.yml
A src/api/spec/cassettes/TriggerController/_runservice/1_4_1.yml
R src/api/spec/cassettes/TriggerController/_set_multibuild_flavor/with_a_token_that_allows_multibuild/assigns_flavor_name.yml
R src/api/spec/cassettes/TriggerController/_set_multibuild_flavor/with_a_token_that_allows_multibuild/authorizes_package_object.yml
R src/api/spec/cassettes/TriggerController/_set_multibuild_flavor/with_a_token_that_does_not_allow_multibuild/raises_not_found.yml
R src/api/spec/cassettes/TriggerController/_set_object_to_authorize/assigns_associated_package.yml
R src/api/spec/cassettes/TriggerController/_set_object_to_authorize/project_with_project-link/authorizes_the_package_if_the_package_is_local.yml
R src/api/spec/cassettes/TriggerController/_set_object_to_authorize/project_with_project-link/authorizes_the_project_if_the_package_is_from_a_project_with_a_link.yml
R src/api/spec/cassettes/TriggerController/_set_object_to_authorize/project_with_remote_project-link/authorizes_the_package_if_the_package_is_local.yml
R src/api/spec/cassettes/TriggerController/_set_object_to_authorize/project_with_remote_project-link/authorizes_the_project_if_the_package_is_from_a_project_with_a_link.yml
R src/api/spec/cassettes/TriggerController/_set_package/project_with_project-link_and_token_that_follows_project-links/assigns_linked_package.yml
R src/api/spec/cassettes/TriggerController/_set_package/project_with_project-link_and_token_that_follows_project-links/raises_when_package_does_not_exist_in_link.yml
R src/api/spec/cassettes/TriggerController/_set_package/project_with_remote_project-link/assigns_remote_package_string.yml
R src/api/spec/cassettes/TriggerController/_set_package/raises_when_package_does_not_exist.yml
R src/api/spec/cassettes/TriggerController/_set_project/raises_a_not_found_for_a_remote_project.yml
Log Message:
-----------
Update trigger controller spec vcr cassettes
Commit: c726c88baaa0c27b30e2153c4425d7c8beb28d37
https://github.com/openSUSE/open-build-service/commit/c726c88baaa0c27b30e215...
Author: Lukas Krause
Date: 2021-09-10 (Fri, 10 Sep 2021)
Changed paths:
M src/api/app/assets/javascripts/webui/autocomplete.js
A src/api/app/controllers/concerns/triggerable.rb
M src/api/app/controllers/trigger_controller.rb
A src/api/app/controllers/webui/users/token_triggers_controller.rb
M src/api/app/policies/token_policy.rb
A src/api/app/views/webui/users/token_triggers/_breadcrumb_items.html.haml
A src/api/app/views/webui/users/token_triggers/show.html.haml
M src/api/app/views/webui/users/tokens/index.html.haml
M src/api/config/routes/webui_routes.rb
M src/api/spec/cassettes/TriggerController/_create/with_HTTP_X-Pagure-Signature-256_http_header/behaves_like_it_verifies_the_signature/when_signature_is_valid/1_4_3_1_1_1.yml
A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X-Pagure-Signature-256_http_header/behaves_like_it_verifies_the_signature/when_signature_is_valid/1_5_3_1_1_1.yml
M src/api/spec/cassettes/TriggerController/_create/with_HTTP_X-Pagure-Signature-256_http_header/behaves_like_it_verifies_the_signature/when_token_is_invalid/renders_an_error_with_an_invalid_signature.yml
M src/api/spec/cassettes/TriggerController/_create/with_HTTP_X-Pagure-Signature-256_http_header/behaves_like_it_verifies_the_signature/when_token_is_invalid/renders_an_error_with_an_invalid_token.yml
M src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_HUB_SIGNATURE_256_http_header/behaves_like_it_verifies_the_signature/when_signature_is_valid/1_4_2_1_1_1.yml
A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_HUB_SIGNATURE_256_http_header/behaves_like_it_verifies_the_signature/when_signature_is_valid/1_5_2_1_1_1.yml
M src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_HUB_SIGNATURE_256_http_header/behaves_like_it_verifies_the_signature/when_token_is_invalid/renders_an_error_with_an_invalid_signature.yml
M src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_HUB_SIGNATURE_256_http_header/behaves_like_it_verifies_the_signature/when_token_is_invalid/renders_an_error_with_an_invalid_token.yml
M src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_OBS_SIGNATURE_http_header/behaves_like_it_verifies_the_signature/when_signature_is_valid/1_4_1_1_1_1.yml
A src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_OBS_SIGNATURE_http_header/behaves_like_it_verifies_the_signature/when_signature_is_valid/1_5_1_1_1_1.yml
M src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_OBS_SIGNATURE_http_header/behaves_like_it_verifies_the_signature/when_token_is_invalid/renders_an_error_with_an_invalid_signature.yml
M src/api/spec/cassettes/TriggerController/_create/with_HTTP_X_OBS_SIGNATURE_http_header/behaves_like_it_verifies_the_signature/when_token_is_invalid/renders_an_error_with_an_invalid_token.yml
R src/api/spec/cassettes/TriggerController/_rebuild/authentication_token_is_invalid/1_1_1_1.yml
A src/api/spec/cassettes/TriggerController/_rebuild/authentication_token_is_invalid/1_2_1_1.yml
R src/api/spec/cassettes/TriggerController/_rebuild/when_token_is_valid/1_1_2_1.yml
A src/api/spec/cassettes/TriggerController/_rebuild/when_token_is_valid/1_2_2_1.yml
R src/api/spec/cassettes/TriggerController/_release/for_inexistent_project/1_2_1_1.yml
A src/api/spec/cassettes/TriggerController/_release/for_inexistent_project/1_3_1_1.yml
R src/api/spec/cassettes/TriggerController/_release/when_there_are_no_release_targets/1_2_5_1.yml
A src/api/spec/cassettes/TriggerController/_release/when_there_are_no_release_targets/1_3_5_1.yml
M src/api/spec/cassettes/TriggerController/_release/when_token_is_valid_and_package_exists/1_2_2_1.yml
A src/api/spec/cassettes/TriggerController/_release/when_token_is_valid_and_package_exists/1_3_2_1.yml
R src/api/spec/cassettes/TriggerController/_release/when_user_has_no_rights_for_source/1_2_3_1.yml
A src/api/spec/cassettes/TriggerController/_release/when_user_has_no_rights_for_source/1_3_3_1.yml
R src/api/spec/cassettes/TriggerController/_release/when_user_has_no_rights_for_target/1_2_4_1.yml
R src/api/spec/cassettes/TriggerController/_release/when_user_has_no_rights_for_target/1_2_4_2.yml
A src/api/spec/cassettes/TriggerController/_release/when_user_has_no_rights_for_target/1_3_4_1.yml
A src/api/spec/cassettes/TriggerController/_release/when_user_has_no_rights_for_target/1_3_4_2.yml
M src/api/spec/cassettes/TriggerController/_runservice/1_3_1.yml
A src/api/spec/cassettes/TriggerController/_runservice/1_4_1.yml
R src/api/spec/cassettes/TriggerController/_set_multibuild_flavor/with_a_token_that_allows_multibuild/assigns_flavor_name.yml
R src/api/spec/cassettes/TriggerController/_set_multibuild_flavor/with_a_token_that_allows_multibuild/authorizes_package_object.yml
R src/api/spec/cassettes/TriggerController/_set_multibuild_flavor/with_a_token_that_does_not_allow_multibuild/raises_not_found.yml
R src/api/spec/cassettes/TriggerController/_set_object_to_authorize/assigns_associated_package.yml
R src/api/spec/cassettes/TriggerController/_set_object_to_authorize/project_with_project-link/authorizes_the_package_if_the_package_is_local.yml
R src/api/spec/cassettes/TriggerController/_set_object_to_authorize/project_with_project-link/authorizes_the_project_if_the_package_is_from_a_project_with_a_link.yml
R src/api/spec/cassettes/TriggerController/_set_object_to_authorize/project_with_remote_project-link/authorizes_the_package_if_the_package_is_local.yml
R src/api/spec/cassettes/TriggerController/_set_object_to_authorize/project_with_remote_project-link/authorizes_the_project_if_the_package_is_from_a_project_with_a_link.yml
R src/api/spec/cassettes/TriggerController/_set_package/project_with_project-link_and_token_that_follows_project-links/assigns_linked_package.yml
R src/api/spec/cassettes/TriggerController/_set_package/project_with_project-link_and_token_that_follows_project-links/raises_when_package_does_not_exist_in_link.yml
R src/api/spec/cassettes/TriggerController/_set_package/project_with_remote_project-link/assigns_remote_package_string.yml
R src/api/spec/cassettes/TriggerController/_set_package/raises_when_package_does_not_exist.yml
R src/api/spec/cassettes/TriggerController/_set_project/raises_a_not_found_for_a_remote_project.yml
A src/api/spec/cassettes/Webui_Users_TokenTriggersController/PUT_update/rebuild_token/when_token_is_valid_and_associated_package_exist/flashes_success_and_redirects_to_token_path.yml
A src/api/spec/cassettes/Webui_Users_TokenTriggersController/PUT_update/rebuild_token/when_token_is_valid_and_package/project_provided_exist/flashes_success_and_redirects_to_token_path.yml
A src/api/spec/cassettes/Webui_Users_TokenTriggersController/PUT_update/release_token/when_there_are_no_release_targets/flashes_an_error.yml
A src/api/spec/cassettes/Webui_Users_TokenTriggersController/PUT_update/release_token/when_token_is_valid_and_associated_package_exist/flashes_success_and_redirects_to_token_path.yml
A src/api/spec/cassettes/Webui_Users_TokenTriggersController/PUT_update/release_token/when_user_has_no_rights_for_source/flashes_an_error.yml
A src/api/spec/cassettes/Webui_Users_TokenTriggersController/PUT_update/release_token/when_user_has_no_rights_for_target/flashes_an_error.yml
A src/api/spec/cassettes/Webui_Users_TokenTriggersController/PUT_update/service_token/when_package_does_not_provide_a_service/flashes_an_error.yml
A src/api/spec/cassettes/Webui_Users_TokenTriggersController/PUT_update/service_token/when_package_provides_a_service/flashes_success_and_redirects_to_token_path.yml
A src/api/spec/cassettes/Webui_Users_TokenTriggersController/PUT_update/when_package_or_project_params_are_not_provided/flashes_error_when_package_param_is_missing.yml
A src/api/spec/cassettes/Webui_Users_TokenTriggersController/PUT_update/when_package_or_project_params_are_not_provided/flashes_error_when_project_param_is_missing.yml
A src/api/spec/controllers/concerns/triggerable_spec.rb
M src/api/spec/controllers/trigger_controller_spec.rb
A src/api/spec/controllers/webui/users/token_triggers_controller_spec.rb
A src/api/spec/policies/token_policy_spec.rb
Log Message:
-----------
Merge pull request #11448 from krauselukas/feature/token_ui_trigger
Trigger token through the webui
Compare: https://github.com/openSUSE/open-build-service/compare/b72fc9589bdc...c726c8...
Lukas Krause