Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: db6eb3c34a4dcecc4f88b231f1946d62117ac1fb https://github.com/openSUSE/open-build-service/commit/db6eb3c34a4dcecc4f88b2... Author: Dani Donisa <dani.doni@gmail.com> Date: 2022-03-22 (Tue, 22 Mar 2022) Changed paths: M src/api/app/models/bs_request/errors.rb M src/api/app/models/bs_request_permission_check.rb M src/api/db/attribute_descriptions.rb A src/api/db/data/20220318123314_add_attribute_to_enforce_request_accepter_and_creator_to_be_a_different_person.rb M src/api/db/data_schema.rb M src/api/db/seeds.rb R src/api/spec/cassettes/BsRequest/_changestate/when_bs_request_is_staged/when_a_staged_bs_request_is_accepted/1_6_4_2_1.yml A src/api/spec/cassettes/BsRequest/_changestate/when_bs_request_is_staged/when_a_staged_bs_request_is_accepted/1_6_5_2_1.yml A src/api/spec/cassettes/BsRequest/_changestate/when_the_request_is_accepted/and_the_target_package_has_an_attribute_to_disallow_acceptance_by_the_creator/and_the_accepter_is_NOT_the_creator/accepts_the_request.yml A src/api/spec/cassettes/BsRequest/_changestate/when_the_request_is_accepted/and_the_target_package_has_an_attribute_to_disallow_acceptance_by_the_creator/and_the_accepter_is_the_creator/triggers_an_error.yml A src/api/spec/cassettes/BsRequest/_changestate/when_the_request_is_accepted/and_the_target_package_has_an_attribute_to_disallow_acceptance_by_the_creator/but_the_accepter_is_NOT_the_creator/accepts_the_request.yml A src/api/spec/cassettes/BsRequest/_changestate/when_the_request_is_accepted/and_the_target_project_has_an_attribute_to_disallow_acceptance_by_the_creator/and_the_accepter_is_NOT_the_creator/accepts_the_request.yml A src/api/spec/cassettes/BsRequest/_changestate/when_the_request_is_accepted/and_the_target_project_has_an_attribute_to_disallow_acceptance_by_the_creator/and_the_accepter_is_the_creator/triggers_an_error.yml A src/api/spec/cassettes/BsRequest/_changestate/when_the_request_is_accepted/and_the_target_project_has_an_attribute_to_disallow_acceptance_by_the_creator/but_the_accepter_is_NOT_the_creator/accepts_the_request.yml M src/api/spec/models/bs_request_spec.rb M src/api/spec/support/database_cleaner.rb Log Message: ----------- Approver cannot be the request creator In order to enforce two different reviewers, the approver cannot be the same person than the creator of a request, if the propper attribute is enabled at target project or target package. Commit: cf266a11b13c52dd863feb79b785d8c840e19edd https://github.com/openSUSE/open-build-service/commit/cf266a11b13c52dd863feb... Author: Dani Donisa <dani.doni@gmail.com> Date: 2022-03-22 (Tue, 22 Mar 2022) Changed paths: M src/api/app/models/bs_request/errors.rb M src/api/app/models/bs_request_permission_check.rb M src/api/db/attribute_descriptions.rb A src/api/db/data/20220318123314_add_attribute_to_enforce_request_accepter_and_creator_to_be_a_different_person.rb M src/api/db/data_schema.rb M src/api/db/seeds.rb R src/api/spec/cassettes/BsRequest/_changestate/when_bs_request_is_staged/when_a_staged_bs_request_is_accepted/1_6_4_2_1.yml A src/api/spec/cassettes/BsRequest/_changestate/when_bs_request_is_staged/when_a_staged_bs_request_is_accepted/1_6_5_2_1.yml A src/api/spec/cassettes/BsRequest/_changestate/when_the_request_is_accepted/and_the_target_package_has_an_attribute_to_disallow_acceptance_by_the_creator/and_the_accepter_is_NOT_the_creator/accepts_the_request.yml A src/api/spec/cassettes/BsRequest/_changestate/when_the_request_is_accepted/and_the_target_package_has_an_attribute_to_disallow_acceptance_by_the_creator/and_the_accepter_is_the_creator/triggers_an_error.yml A src/api/spec/cassettes/BsRequest/_changestate/when_the_request_is_accepted/and_the_target_package_has_an_attribute_to_disallow_acceptance_by_the_creator/but_the_accepter_is_NOT_the_creator/accepts_the_request.yml A src/api/spec/cassettes/BsRequest/_changestate/when_the_request_is_accepted/and_the_target_project_has_an_attribute_to_disallow_acceptance_by_the_creator/and_the_accepter_is_NOT_the_creator/accepts_the_request.yml A src/api/spec/cassettes/BsRequest/_changestate/when_the_request_is_accepted/and_the_target_project_has_an_attribute_to_disallow_acceptance_by_the_creator/and_the_accepter_is_the_creator/triggers_an_error.yml A src/api/spec/cassettes/BsRequest/_changestate/when_the_request_is_accepted/and_the_target_project_has_an_attribute_to_disallow_acceptance_by_the_creator/but_the_accepter_is_NOT_the_creator/accepts_the_request.yml M src/api/spec/models/bs_request_spec.rb M src/api/spec/support/database_cleaner.rb Log Message: ----------- Merge pull request #12330 from danidoni/enforce-request-accepter-and-creator-to-be-a-different-person Approver cannot be the request creator Compare: https://github.com/openSUSE/open-build-service/compare/11bd632e7341...cf266a...