[obs-commits] [openSUSE/open-build-service] 03e888: Add new notification channels and enable field
Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 03e888f223e8d5e3b8a445e306ba7cbc0f622c9a https://github.com/openSUSE/open-build-service/commit/03e888f223e8d5e3b8a445... Author: David Kang <dkang@suse.com> Date: 2020-04-24 (Fri, 24 Apr 2020) Changed paths: M src/api/app/models/event_subscription.rb A src/api/db/migrate/20200423160517_add_enabled_to_event_subscription.rb M src/api/db/structure.sql M src/api/spec/factories/event_subscriptions.rb M src/api/spec/models/event_subscription/find_for_event_spec.rb M src/api/spec/support/shared_contexts/a_user_and_subscriptions.rb M src/api/spec/support/shared_contexts/a_user_and_subscriptions_with_defaults.rb M src/api/spec/support/shared_examples/a_subscriptions_form_for_subscriber.rb M src/api/test/fixtures/event_subscriptions.yml M src/api/test/functional/maintenance_test.rb M src/api/test/models/event_test.rb Log Message: ----------- Add new notification channels and enable field We added two new channels,`rss` and 'web`, to make the notification settings more granular. We also added a new field called `enable` to know if the subscription is enabled. Commit: c705ed5e7266cc8405b3557cfda8d901784d54c0 https://github.com/openSUSE/open-build-service/commit/c705ed5e7266cc8405b355... Author: David Kang <dkang@suse.com> Date: 2020-04-24 (Fri, 24 Apr 2020) Changed paths: M src/api/app/models/event_subscription.rb A src/api/app/models/event_subscription/for_channel_form.rb A src/api/app/models/event_subscription/for_event_form.rb A src/api/app/models/event_subscription/for_role_form.rb R src/api/app/models/event_subscription/generate_hash_for_subscriber.rb A src/api/spec/models/event_subscription/for_event_form_spec.rb A src/api/spec/models/event_subscription/for_role_form_spec.rb R src/api/spec/models/event_subscription/generate_hash_for_subscriber_spec.rb Log Message: ----------- Use objects instead of hash Co-authored-by: Daniel Donisa <daniel.donisa@suse.com> Commit: fe76c923deca4968b1d91e21c39d21e0e7acbbaa https://github.com/openSUSE/open-build-service/commit/fe76c923deca4968b1d91e... Author: David Kang <dkang@suse.com> Date: 2020-04-24 (Fri, 24 Apr 2020) Changed paths: M src/api/app/models/event_subscription/form.rb Log Message: ----------- Adapt EventSubscription::Form#update! to handle multiple channels Commit: a3cf9c1cdf39fe148f25e880969434217c1ce0af https://github.com/openSUSE/open-build-service/commit/a3cf9c1cdf39fe148f25e8... Author: David Kang <dkang@suse.com> Date: 2020-04-24 (Fri, 24 Apr 2020) Changed paths: M src/api/app/controllers/webui/users/subscriptions_controller.rb M src/api/app/views/webui/subscriptions/_subscriptions_form.html.haml M src/api/spec/features/webui/notifications_spec.rb Log Message: ----------- Adapt notification configuration view to handle new channels We need to adapt the view to render different checkbox for the new channels. Each checkbox is a `EventSubscription` specific event_type, role and channel. Co-authored-by: Daniel Donisa <daniel.donisa@suse.com> Commit: cba7a27a3086119ae053f71cb96a4dd4231dce50 https://github.com/openSUSE/open-build-service/commit/cba7a27a3086119ae053f7... Author: Victor Pereira <vpereira@suse.de> Date: 2020-04-24 (Fri, 24 Apr 2020) Changed paths: M src/api/app/controllers/webui/users/subscriptions_controller.rb M src/api/app/models/event_subscription.rb A src/api/app/models/event_subscription/for_channel_form.rb A src/api/app/models/event_subscription/for_event_form.rb A src/api/app/models/event_subscription/for_role_form.rb M src/api/app/models/event_subscription/form.rb R src/api/app/models/event_subscription/generate_hash_for_subscriber.rb M src/api/app/views/webui/subscriptions/_subscriptions_form.html.haml A src/api/db/migrate/20200423160517_add_enabled_to_event_subscription.rb M src/api/db/structure.sql M src/api/spec/factories/event_subscriptions.rb M src/api/spec/features/webui/notifications_spec.rb M src/api/spec/models/event_subscription/find_for_event_spec.rb A src/api/spec/models/event_subscription/for_event_form_spec.rb A src/api/spec/models/event_subscription/for_role_form_spec.rb R src/api/spec/models/event_subscription/generate_hash_for_subscriber_spec.rb M src/api/spec/support/shared_contexts/a_user_and_subscriptions.rb M src/api/spec/support/shared_contexts/a_user_and_subscriptions_with_defaults.rb M src/api/spec/support/shared_examples/a_subscriptions_form_for_subscriber.rb M src/api/test/fixtures/event_subscriptions.yml M src/api/test/functional/maintenance_test.rb M src/api/test/models/event_test.rb Log Message: ----------- Merge pull request #9405 from DavidKang/notification/configure-channels Configure multiple notification channels Compare: https://github.com/openSUSE/open-build-service/compare/826dff0ed78f...cba7a2...
participants (1)
-
Victor Pereira