[obs-commits] [openSUSE/open-build-service] c019a8: Implement the project status page in bootstrap
Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: c019a8ea6e01f25ad00e538e229435b622820606 https://github.com/openSUSE/open-build-service/commit/c019a8ea6e01f25ad00e53... Author: Björn Geuken <bgeuken@suse.de> Date: 2018-12-06 (Thu, 06 Dec 2018) Changed paths: M src/api/app/controllers/webui/project_controller.rb M src/api/app/views/webui2/webui/project/_breadcrumb_items.html.haml A src/api/app/views/webui2/webui/project/_edit_comment_form.html.haml A src/api/app/views/webui2/webui/project/edit_comment_form.js.erb A src/api/app/views/webui2/webui/project/status.html.haml Log Message: ----------- Implement the project status page in bootstrap * Convert view to HAML * Use path helpers to generate URLs * Address minor style issues Co-authored-by: Saray Cabrera Padrón scabrerapadron@suse.de Commit: 79bfe96283c3d43bdd760ebc092dc14f23ac6a11 https://github.com/openSUSE/open-build-service/commit/79bfe96283c3d43bdd760e... Author: Björn Geuken <bgeuken@suse.de> Date: 2018-12-06 (Thu, 06 Dec 2018) Changed paths: M src/api/app/views/webui2/webui/project/status.html.haml Log Message: ----------- Move comments to a new column To distinguish between the summary provided by OBS and comments added by maintainers of the project. Co-authored-by: Saray Cabrera Padrón <scabrerapadron@suse.de> Commit: 738debbfb1896afd9e9929f3b9f5b07cc38f22f2 https://github.com/openSUSE/open-build-service/commit/738debbfb1896afd9e9929... Author: Björn Geuken <bgeuken@suse.de> Date: 2018-12-06 (Thu, 06 Dec 2018) Changed paths: M src/api/app/views/webui2/webui/project/status.html.haml Log Message: ----------- Fix column length, add truncation Commit: 081533c13ddf8bc39737b6aeb44fbd32ea8ca86f https://github.com/openSUSE/open-build-service/commit/081533c13ddf8bc39737b6... Author: Saray Cabrera Padrón <scabrerapadron@suse.de> Date: 2018-12-06 (Thu, 06 Dec 2018) Changed paths: M src/api/app/controllers/webui/project_controller.rb A src/api/app/views/webui2/webui/project/_edit_comment.html.haml A src/api/app/views/webui2/webui/project/_status_comment.html.haml A src/api/app/views/webui2/webui/project/edit_comment.js.erb M src/api/app/views/webui2/webui/project/edit_comment_form.js.erb M src/api/app/views/webui2/webui/project/status.html.haml M src/api/config/routes.rb Log Message: ----------- Update comments column to webui2 Inside comments column some partials are rendered, now it renders webui2 ones. Instead of adding the comment's form after the comment itself, it replaces it. After changing the form we realized that we needed to update/save the attribute value in ProjectController#edit_comment. Co-authored-by: Björn Geuken <bgeuken@suse.de> Commit: cdc061761e891854e3f4e763b0b42eceffaea927 https://github.com/openSUSE/open-build-service/commit/cdc061761e891854e3f4e7... Author: Saray Cabrera Padrón <scabrerapadron@suse.de> Date: 2018-12-06 (Thu, 06 Dec 2018) Changed paths: M src/api/app/controllers/webui/project_controller.rb M src/api/app/views/webui/project/edit_comment.js.erb M src/api/app/views/webui/project/edit_comment_form.js.erb M src/api/app/views/webui2/webui/project/_edit_comment.html.haml M src/api/app/views/webui2/webui/project/_status_comment.html.haml A src/api/app/views/webui2/webui/project/clear_failed_comment.js.erb M src/api/app/views/webui2/webui/project/edit_comment.js.erb Log Message: ----------- Add status comment delete action to status table This action allows to delete comments that were added to a project package status. Previously this was only possible when the package stopped having failures. This didn't really make sense since users that can write, and overwrite, comment should also be allowed to delete status comments. Co-authored-by: Björn Geuken <bgeuken@suse.de> Commit: 3004f02e43db35de2da7df58baffdc39012785c1 https://github.com/openSUSE/open-build-service/commit/3004f02e43db35de2da7df... Author: Björn Geuken <bgeuken@suse.de> Date: 2018-12-06 (Thu, 06 Dec 2018) Changed paths: A src/api/app/helpers/webui/projects/status_helper.rb M src/api/app/views/webui2/webui/project/status.html.haml Log Message: ----------- Move view code to a helper This also fixes Rubocop offenses in the moved code. Commit: f263fe84c94edeb7963aa347ece941720afde73d https://github.com/openSUSE/open-build-service/commit/f263fe84c94edeb7963aa3... Author: Henne Vogelsang <hvogel@opensuse.org> Date: 2018-12-06 (Thu, 06 Dec 2018) Changed paths: M src/api/app/controllers/webui/project_controller.rb A src/api/app/helpers/webui/projects/status_helper.rb M src/api/app/views/webui/project/edit_comment.js.erb M src/api/app/views/webui/project/edit_comment_form.js.erb M src/api/app/views/webui2/webui/project/_breadcrumb_items.html.haml A src/api/app/views/webui2/webui/project/_edit_comment.html.haml A src/api/app/views/webui2/webui/project/_edit_comment_form.html.haml A src/api/app/views/webui2/webui/project/_status_comment.html.haml A src/api/app/views/webui2/webui/project/clear_failed_comment.js.erb A src/api/app/views/webui2/webui/project/edit_comment.js.erb A src/api/app/views/webui2/webui/project/edit_comment_form.js.erb A src/api/app/views/webui2/webui/project/status.html.haml M src/api/config/routes.rb Log Message: ----------- Merge pull request #6477 from bgeuken/project_status_in_bootstrap Project status in bootstrap Compare: https://github.com/openSUSE/open-build-service/compare/8d9a3237968e...f263fe... **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.
participants (1)
-
Henne Vogelsang