[obs-commits] [openSUSE/open-build-service] b9f387: [ci] Enable the Performance/RedundantMatch cop
Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: b9f387ec96b89e8fe07f1d50f7ce614a5b1755ac https://github.com/openSUSE/open-build-service/commit/b9f387ec96b89e8fe07f1d... Author: Ana María Martínez Gómez <ammartinez@suse.de> Date: 2017-01-24 (Tue, 24 Jan 2017) Changed paths: M src/api/.rubocop.yml M src/api/.rubocop_todo.yml M src/api/app/controllers/public_controller.rb M src/api/app/controllers/webui/patchinfo_controller.rb M src/api/app/helpers/webui/package_helper.rb M src/api/app/mixins/parse_package_diff.rb M src/api/app/models/project.rb M src/api/lib/tasks/databases.rake Log Message: ----------- [ci] Enable the Performance/RedundantMatch cop Enable the Performance/RedundantMatch Rubocop cop and let Rubocop to correct the offenses. Commit: 68a794da643aca933745a4f8d2a479ab4b831d16 https://github.com/openSUSE/open-build-service/commit/68a794da643aca933745a4... Author: Ana María Martínez Gómez <ammartinez@suse.de> Date: 2017-01-24 (Tue, 24 Jan 2017) Changed paths: M src/api/app/controllers/trigger_controller.rb M src/api/app/helpers/webui/package_helper.rb M src/api/app/models/user.rb M src/api/app/views/webui/package/_files_view.html.erb M src/api/app/views/webui/package/rpmlint_log.html.haml M src/api/app/views/webui/project/status.html.erb M src/api/test/unit/code_quality_test.rb Log Message: ----------- [ci] Rubocop doesn't find all the offenses Correct some more match uses that can be changed by `=~` and that Rubocop doesn't complain about. Commit: f226271edbdcbea121d8504cb367992d823fc14e https://github.com/openSUSE/open-build-service/commit/f226271edbdcbea121d850... Author: Ana María Martínez Gómez <ammartinez@suse.de> Date: 2017-01-24 (Tue, 24 Jan 2017) Changed paths: M src/api/app/models/issue.rb Log Message: ----------- [api] Issue#self.valid_name? returns true/false Makes `Issue#self.valid_name?` method returning only `false/true` as currently the match method could return an object. As it is always used in an `if/unless` clause it works anyway but what is expected is that this method returns only `true/false` Commit: 709c6535f089ef0741eabd908b98da59f5d8d12f https://github.com/openSUSE/open-build-service/commit/709c6535f089ef0741eabd... Author: Moisés Déniz Alemán <mdeniz@suse.com> Date: 2017-01-24 (Tue, 24 Jan 2017) Changed paths: M src/api/.rubocop.yml M src/api/.rubocop_todo.yml M src/api/app/controllers/public_controller.rb M src/api/app/controllers/trigger_controller.rb M src/api/app/controllers/webui/patchinfo_controller.rb M src/api/app/helpers/webui/package_helper.rb M src/api/app/mixins/parse_package_diff.rb M src/api/app/models/issue.rb M src/api/app/models/project.rb M src/api/app/models/user.rb M src/api/app/views/webui/package/_files_view.html.erb M src/api/app/views/webui/package/rpmlint_log.html.haml M src/api/app/views/webui/project/status.html.erb M src/api/lib/tasks/databases.rake M src/api/test/unit/code_quality_test.rb Log Message: ----------- Merge pull request #2599 from Ana06/rub Enable the Performance/RedundantMatch cop Compare: https://github.com/openSUSE/open-build-service/compare/66e450fc8ec5...709c65...
participants (1)
-
Moisés Déniz Alemán