[openSUSE/open-build-service] bb1f15: Do not rely on named scope chain for PackagesFinder
Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: bb1f15720686bf1e233534b8b848f1d4bf47bd69 https://github.com/openSUSE/open-build-service/commit/bb1f15720686bf1e233534... Author: Lukas Krause <lkrause@suse.de> Date: 2021-06-24 (Thu, 24 Jun 2021) Changed paths: M src/api/app/models/backend_package.rb M src/api/app/models/package.rb M src/api/app/models/project.rb Log Message: ----------- Do not rely on named scope chain for PackagesFinder Since Rails 6.1, named scope chains will no longer leak the scope to class level querying methods. As a result of this, every chained usage of the scope "dirty_backend_package" resulted in unexpected/wrong results. See https://guides.rubyonrails.org/6_1_release_notes.html#active-record-notable-... Related to #9748 Co-authored-by: Dany Marcoux <dmarcoux@suse.com> Commit: a3d316e941dd636059eb95c65611f8014c13a3a1 https://github.com/openSUSE/open-build-service/commit/a3d316e941dd636059eb95... Author: Lukas Krause <lkrause@suse.de> Date: 2021-06-24 (Thu, 24 Jun 2021) Changed paths: M src/api/app/models/project.rb M src/api/app/queries/projects_with_image_templates_finder.rb Log Message: ----------- Fix deprecation warning for "local_image_templates" scope Since Rails 6.1, named scope chains will no longer leak the scope to class level querying methods. Since the mentioned scope is only used in one place, we can simply drop it in order to get rid of the deprecation warning. See https://guides.rubyonrails.org/6_1_release_notes.html#active-record-notable-... Related to #9748 Co-authored-by: Dany Marcoux <dmarcoux@suse.com> Commit: 37ded00ae1f4ba3a815cbae1745483e28d8f439a https://github.com/openSUSE/open-build-service/commit/37ded00ae1f4ba3a815cba... Author: Lukas Krause <lkrause@suse.de> Date: 2021-06-24 (Thu, 24 Jun 2021) Changed paths: M src/api/app/models/project.rb R src/api/app/queries/projects_with_delegate_request_target_finder.rb R src/api/spec/queries/projects_with_delegate_request_target_finder_spec.rb Log Message: ----------- Remove unused "delegates_requests" scope This scope and the corresponding query object were never used Co-authored-by: Dany Marcoux <dmarcoux@suse.com> Commit: 279396c296ac8060a54c4f95047dbc52bd8ce060 https://github.com/openSUSE/open-build-service/commit/279396c296ac8060a54c4f... Author: Lukas Krause <lkrause@suse.de> Date: 2021-06-24 (Thu, 24 Jun 2021) Changed paths: M src/api/app/models/project.rb Log Message: ----------- Fix deprecation warning for "very_important_projects_with_attributes" scope Since Rails 6.1, named scope chains will no longer leak the scope to class level querying methods. Since the mentioned scope is only used in one place, we can simply drop it in order to get rid of the deprecation warning. See https://guides.rubyonrails.org/6_1_release_notes.html#active-record-notable-... Related to #9748 Co-authored-by: Dany Marcoux <dmarcoux@suse.com> Commit: b45d73a68154776f057a59483df0f54ef901dd1e https://github.com/openSUSE/open-build-service/commit/b45d73a68154776f057a59... Author: Victor Pereira <vpereira@suse.de> Date: 2021-06-24 (Thu, 24 Jun 2021) Changed paths: M src/api/app/models/backend_package.rb M src/api/app/models/package.rb M src/api/app/models/project.rb R src/api/app/queries/projects_with_delegate_request_target_finder.rb M src/api/app/queries/projects_with_image_templates_finder.rb R src/api/spec/queries/projects_with_delegate_request_target_finder_spec.rb Log Message: ----------- Merge pull request #11284 from openSUSE/next_rails-8 Do not rely on named scope chains in Rails 6.1 Compare: https://github.com/openSUSE/open-build-service/compare/aa368569ed47...b45d73...
participants (1)
-
Victor Pereira