[obs-commits] [openSUSE/open-build-service] f2df84: Do not show 'View file' link for special files
Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: f2df843cb9ccc8959cde224ccb1701682f3efd5f https://github.com/openSUSE/open-build-service/commit/f2df843cb9ccc8959cde22... Author: Christian Bruckmayer <cbruckmayer@suse.com> Date: 2018-10-02 (Tue, 02 Oct 2018) Changed paths: M src/api/app/views/webui2/webui/package/_revision_diff_detail.html.haml Log Message: ----------- Do not show 'View file' link for special files before we used a unless_link_to helper, this was c&p from the old view. However, the unless_link_to helper returns only the link text in case it evalutes to false. In this case we don't want to show the link at all anymore therefore we removed the unless_to_link helper and check for the condition before we even render the link. #5987. Commit: 4d875b6e4834f1d3d53f650cdc35b05d32d1f328 https://github.com/openSUSE/open-build-service/commit/4d875b6e4834f1d3d53f65... Author: Christian Bruckmayer <cbruckmayer@suse.com> Date: 2018-10-02 (Tue, 02 Oct 2018) Changed paths: M src/api/app/views/webui2/webui/package/_revision_diff_detail.html.haml Log Message: ----------- Use calculate_filename helper in revision diff This helper makes sure to also show renamed files properly. It was dropped while refactoring the view to use bootstrap. It is probably not relevant for the revision diff but for the future request diffs it is crucial. Commit: ea8377f6ae46f4c1e9eb96aae5ef7157ad3ac00d https://github.com/openSUSE/open-build-service/commit/ea8377f6ae46f4c1e9eb96... Author: Christian Bruckmayer <cbruckmayer@suse.com> Date: 2018-10-02 (Tue, 02 Oct 2018) Changed paths: M src/api/app/views/webui2/webui/package/_revision_diff_detail.html.haml Log Message: ----------- Merge pull request #5994 from ChrisBr/rdiff Fix several issues on the revision diff Compare: https://github.com/openSUSE/open-build-service/compare/21586cf69f37...ea8377... **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.
participants (1)
-
Christian Bruckmayer