Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: d3ac5092463d3be2390ac4876fa9535ac0c79c1e https://github.com/openSUSE/open-build-service/commit/d3ac5092463d3be2390ac4... Author: Ana María Martínez Gómez <ammartinez@suse.de> Date: 2017-06-30 (Fri, 30 Jun 2017) Changed paths: A src/api/spec/cassettes/Package/_backend_build_command/backend_response_fails/1_13_2_1.yml A src/api/spec/cassettes/Package/_backend_build_command/backend_response_is_successful/1_13_1_1.yml A src/api/spec/cassettes/Package/_backend_build_command/user_has_no_access_rights_for_the_project/1_13_3_1.yml A src/api/spec/cassettes/Package/_buildresults/1_9_1.yml A src/api/spec/cassettes/Package/_buildresults/1_9_10.yml A src/api/spec/cassettes/Package/_buildresults/1_9_11.yml A src/api/spec/cassettes/Package/_buildresults/1_9_12.yml A src/api/spec/cassettes/Package/_buildresults/1_9_13.yml A src/api/spec/cassettes/Package/_buildresults/1_9_2.yml A src/api/spec/cassettes/Package/_buildresults/1_9_3.yml A src/api/spec/cassettes/Package/_buildresults/1_9_4.yml A src/api/spec/cassettes/Package/_buildresults/1_9_5.yml A src/api/spec/cassettes/Package/_buildresults/1_9_6.yml A src/api/spec/cassettes/Package/_buildresults/1_9_7.yml A src/api/spec/cassettes/Package/_buildresults/1_9_8.yml A src/api/spec/cassettes/Package/_buildresults/1_9_9.yml M src/api/spec/cassettes/Package/_delete_file/with_delete_permission/with_custom_options/sets_options_correct.yml M src/api/spec/cassettes/Package/_delete_file/with_delete_permission/with_default_options/deletes_file.yml M src/api/spec/cassettes/Package/_delete_file/with_delete_permission/with_default_options/sets_options_correct.yml M src/api/spec/cassettes/Package/_delete_file/with_no_delete_permission/does_not_delete_file.yml M src/api/spec/cassettes/Package/_delete_file/with_no_delete_permission/raises_DeleteFileNoPermission_exception.yml M src/api/spec/cassettes/Package/_jobhistory_list/when_response_fails/1_14_2_1.yml M src/api/spec/cassettes/Package/_jobhistory_list/when_response_is_successful/1_14_1_1.yml M src/api/spec/cassettes/Package/_jobhistory_list/when_response_is_successful/1_14_1_2.yml M src/api/spec/cassettes/Package/_jobhistory_list/when_response_is_successful/1_14_1_3.yml A src/api/spec/cassettes/Package/_last_build_reason/returns_a_PackageBuildReason_object.yml A src/api/spec/cassettes/Package/_last_build_reason/validation_of_data/for_explain.yml A src/api/spec/cassettes/Package/_last_build_reason/validation_of_data/for_oldsource.yml A src/api/spec/cassettes/Package/_last_build_reason/validation_of_data/for_packagechange_multiple_elements_.yml A src/api/spec/cassettes/Package/_last_build_reason/validation_of_data/for_packagechange_one_element_.yml A src/api/spec/cassettes/Package/_last_build_reason/validation_of_data/for_time.yml A src/api/spec/cassettes/Package/_maintainers/makes_sure_that_no_user_is_listed_more_than_one_time.yml A src/api/spec/cassettes/Package/_maintainers/resolves_groups_properly.yml A src/api/spec/cassettes/Package/_maintainers/returns_an_array_with_user_objects_to_all_maintainers_for_a_package.yml A src/api/spec/cassettes/Package/_maintainers/returns_users_and_the_users_of_resolved_groups.yml A src/api/spec/cassettes/Package/_public_source_path/1_11_1.yml A src/api/spec/cassettes/Package/_public_source_path/1_11_2.yml A src/api/spec/cassettes/Package/_public_source_path/1_11_3.yml M src/api/spec/cassettes/Package/_save_file/calls_addKiwiImport_if_filename_ends_with_kiwi_txz.yml M src/api/spec/cassettes/Package/_save_file/does_not_call_addKiwiImport_if_filename_ends_not_with_kiwi_txz.yml M src/api/spec/cassettes/Package/_service_error/with_error/1_7_2_1.yml M src/api/spec/cassettes/Package/_service_error/without_error/1_7_1_1.yml A src/api/spec/cassettes/Package/_source_path/1_10_1.yml A src/api/spec/cassettes/Package/_source_path/1_10_2.yml A src/api/spec/cassettes/Package/_source_path/1_10_3.yml A src/api/spec/cassettes/Package/_what_depends_on/builds_backend_path_correct.yml A src/api/spec/cassettes/Package/_what_depends_on/with_invalid_repository_or_architecture/returns_an_empty_array.yml A src/api/spec/cassettes/Package/_what_depends_on/with_more_than_one_build_dependency/returns_an_array_with_the_dependencies.yml A src/api/spec/cassettes/Package/_what_depends_on/with_no_build_dependencies/returns_an_empty_array.yml A src/api/spec/cassettes/Package/_what_depends_on/with_one_build_dependency/returns_an_array_with_the_dependency.yml A src/api/spec/cassettes/Package/is_admin_/returns_false_for_non-admins.yml A src/api/spec/cassettes/Package/is_admin_/returns_true_for_admins.yml M src/api/spec/models/package_spec.rb Log Message: ----------- [ci] Fix flickering test: backend_build_command Fix flickering test: `Package#backend_build_command`. In most tests for package model we had this: ``` before do login(user) end ``` where `user.login` is `tom` And there is one test which had instead: ``` let(:other_user) { create(:user) } before do login(other_user) end ``` So in this case `user.login` is not fixed. For the `Package#backend_build_command` we didn't login any user, so there were three options: - The user was not logged in -> `nobody_user` - `tom` is logged in -> `tom` (most of the cases) - `other_user` is logged in -> not fixed name So, the cassets were generating with `tom` as user, so in the other two cases this fail. You can see an example of failure here: github.com/openSUSE/open-build-service/pull/3300#issuecomment-312222370 To fix it I just log `tom` for this tests. I also remove `let(:other_user) { create(:user) }` as there is up already an `other_user` and with a fixed name`. I regenerate all the cassettes for Package and check that `other_user` is only there for the test using it. Commit: afe8d3263c8aa2d06f730979cb0df962c8a17576 https://github.com/openSUSE/open-build-service/commit/afe8d3263c8aa2d06f7309... Author: Ana María Martínez Gómez <ammartinez@suse.de> Date: 2017-06-30 (Fri, 30 Jun 2017) Changed paths: A src/api/spec/cassettes/Package/_backend_build_command/backend_response_fails/1_13_2_1.yml A src/api/spec/cassettes/Package/_backend_build_command/backend_response_is_successful/1_13_1_1.yml A src/api/spec/cassettes/Package/_backend_build_command/user_has_no_access_rights_for_the_project/1_13_3_1.yml A src/api/spec/cassettes/Package/_buildresults/1_9_1.yml A src/api/spec/cassettes/Package/_buildresults/1_9_10.yml A src/api/spec/cassettes/Package/_buildresults/1_9_11.yml A src/api/spec/cassettes/Package/_buildresults/1_9_12.yml A src/api/spec/cassettes/Package/_buildresults/1_9_13.yml A src/api/spec/cassettes/Package/_buildresults/1_9_2.yml A src/api/spec/cassettes/Package/_buildresults/1_9_3.yml A src/api/spec/cassettes/Package/_buildresults/1_9_4.yml A src/api/spec/cassettes/Package/_buildresults/1_9_5.yml A src/api/spec/cassettes/Package/_buildresults/1_9_6.yml A src/api/spec/cassettes/Package/_buildresults/1_9_7.yml A src/api/spec/cassettes/Package/_buildresults/1_9_8.yml A src/api/spec/cassettes/Package/_buildresults/1_9_9.yml M src/api/spec/cassettes/Package/_delete_file/with_delete_permission/with_custom_options/sets_options_correct.yml M src/api/spec/cassettes/Package/_delete_file/with_delete_permission/with_default_options/deletes_file.yml M src/api/spec/cassettes/Package/_delete_file/with_delete_permission/with_default_options/sets_options_correct.yml M src/api/spec/cassettes/Package/_delete_file/with_no_delete_permission/does_not_delete_file.yml M src/api/spec/cassettes/Package/_delete_file/with_no_delete_permission/raises_DeleteFileNoPermission_exception.yml M src/api/spec/cassettes/Package/_jobhistory_list/when_response_fails/1_14_2_1.yml M src/api/spec/cassettes/Package/_jobhistory_list/when_response_is_successful/1_14_1_1.yml M src/api/spec/cassettes/Package/_jobhistory_list/when_response_is_successful/1_14_1_2.yml M src/api/spec/cassettes/Package/_jobhistory_list/when_response_is_successful/1_14_1_3.yml A src/api/spec/cassettes/Package/_last_build_reason/returns_a_PackageBuildReason_object.yml A src/api/spec/cassettes/Package/_last_build_reason/validation_of_data/for_explain.yml A src/api/spec/cassettes/Package/_last_build_reason/validation_of_data/for_oldsource.yml A src/api/spec/cassettes/Package/_last_build_reason/validation_of_data/for_packagechange_multiple_elements_.yml A src/api/spec/cassettes/Package/_last_build_reason/validation_of_data/for_packagechange_one_element_.yml A src/api/spec/cassettes/Package/_last_build_reason/validation_of_data/for_time.yml A src/api/spec/cassettes/Package/_maintainers/makes_sure_that_no_user_is_listed_more_than_one_time.yml A src/api/spec/cassettes/Package/_maintainers/resolves_groups_properly.yml A src/api/spec/cassettes/Package/_maintainers/returns_an_array_with_user_objects_to_all_maintainers_for_a_package.yml A src/api/spec/cassettes/Package/_maintainers/returns_users_and_the_users_of_resolved_groups.yml A src/api/spec/cassettes/Package/_public_source_path/1_11_1.yml A src/api/spec/cassettes/Package/_public_source_path/1_11_2.yml A src/api/spec/cassettes/Package/_public_source_path/1_11_3.yml M src/api/spec/cassettes/Package/_save_file/calls_addKiwiImport_if_filename_ends_with_kiwi_txz.yml M src/api/spec/cassettes/Package/_save_file/does_not_call_addKiwiImport_if_filename_ends_not_with_kiwi_txz.yml M src/api/spec/cassettes/Package/_service_error/with_error/1_7_2_1.yml M src/api/spec/cassettes/Package/_service_error/without_error/1_7_1_1.yml A src/api/spec/cassettes/Package/_source_path/1_10_1.yml A src/api/spec/cassettes/Package/_source_path/1_10_2.yml A src/api/spec/cassettes/Package/_source_path/1_10_3.yml A src/api/spec/cassettes/Package/_what_depends_on/builds_backend_path_correct.yml A src/api/spec/cassettes/Package/_what_depends_on/with_invalid_repository_or_architecture/returns_an_empty_array.yml A src/api/spec/cassettes/Package/_what_depends_on/with_more_than_one_build_dependency/returns_an_array_with_the_dependencies.yml A src/api/spec/cassettes/Package/_what_depends_on/with_no_build_dependencies/returns_an_empty_array.yml A src/api/spec/cassettes/Package/_what_depends_on/with_one_build_dependency/returns_an_array_with_the_dependency.yml A src/api/spec/cassettes/Package/is_admin_/returns_false_for_non-admins.yml A src/api/spec/cassettes/Package/is_admin_/returns_true_for_admins.yml M src/api/spec/models/package_spec.rb Log Message: ----------- Merge pull request #3334 from Ana06/fix_flickering-bbc [ci] Fix flickering test: backend_build_command Compare: https://github.com/openSUSE/open-build-service/compare/a96c84330933...afe8d3...