Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: f9cbdfa2d7b2910cad887e126f04f9dd37a4025f https://github.com/openSUSE/open-build-service/commit/f9cbdfa2d7b2910cad887e... Author: Eduardo Navarro <enavarro@suse.com> Date: 2024-07-05 (Fri, 05 Jul 2024) Changed paths: M src/api/app/views/layouts/webui/_footer.html.haml M src/api/app/views/layouts/webui/_places.html.haml M src/api/app/views/layouts/webui/_top_navigation.html.haml M src/api/app/views/layouts/webui/webui.html.haml M src/api/app/views/webui/package/show.html.haml M src/api/app/views/webui/package/view_file.html.haml M src/api/app/views/webui/packages/branches/new.html.haml M src/api/app/views/webui/packages/files/show.html.haml M src/api/app/views/webui/project/new.html.haml M src/api/app/views/webui/project/show.html.haml M src/api/app/views/webui/request/_actions_details.html.haml M src/api/app/views/webui/request/_request_header.html.haml M src/api/app/views/webui/request/_show_overview.html.haml M src/api/app/views/webui/user/_basic_info.html.haml M src/api/app/views/webui/users/canned_responses/_breadcrumb_items.html.haml M src/api/app/views/webui/users/notifications/_notification_filter.html.haml M src/api/app/views/webui/users/tasks/index.html.haml M src/api/app/views/webui/users/tokens/_breadcrumb_items.html.haml M src/api/app/views/webui/users/tokens/users/_breadcrumb_items.html.haml M src/api/app/views/webui/watched_items/toggle_watched_item.js.erb M src/api/app/views/webui/workflow_runs/_breadcrumb_items.html.haml Log Message: ----------- Substitute `User.session!` with `User.session` in views We don't need to call `User.session!` because in all these cases `User.session` already has a value. Either there was a previous condition like `if User.session`, or the view is called by an action which already has a `require_login` before filter or an `authorize` callback. Commit: 01834a9790774336c2a5f89a99e5d52658df39ad https://github.com/openSUSE/open-build-service/commit/01834a9790774336c2a5f8... Author: Eduardo Navarro <enavarro@suse.com> Date: 2024-07-05 (Fri, 05 Jul 2024) Changed paths: M src/api/app/controllers/webui/cloud/azure/configurations_controller.rb M src/api/app/controllers/webui/cloud/ec2/configurations_controller.rb M src/api/app/controllers/webui/cloud/upload_job/logs_controller.rb M src/api/app/controllers/webui/cloud/upload_jobs_controller.rb M src/api/app/controllers/webui/comment_locks_controller.rb M src/api/app/controllers/webui/comments_controller.rb M src/api/app/controllers/webui/decisions_controller.rb M src/api/app/controllers/webui/packages/branches_controller.rb M src/api/app/controllers/webui/packages/trigger_controller.rb M src/api/app/controllers/webui/patchinfo_controller.rb M src/api/app/controllers/webui/project_controller.rb M src/api/app/controllers/webui/projects/project_configuration_controller.rb M src/api/app/controllers/webui/reports_controller.rb M src/api/app/controllers/webui/request_controller.rb M src/api/app/controllers/webui/session_controller.rb M src/api/app/controllers/webui/staging/projects_controller.rb M src/api/app/controllers/webui/staging/workflows_controller.rb M src/api/app/controllers/webui/users/bs_requests_controller.rb M src/api/app/controllers/webui/users/canned_responses_controller.rb M src/api/app/controllers/webui/users/notifications_controller.rb M src/api/app/controllers/webui/users/patchinfos_controller.rb M src/api/app/controllers/webui/users/subscriptions_controller.rb M src/api/app/controllers/webui/users/tokens_controller.rb M src/api/app/controllers/webui/users_controller.rb M src/api/app/controllers/webui/watched_items_controller.rb M src/api/app/controllers/webui/webui_controller.rb Log Message: ----------- Substitute `User.session!` with `User.session` in webui controllers We don't need to call `User.session!` because in all these cases `User.session` already has a value. Either the action already has a `require_login` before filter or an `authorize` callback. Commit: a4e427d577c020dcc55c862d39acac8a711d6b67 https://github.com/openSUSE/open-build-service/commit/a4e427d577c020dcc55c86... Author: Eduardo J <enavarro@suse.com> Date: 2024-07-08 (Mon, 08 Jul 2024) Changed paths: M src/api/app/controllers/webui/cloud/azure/configurations_controller.rb M src/api/app/controllers/webui/cloud/ec2/configurations_controller.rb M src/api/app/controllers/webui/cloud/upload_job/logs_controller.rb M src/api/app/controllers/webui/cloud/upload_jobs_controller.rb M src/api/app/controllers/webui/comment_locks_controller.rb M src/api/app/controllers/webui/comments_controller.rb M src/api/app/controllers/webui/decisions_controller.rb M src/api/app/controllers/webui/packages/branches_controller.rb M src/api/app/controllers/webui/packages/trigger_controller.rb M src/api/app/controllers/webui/patchinfo_controller.rb M src/api/app/controllers/webui/project_controller.rb M src/api/app/controllers/webui/projects/project_configuration_controller.rb M src/api/app/controllers/webui/reports_controller.rb M src/api/app/controllers/webui/request_controller.rb M src/api/app/controllers/webui/session_controller.rb M src/api/app/controllers/webui/staging/projects_controller.rb M src/api/app/controllers/webui/staging/workflows_controller.rb M src/api/app/controllers/webui/users/bs_requests_controller.rb M src/api/app/controllers/webui/users/canned_responses_controller.rb M src/api/app/controllers/webui/users/notifications_controller.rb M src/api/app/controllers/webui/users/patchinfos_controller.rb M src/api/app/controllers/webui/users/subscriptions_controller.rb M src/api/app/controllers/webui/users/tokens_controller.rb M src/api/app/controllers/webui/users_controller.rb M src/api/app/controllers/webui/watched_items_controller.rb M src/api/app/controllers/webui/webui_controller.rb M src/api/app/views/layouts/webui/_footer.html.haml M src/api/app/views/layouts/webui/_places.html.haml M src/api/app/views/layouts/webui/_top_navigation.html.haml M src/api/app/views/layouts/webui/webui.html.haml M src/api/app/views/webui/package/show.html.haml M src/api/app/views/webui/package/view_file.html.haml M src/api/app/views/webui/packages/branches/new.html.haml M src/api/app/views/webui/packages/files/show.html.haml M src/api/app/views/webui/project/new.html.haml M src/api/app/views/webui/project/show.html.haml M src/api/app/views/webui/request/_actions_details.html.haml M src/api/app/views/webui/request/_request_header.html.haml M src/api/app/views/webui/request/_show_overview.html.haml M src/api/app/views/webui/user/_basic_info.html.haml M src/api/app/views/webui/users/canned_responses/_breadcrumb_items.html.haml M src/api/app/views/webui/users/notifications/_notification_filter.html.haml M src/api/app/views/webui/users/tasks/index.html.haml M src/api/app/views/webui/users/tokens/_breadcrumb_items.html.haml M src/api/app/views/webui/users/tokens/users/_breadcrumb_items.html.haml M src/api/app/views/webui/watched_items/toggle_watched_item.js.erb M src/api/app/views/webui/workflow_runs/_breadcrumb_items.html.haml Log Message: ----------- Merge pull request #16453 from eduardoj/refactoring/user_session Substitute `User.session!` with `User.session` Compare: https://github.com/openSUSE/open-build-service/compare/2555059ee1b6...a4e427... To unsubscribe from these emails, change your notification settings at https://github.com/openSUSE/open-build-service/settings/notifications