Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: f3ec7fcd1e54520649a11303679b90d88fb00826 https://github.com/openSUSE/open-build-service/commit/f3ec7fcd1e54520649a113... Author: Björn Geuken Date: 2018-02-26 (Mon, 26 Feb 2018) Changed paths: A src/api/.jshintignore Log Message: ----------- [frontend] jshint: Ignore external javascript files Ignore javascript files that are maintained by external projects. We should move them to vendor/assets at some point. Commit: a439c3e6a5bfa181bfda5eb5f29e16ca8197838a https://github.com/openSUSE/open-build-service/commit/a439c3e6a5bfa181bfda5e... Author: Björn Geuken Date: 2018-02-26 (Mon, 26 Feb 2018) Changed paths: A src/api/.jshintrc M src/api/app/assets/javascripts/webui/application/comment.js M src/api/app/assets/javascripts/webui/application/image_templates.js M src/api/app/assets/javascripts/webui/application/kiwi_editor.js M src/api/app/assets/javascripts/webui/application/main.js M src/api/app/assets/javascripts/webui/application/package.js M src/api/app/assets/javascripts/webui/application/project.js M src/api/app/assets/javascripts/webui/application/request.js M src/api/app/assets/javascripts/webui/application/user.js Log Message: ----------- [frontend] Add js style rule: Require triple equals Use === instead of ==. The == and != operator are not only comparing two values. But also trying to convert the variable on the right side, if their types are not identical. This can be quite a complex logic due to the various combinations[*] that are possible. To simplify things and avoid confusion for people that are js experts, who is?, it's better to stick with ===. https://dorey.github.io/JavaScript-Equality-Table/ Commit: 2a6140ae0f7f59bd0f8c4b9a0890c11d99cf1415 https://github.com/openSUSE/open-build-service/commit/2a6140ae0f7f59bd0f8c4b... Author: Björn Geuken Date: 2018-02-26 (Mon, 26 Feb 2018) Changed paths: M src/api/app/assets/javascripts/webui/application/project.js Log Message: ----------- [frontend] Add js style rule: Prohibit unused variables Disallows unused variables and functions. Some of our functions are called via inline javascript. Hence we have to disable jshint for these lines. I tried disabling only this one cop for the line of code as described in their documentation. Unfortunately this did not work. Commit: 758da9614038bd0bf705273d4af6d589bef733ae https://github.com/openSUSE/open-build-service/commit/758da9614038bd0bf70527... Author: Björn Geuken Date: 2018-02-26 (Mon, 26 Feb 2018) Changed paths: M dist/ci/travis_script.sh Log Message: ----------- [frontend] Reduce the scope of directories we want to jslint, part II Similar to 2b03728a423db50117985fda6822f229513a1368 but this time for our travis test suite. In travis all our gems land in the vendor/bundle diredctory. Since we were calling jshint in the main directory, jshint was checking the javascript style of all our gems. Commit: 5d5c04aa1ba2258ff225bed4e77bc352bb406c33 https://github.com/openSUSE/open-build-service/commit/5d5c04aa1ba2258ff225be... Author: Björn Geuken Date: 2018-02-26 (Mon, 26 Feb 2018) Changed paths: M dist/ci/travis_script.sh A src/api/.jshintignore A src/api/.jshintrc M src/api/app/assets/javascripts/webui/application/comment.js M src/api/app/assets/javascripts/webui/application/image_templates.js M src/api/app/assets/javascripts/webui/application/kiwi_editor.js M src/api/app/assets/javascripts/webui/application/main.js M src/api/app/assets/javascripts/webui/application/package.js M src/api/app/assets/javascripts/webui/application/project.js M src/api/app/assets/javascripts/webui/application/request.js M src/api/app/assets/javascripts/webui/application/user.js Log Message: ----------- Merge pull request #4566 from bgeuken/add_jshint_rules Add jshint rules Compare: https://github.com/openSUSE/open-build-service/compare/f6527b8d2233...5d5c04...