[obs-commits] [openSUSE/software-o-o] f981c2: Improve logic readability
Branch: refs/heads/master Home: https://github.com/openSUSE/software-o-o Commit: f981c2b41feef566ec066d61b772e6babad6476e https://github.com/openSUSE/software-o-o/commit/f981c2b41feef566ec066d61b772... Author: Alexander Graul <agraul@suse.com> Date: 2018-06-05 (Tue, 05 Jun 2018) Changed paths: M app/controllers/search_controller.rb Log Message: ----------- Improve logic readability Change double negative check to a positive check. Commit: 0c79506d92218e3446553a9c82e736f50c468378 https://github.com/openSUSE/software-o-o/commit/0c79506d92218e3446553a9c82e7... Author: Alexander Graul <agraul@suse.com> Date: 2018-06-05 (Tue, 05 Jun 2018) Changed paths: M .rubocop_todo.yml M app/controllers/application_controller.rb M app/controllers/distributions_controller.rb A app/controllers/obs_controller.rb M app/controllers/package_controller.rb M app/controllers/search_controller.rb Log Message: ----------- Refactor: new obs_controller Loading distribution information logic from OBS is moved to a separate controller along with methods that depend on this kind of information. If the connection to OBS is down, searching is disabled and the user is notified. .rubocop_todo.yml was updated because offending code was moved Commit: 9dd433987bb10fa01026df95d07e84f74a688964 https://github.com/openSUSE/software-o-o/commit/9dd433987bb10fa01026df95d07e... Author: Alexander Graul <agraul@suse.com> Date: 2018-06-05 (Tue, 05 Jun 2018) Changed paths: A test/integration/obs_controller_test.rb Log Message: ----------- add obs_controller integration tests Commit: 9c4e7b89ebd304b718a11d0119e30d4b38f39e51 https://github.com/openSUSE/software-o-o/commit/9c4e7b89ebd304b718a11d0119e3... Author: Ana María Martínez Gómez <ammartinez@suse.de> Date: 2018-06-05 (Tue, 05 Jun 2018) Changed paths: M .rubocop_todo.yml M app/controllers/application_controller.rb M app/controllers/distributions_controller.rb A app/controllers/obs_controller.rb M app/controllers/package_controller.rb M app/controllers/search_controller.rb A test/integration/obs_controller_test.rb Log Message: ----------- Merge pull request #319 from alexandergraul/obs_controller Refactor: new obs_controller Compare: https://github.com/openSUSE/software-o-o/compare/6faaa977c06d...9c4e7b89ebd3 **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.
participants (1)
-
Ana María Martínez Gómez