Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: cd1a5c4ada2e80a92f8f8f80cfec05d3eb18a7a6 https://github.com/openSUSE/open-build-service/commit/cd1a5c4ada2e80a92f8f8f... Author: Henne Vogelsang <hvogel@opensuse.org> Date: 2024-05-28 (Tue, 28 May 2024) Changed paths: M src/api/app/controllers/webui/status_messages_controller.rb M src/api/app/models/status_message.rb M src/api/app/views/webui/status_messages/acknowledge.js.haml M src/api/spec/controllers/webui/status_messages_controller_spec.rb Log Message: ----------- Fix status message acknowledgement This doesn't require special privileges. Also simplify it a bit more: - Collecting metrics should be done in the model - It's enough to render the partial, not the whole action again - There never will be an error flash, no need to handle it in the js view Commit: 73b45e12108af74a601d86e4ea96bc2120763cab https://github.com/openSUSE/open-build-service/commit/73b45e12108af74a601d86... Author: Henne Vogelsang <hvogel@opensuse.org> Date: 2024-05-28 (Tue, 28 May 2024) Changed paths: M src/api/app/controllers/webui/users/subscriptions_controller.rb R src/api/app/views/webui/users/subscriptions/index.js.haml Log Message: ----------- Drop remains of resetting subscriptions to default This got added in #4186 and #4384 and then removed while switching interfaces to bootstrap in #8341. Fixes #16198 which was caused by a spammer script going back and forth on routes with format=js because it could not acknowledge a status message anymore. Thanks spammer, keep up the good work! Commit: 40154109411f0a78477a0c639df7f197199c8875 https://github.com/openSUSE/open-build-service/commit/40154109411f0a78477a0c... Author: Henne Vogelsang <hvogel@opensuse.org> Date: 2024-05-28 (Tue, 28 May 2024) Changed paths: M src/api/app/controllers/webui/status_messages_controller.rb M src/api/app/controllers/webui/users/subscriptions_controller.rb M src/api/app/models/status_message.rb M src/api/app/views/webui/status_messages/acknowledge.js.haml R src/api/app/views/webui/users/subscriptions/index.js.haml M src/api/spec/controllers/webui/status_messages_controller_spec.rb Log Message: ----------- Merge pull request #16212 from hennevogel/bugfix/16198 Fix acknowledging status messages Compare: https://github.com/openSUSE/open-build-service/compare/2b321e108c31...401541... To unsubscribe from these emails, change your notification settings at https://github.com/openSUSE/open-build-service/settings/notifications