[obs-commits] [openSUSE/open-build-service] d40357: [api] remove unneeded to_datetime

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: d40357af36bab4ecf3c68751272feec29ab5193e https://github.com/openSUSE/open-build-service/commit/d40357af36bab4ecf3c687... Author: Ana María Martínez Gómez <ammartinez@suse.de> Date: 2018-07-02 (Mon, 02 Jul 2018) Changed paths: M src/api/app/models/binary_release.rb Log Message: ----------- [api] remove unneeded to_datetime `binary_buildtime` is always `DateTime`, so the conversion is not needed. Commit: 28ff0f8b6293b1a69664089894a38fa6c2e9098b https://github.com/openSUSE/open-build-service/commit/28ff0f8b6293b1a6966408... Author: Ana María Martínez Gómez <ammartinez@suse.de> Date: 2018-07-02 (Mon, 02 Jul 2018) Changed paths: M src/api/app/models/binary_release.rb Log Message: ----------- [api] conversion to utc not needed Because of creating the time with the seconds since the Unix Epoch, we are already using utc. Commit: 348b124a3bfdd81711388647c038669068e49d40 https://github.com/openSUSE/open-build-service/commit/348b124a3bfdd817113886... Author: Ana María Martínez Gómez <ammartinez@suse.de> Date: 2018-07-02 (Mon, 02 Jul 2018) Changed paths: M src/api/app/models/binary_release.rb Log Message: ----------- [api] modify how binary_buildtime is created To be coherent with the comparision in the same class. Commit: 21b2a4cf6129aed5a2d82aa61fd8f936a591f446 https://github.com/openSUSE/open-build-service/commit/21b2a4cf6129aed5a2d82a... Author: Ana María Martínez Gómez <ammartinez@suse.de> Date: 2018-07-02 (Mon, 02 Jul 2018) Changed paths: M src/api/.rubocop_todo.yml M src/api/app/models/binary_release.rb Log Message: ----------- [ci] Regenerate rubocop_todo.yml To exclude DateTime offenses. I actually wanted to disable it in the `.rubocop.yml` file, because although we could use Time to make Rubocop happy, as both classes can be used to do the same, the `to_s` is different. So it seems reasonable to keep it for compatibility reason. But is is not possible because of a Rubocop bug: https://github.com/rubocop-hq/rubocop/issues/5199 Commit: 307d8e9864aa2805f43e2b71a25652d81ffa3b32 https://github.com/openSUSE/open-build-service/commit/307d8e9864aa2805f43e2b... Author: Ana María Martínez Gómez <ammartinez@suse.de> Date: 2018-07-02 (Mon, 02 Jul 2018) Changed paths: M src/api/.rubocop_todo.yml M src/api/app/models/binary_release.rb Log Message: ----------- Merge pull request #5251 from Ana06/binary_buildtime Refactor binary_buildtime Compare: https://github.com/openSUSE/open-build-service/compare/d249238c716e...307d8e... **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.
participants (1)
-
Ana María Martínez Gómez