[obs-commits] [openSUSE/open-build-service] 580157: Make it clearer that managers are a group
Branch: refs/heads/staging-workflow Home: https://github.com/openSUSE/open-build-service Commit: 580157555f74dfc7f06551b9e235ef8dae49d5ef https://github.com/openSUSE/open-build-service/commit/580157555f74dfc7f06551... Author: Dany Marcoux <danymarcoux@gmail.com> Date: 2018-11-21 (Wed, 21 Nov 2018) Changed paths: M src/api/app/views/webui2/webui/staging/workflows/new.html.haml Log Message: ----------- Make it clearer that managers are a group Also use the right tag for a paragraph Commit: 319744d569d2da9b0fa47c3cb6d6e9931ffedbbc https://github.com/openSUSE/open-build-service/commit/319744d569d2da9b0fa47c... Author: Dany Marcoux <danymarcoux@gmail.com> Date: 2018-11-21 (Wed, 21 Nov 2018) Changed paths: M src/api/app/controllers/webui/staging/workflows_controller.rb M src/api/spec/controllers/webui/staging/workflows_controller_spec.rb Log Message: ----------- Deal with non-existent managers group We need to use `redirect_to` instead of `render` as otherwise, the value of `action_name` is `create` instead of `new`. This would bring a lot of issues in the rendering of the breadcrumbs. Fixes #6313 Commit: 779ebf12b49a7b0b6378bdd281516c637ba1011b https://github.com/openSUSE/open-build-service/commit/779ebf12b49a7b0b6378bd... Author: Dany Marcoux <danymarcoux@gmail.com> Date: 2018-11-21 (Wed, 21 Nov 2018) Changed paths: M src/api/app/views/webui2/webui/staging/workflows/new.html.haml Log Message: ----------- Add note for creation of managers groups Commit: 9bdbfea9a640a9f6236ade7bcba706438e2de425 https://github.com/openSUSE/open-build-service/commit/9bdbfea9a640a9f6236ade... Author: Henne Vogelsang <hvogel@opensuse.org> Date: 2018-11-21 (Wed, 21 Nov 2018) Changed paths: M src/api/app/controllers/webui/staging/workflows_controller.rb M src/api/app/views/webui2/webui/staging/workflows/new.html.haml M src/api/spec/controllers/webui/staging/workflows_controller_spec.rb Log Message: ----------- Merge pull request #6324 from dmarcoux/staging-workflow-managers-group-improvements Staging workflow managers group improvements Compare: https://github.com/openSUSE/open-build-service/compare/44c3b436ab7c...9bdbfe... **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.
participants (1)
-
Henne Vogelsang