Branch: refs/heads/master
Home: https://github.com/openSUSE/open-build-service
Commit: 5f73b71bdcba50a991eb3c5e8c4b5ccf428c449e
https://github.com/openSUSE/open-build-service/commit/5f73b71bdcba50a991eb3c...
Author: Adrian Schröter
Date: 2016-02-29 (Mon, 29 Feb 2016)
Changed paths:
M src/api/app/controllers/webui/request_controller.rb
M src/api/app/models/bs_request.rb
M src/api/app/models/history_element.rb
M src/api/app/models/package.rb
M src/api/app/models/project.rb
M src/api/app/models/review.rb
M src/api/config/initializers/valid_states.rb
M src/api/test/functional/webui/request_controller_test.rb
M src/api/test/unit/code_quality_test.rb
M src/api/test/unit/package_remove_test.rb
M src/api/test/unit/project_remove_test.rb
Log Message:
-----------
[api][webui] fix review handling and validation
- it was possible since the webui merge to create invalid reviews in DB, eg
projects containing a "/" in name. This leads to crashes when just trying
to view the request in webui due to routing errors
- reviews got removed (even in the history) when the reviewer object got
removed (not at all for packages due to another bug though).
Reviews get turned into "obsolete" state now instead
Commit: 9e44dda136d01287aebb32bcc81235e534bdb416
https://github.com/openSUSE/open-build-service/commit/9e44dda136d01287aebb32...
Author: Björn Geuken
Date: 2016-03-01 (Tue, 01 Mar 2016)
Changed paths:
M src/api/app/controllers/webui/request_controller.rb
M src/api/app/models/bs_request.rb
M src/api/app/models/history_element.rb
M src/api/app/models/package.rb
M src/api/app/models/project.rb
M src/api/app/models/review.rb
M src/api/config/initializers/valid_states.rb
M src/api/test/functional/webui/request_controller_test.rb
M src/api/test/unit/code_quality_test.rb
M src/api/test/unit/package_remove_test.rb
M src/api/test/unit/project_remove_test.rb
Log Message:
-----------
Merge pull request #1593 from adrianschroeter/review_validation
[webui] fix review handling and validation
Compare: https://github.com/openSUSE/open-build-service/compare/7a57a56d489f...9e44dd...