[obs-commits] [openSUSE/open-build-service] 6fb2a2: Avoid N+1 queries in comments controller
Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 6fb2a24bab901ea9b9517efd916dd87e1bae0390 https://github.com/openSUSE/open-build-service/commit/6fb2a24bab901ea9b9517e... Author: Stephan Kulow <coolo@suse.de> Date: 2018-12-19 (Wed, 19 Dec 2018) Changed paths: M src/api/app/controllers/comments_controller.rb Log Message: ----------- Avoid N+1 queries in comments controller According to metrics.opensuse.org the comments/index.xml.builder view has the most impact - rendered 106K in 24 hours (all these bots communicating through comments don't help) Commit: ad2bc11601127009b12247aacb32e7efbc9728d2 https://github.com/openSUSE/open-build-service/commit/ad2bc11601127009b12247... Author: Stephan Kulow <coolo@suse.de> Date: 2018-12-19 (Wed, 19 Dec 2018) Changed paths: R src/api/app/views/comments/_comments.xml.builder M src/api/app/views/comments/index.xml.builder Log Message: ----------- Merge 2 three-line views into one The partial is only used in one view and repeats the same call in a loop, so better pull it out Commit: dbc61f858760e456bbb00691e598ed1a8752adc0 https://github.com/openSUSE/open-build-service/commit/dbc61f858760e456bbb006... Author: Stephan Kulow <stephan@kulow.org> Date: 2018-12-19 (Wed, 19 Dec 2018) Changed paths: M src/api/app/controllers/comments_controller.rb R src/api/app/views/comments/_comments.xml.builder M src/api/app/views/comments/index.xml.builder Log Message: ----------- Merge pull request #6668 from coolo/preload_users Avoid N+1 queries in comments controller Compare: https://github.com/openSUSE/open-build-service/compare/12c4f9a52101...dbc61f... **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.
participants (1)
-
Stephan Kulow