[openSUSE/open-build-service] 473e37: Add view component for sourcediff_tab and move hel...
Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 473e37aa43d719a1f2702663ffdc59a04305bcaf https://github.com/openSUSE/open-build-service/commit/473e37aa43d719a1f27026... Author: Rubhan Azeem <rubhanazeem@gmail.com> Date: 2021-10-25 (Mon, 25 Oct 2021) Changed paths: A src/api/app/components/sourcediff_tab_component.html.haml A src/api/app/components/sourcediff_tab_component.rb M src/api/app/controllers/webui/webui_controller.rb M src/api/app/helpers/webui/webui_helper.rb R src/api/app/views/webui/request/_sourcediff_tab.html.haml M src/api/app/views/webui/request/request_action.js.erb Log Message: ----------- Add view component for sourcediff_tab and move helper method valid_xml_id These changes are the followup of PR #11296. Adding a new view component sourcediff_tab_component and moved the controller helper method valid_xml_id to view helper webui_helper. In addition, link_to_package and link_to_project helpers are also refectored. Commit: 6245cf6f529c57ed67e95c38c1ea10bebd076e65 https://github.com/openSUSE/open-build-service/commit/6245cf6f529c57ed67e95c... Author: Rubhan Azeem <rubhanazeem@gmail.com> Date: 2021-10-25 (Mon, 25 Oct 2021) Changed paths: A src/api/spec/cassettes/SourcediffTabComponent/shows_the_correct_changes/1_1_1.yml A src/api/spec/cassettes/SourcediffTabComponent/shows_the_correct_changes/1_1_2.yml A src/api/spec/cassettes/SourcediffTabComponent/shows_the_correct_changes/1_1_3.yml A src/api/spec/cassettes/SourcediffTabComponent/shows_the_correct_changes/1_1_4.yml A src/api/spec/cassettes/SourcediffTabComponent/shows_the_correct_changes/1_1_5.yml A src/api/spec/cassettes/SourcediffTabComponent/shows_the_correct_changes/1_1_6.yml A src/api/spec/cassettes/SourcediffTabComponent/shows_the_correct_changes/1_1_7.yml A src/api/spec/components/previews/sourcediff_tab_component_preview.rb A src/api/spec/components/sourcediff_tab_component_spec.rb M src/api/spec/controllers/webui/webui_controller_spec.rb M src/api/spec/helpers/webui/webui_helper_spec.rb Log Message: ----------- Add specs for sourcediff_tab view component Adding the specs for sourcediff_tab_compnent and refactored the specs for webui_controller and webui_helper. Commit: dd863c268e193e2460851b3ae507e0a2b9772d1c https://github.com/openSUSE/open-build-service/commit/dd863c268e193e2460851b... Author: Rubhan Azeem <rubhanazeem@gmail.com> Date: 2021-10-25 (Mon, 25 Oct 2021) Changed paths: A src/api/app/components/sourcediff_tab_component.html.haml A src/api/app/components/sourcediff_tab_component.rb M src/api/app/controllers/webui/webui_controller.rb M src/api/app/helpers/webui/webui_helper.rb R src/api/app/views/webui/request/_sourcediff_tab.html.haml M src/api/app/views/webui/request/request_action.js.erb A src/api/spec/cassettes/SourcediffTabComponent/shows_the_correct_changes/1_1_1.yml A src/api/spec/cassettes/SourcediffTabComponent/shows_the_correct_changes/1_1_2.yml A src/api/spec/cassettes/SourcediffTabComponent/shows_the_correct_changes/1_1_3.yml A src/api/spec/cassettes/SourcediffTabComponent/shows_the_correct_changes/1_1_4.yml A src/api/spec/cassettes/SourcediffTabComponent/shows_the_correct_changes/1_1_5.yml A src/api/spec/cassettes/SourcediffTabComponent/shows_the_correct_changes/1_1_6.yml A src/api/spec/cassettes/SourcediffTabComponent/shows_the_correct_changes/1_1_7.yml A src/api/spec/components/previews/sourcediff_tab_component_preview.rb A src/api/spec/components/sourcediff_tab_component_spec.rb M src/api/spec/controllers/webui/webui_controller_spec.rb M src/api/spec/helpers/webui/webui_helper_spec.rb Log Message: ----------- Merge pull request #11780 from rubhanazeem/req-show-view-comp View component for sourcediff on Request#show Compare: https://github.com/openSUSE/open-build-service/compare/916371b69f3c...dd863c...
participants (1)
-
Rubhan Azeem