[obs-commits] [openSUSE/open-build-service] b42ddf: [api][webui] Update Notification to use JSON seria...
Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: b42ddffcab3800c6d407b52f6364684d9810aac1 https://github.com/openSUSE/open-build-service/commit/b42ddffcab3800c6d407b5... Author: Evan Rolfe <evanrolfe@gmail.com> Date: 2017-10-23 (Mon, 23 Oct 2017) Changed paths: M ReleaseNotes-2.9 M src/api/app/models/notification.rb M src/api/lib/tasks/databases.rake M src/api/spec/jobs/send_event_emails_job_spec.rb A src/api/spec/lib/tasks/databases_spec.rb M src/api/spec/spec_helper.rb Log Message: ----------- [api][webui] Update Notification to use JSON serialisation. Otherwise the Event.payload gets parsed from json, then serialised as YAML into Notification.event_payload which sometimes causes errors because the payload can fit into the events table (with JSON serialisation) but might not fit into notifications.event_payload becuase YAML serialisation takes up more characters than JSON does. Commit: 56b6b098df29490517b6385283125248dfceeea9 https://github.com/openSUSE/open-build-service/commit/56b6b098df29490517b638... Author: Evan Rolfe <evanrolfe@gmail.com> Date: 2017-10-23 (Mon, 23 Oct 2017) Changed paths: M .gitignore M ReleaseNotes-2.9 M dist/README.UPDATERS M src/api/Gemfile M src/api/Gemfile.lock A src/api/db/data/20170831143534_convert_notifications_event_payload_to_json.rb R src/api/db/data/empty M src/api/db/structure.sql M src/api/lib/tasks/databases.rake A src/api/spec/db/data/convert_notifications_event_payload_to_json_spec.rb R src/api/spec/lib/tasks/databases_spec.rb M src/api/spec/spec_helper.rb Log Message: ----------- [api] Handle database data changes with a gem. Use the data-migrate gem to handle changes to data with their own set of migrations just like we handle changes to the database structure. This gives us a set structure to update existing data in the database and gives us a single command to run (rake db:migrate:with_data) in deployments. Commit: f2c305d4df6487c58091f201a29aa281d0957e5d https://github.com/openSUSE/open-build-service/commit/f2c305d4df6487c58091f2... Author: Henne Vogelsang <hvogel@opensuse.org> Date: 2017-10-23 (Mon, 23 Oct 2017) Changed paths: M .gitignore M dist/README.UPDATERS M src/api/Gemfile M src/api/Gemfile.lock M src/api/app/models/notification.rb A src/api/db/data/20170831143534_convert_notifications_event_payload_to_json.rb R src/api/db/data/empty M src/api/db/structure.sql M src/api/lib/tasks/databases.rake A src/api/spec/db/data/convert_notifications_event_payload_to_json_spec.rb M src/api/spec/jobs/send_event_emails_job_spec.rb Log Message: ----------- Merge pull request #3701 from evanrolfe/refactor/notification_payload_serialisation [api][webui] Update Notification to use JSON serialisation. Compare: https://github.com/openSUSE/open-build-service/compare/8bb93f02cdd8...f2c305...
participants (1)
-
Henne Vogelsang