[openSUSE/open-build-service] 76f366: Update flipper to version 0.24.0
Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 76f36663476dc5757e68857a69d1e416f00a7d73 https://github.com/openSUSE/open-build-service/commit/76f36663476dc5757e6885... Author: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com> Date: 2022-03-21 (Mon, 21 Mar 2022) Changed paths: M src/api/Gemfile.lock R src/api/vendor/cache/flipper-0.23.1.gem A src/api/vendor/cache/flipper-0.24.0.gem R src/api/vendor/cache/flipper-active_record-0.23.1.gem A src/api/vendor/cache/flipper-active_record-0.24.0.gem R src/api/vendor/cache/flipper-ui-0.23.0.gem A src/api/vendor/cache/flipper-ui-0.24.0.gem R src/api/vendor/cache/mini_portile2-2.6.1.gem A src/api/vendor/cache/mini_portile2-2.7.1.gem R src/api/vendor/cache/nokogiri-1.12.5.gem A src/api/vendor/cache/nokogiri-1.13.1.gem Log Message: ----------- Update flipper to version 0.24.0 Commit: 1aca8cf50f300a1296fec57f085f83a62b2b20bd https://github.com/openSUSE/open-build-service/commit/1aca8cf50f300a1296fec5... Author: Dany Marcoux <dmarcoux@posteo.de> Date: 2022-03-21 (Mon, 21 Mar 2022) Changed paths: M src/api/app/models/kiwi/image/xml_builder.rb M src/api/spec/models/kiwi/image_spec.rb Log Message: ----------- Fix broken specs in Kiwi::Image model Two specs were failing when checking if the subject didn't have errors: ``` Failure/Error: it { expect(subject.errors).to be_empty } expected `[#<Nokogiri::XML::SyntaxError: 1:12: FATAL: XML declaration allowed only at the start of the document>].empty?` to be truthy, got false ./spec/models/kiwi/image_spec.rb:226:in `block (5 levels) in <top (required)>' Failure/Error: expect(subject.errors).to be_empty expected `[#<Nokogiri::XML::SyntaxError: 1:12: FATAL: XML declaration allowed only at the start of the document>].empty?` to be truthy, got false ./spec/models/kiwi/image_spec.rb:279:in `block (4 levels) in <top (required)>' ``` Those errors weren't reported before nokogiri _1.13.0_, as noted in the changelog upstream:
XML::DocumentFragment#errors now correctly contains any parsing errors encountered. Previously this was always empty. (Note that HTML::DocumentFragment#errors already did this.)
Relying on XML::DocumentFragment was wrong since the XML generated by the Kiwi::Image's to_xml and kiwi_body methods is not a document fragment, but a document. They contain a XML declaration (`<?xml ...?>`), so changing the class solves the issue. Commit: 27c1f00afdb29f82e54f5d7611e44efcd9fc10af https://github.com/openSUSE/open-build-service/commit/27c1f00afdb29f82e54f5d... Author: Dany Marcoux <dmarcoux@posteo.de> Date: 2022-03-22 (Tue, 22 Mar 2022) Changed paths: M src/api/Gemfile.lock M src/api/app/models/kiwi/image/xml_builder.rb M src/api/spec/models/kiwi/image_spec.rb R src/api/vendor/cache/flipper-0.23.1.gem A src/api/vendor/cache/flipper-0.24.0.gem R src/api/vendor/cache/flipper-active_record-0.23.1.gem A src/api/vendor/cache/flipper-active_record-0.24.0.gem R src/api/vendor/cache/flipper-ui-0.23.0.gem A src/api/vendor/cache/flipper-ui-0.24.0.gem R src/api/vendor/cache/mini_portile2-2.6.1.gem A src/api/vendor/cache/mini_portile2-2.7.1.gem R src/api/vendor/cache/nokogiri-1.12.5.gem A src/api/vendor/cache/nokogiri-1.13.1.gem Log Message: ----------- Merge pull request #12232 from openSUSE/depfu/update/srcapi/flipper-0.24.0 [src/api] Update flipper: 0.23.1 → 0.24.0 (major) Compare: https://github.com/openSUSE/open-build-service/compare/54999a0d7368...27c1f0...
participants (1)
-
Dany Marcoux