Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 0ad3ae87bd602be3346ec4f6d6e3ffb8dee25f90 https://github.com/openSUSE/open-build-service/commit/0ad3ae87bd602be3346ec4... Author: Henne Vogelsang Date: 2024-06-07 (Fri, 07 Jun 2024) Changed paths: M src/api/app/components/notification_component.html.haml M src/api/app/components/notification_component.rb M src/api/app/components/notification_notifiable_link_component.rb M src/api/app/controllers/webui/users/notifications_controller.rb M src/api/app/views/webui/users/notifications/_notifications_list.html.haml M src/api/app/views/webui/users/notifications/_update.js.erb M src/api/app/views/webui/users/notifications/index.html.haml M src/api/spec/components/notification_component_spec.rb M src/api/spec/components/notification_notifiable_link_component_spec.rb Log Message: ----------- Stop re-inventing User.session Just because a rubocop rule we created ourselves tells us to... Commit: a9568ce21e3a789823ef16b3e8382f033fe9cb1e https://github.com/openSUSE/open-build-service/commit/a9568ce21e3a789823ef16... Author: Henne Vogelsang Date: 2024-06-07 (Fri, 07 Jun 2024) Changed paths: M src/api/app/controllers/webui/users/notifications_controller.rb M src/api/app/views/webui/users/notifications/index.html.haml Log Message: ----------- Clean up set_selected_filter Move things where they belong... Commit: b1bada3607c3423a3f9e8a5c2d6528dae3658644 https://github.com/openSUSE/open-build-service/commit/b1bada3607c3423a3f9e8a... Author: Henne Vogelsang Date: 2024-06-07 (Fri, 07 Jun 2024) Changed paths: M src/api/app/components/notification_action_bar_component.html.haml M src/api/app/components/notification_action_bar_component.rb M src/api/app/controllers/webui/users/notifications_controller.rb M src/api/app/views/webui/users/notifications/_notifications_list.html.haml M src/api/app/views/webui/users/notifications/_update.js.erb M src/api/app/views/webui/users/notifications/index.html.haml M src/api/spec/components/notification_action_bar_component_spec.rb M src/api/spec/components/previews/notification_action_bar_component_preview.rb Log Message: ----------- Stop passing around the show_read_all_button variable It's just comparing two numbers, do this in the view. Commit: dad577a872ad641c6537bf7618b4f146fc2eb09c https://github.com/openSUSE/open-build-service/commit/dad577a872ad641c6537bf... Author: Henne Vogelsang Date: 2024-06-07 (Fri, 07 Jun 2024) Changed paths: M src/api/app/controllers/webui/users/notifications_controller.rb Log Message: ----------- Stop raising APIErrors in Webui controller Drop the unsupported things instead... Commit: 3a82343f7f6f300344debc269869b90db7fc1016 https://github.com/openSUSE/open-build-service/commit/3a82343f7f6f300344debc... Author: Henne Vogelsang Date: 2024-06-07 (Fri, 07 Jun 2024) Changed paths: M src/api/app/components/notification_action_bar_component.html.haml M src/api/app/components/notification_action_bar_component.rb M src/api/app/components/notification_component.html.haml M src/api/app/components/notification_component.rb M src/api/app/components/notification_notifiable_link_component.rb M src/api/app/controllers/webui/users/notifications_controller.rb M src/api/app/views/webui/users/notifications/_notifications_list.html.haml M src/api/app/views/webui/users/notifications/_update.js.erb M src/api/app/views/webui/users/notifications/index.html.haml M src/api/spec/components/notification_action_bar_component_spec.rb M src/api/spec/components/notification_component_spec.rb M src/api/spec/components/notification_notifiable_link_component_spec.rb M src/api/spec/components/previews/notification_action_bar_component_preview.rb Log Message: ----------- Merge pull request #16265 from hennevogel/refactoring/notification_controller Refactoring Webui::Users::NotificationsController Compare: https://github.com/openSUSE/open-build-service/compare/61989dd1199e...3a8234... To unsubscribe from these emails, change your notification settings at https://github.com/openSUSE/open-build-service/settings/notifications