[obs-commits] [openSUSE/open-build-service] ec1422: [frontend] Manually fix Naming/VariableName offens...
Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: ec14222e0422118b9def50fa34967e9c55c26c18 https://github.com/openSUSE/open-build-service/commit/ec14222e0422118b9def50... Author: Björn Geuken <bgeuken@suse.de> Date: 2017-12-15 (Fri, 15 Dec 2017) Changed paths: M .rubocop_todo.yml M src/api/app/mixins/has_relationships.rb M src/api/app/models/channel_target.rb M src/api/app/models/package.rb M src/api/app/models/relationship.rb Log Message: ----------- [frontend] Manually fix Naming/VariableName offenses Commit: de8d669d73fa7875133c0f7acb4a87cc5b763f67 https://github.com/openSUSE/open-build-service/commit/de8d669d73fa7875133c0f... Author: Björn Geuken <bgeuken@suse.de> Date: 2017-12-15 (Fri, 15 Dec 2017) Changed paths: M .rubocop_todo.yml M src/api/app/controllers/search_controller.rb M src/api/app/helpers/webui/search_helper.rb M src/api/app/models/full_text_search.rb M src/api/app/models/package.rb M src/api/app/models/project.rb M src/api/app/models/project/key_info.rb M src/api/app/models/user_ldap_strategy.rb Log Message: ----------- [frontend] Fix Rails/Blank offenses Commit: 26f770e1dc91c8aa87e9a3413581bea56a6099a8 https://github.com/openSUSE/open-build-service/commit/26f770e1dc91c8aa87e9a3... Author: Björn Geuken <bgeuken@suse.de> Date: 2017-12-15 (Fri, 15 Dec 2017) Changed paths: M .rubocop_todo.yml M src/api/app/models/bs_request.rb M src/api/app/models/bs_request_action_set_bugowner.rb M src/api/app/models/issue_tracker.rb M src/api/app/models/owner.rb M src/api/app/models/package.rb M src/api/app/models/project.rb M src/api/app/models/user.rb Log Message: ----------- [frontend] Fix Rails/FindEach offenses Commit: 724d78bc4312dd95bc5b6b58261fbe6a810d63dd https://github.com/openSUSE/open-build-service/commit/724d78bc4312dd95bc5b6b... Author: Björn Geuken <bgeuken@suse.de> Date: 2017-12-15 (Fri, 15 Dec 2017) Changed paths: M .rubocop_todo.yml M src/api/app/controllers/application_controller.rb M src/api/app/controllers/configurations_controller.rb M src/api/app/controllers/person_controller.rb M src/api/app/controllers/public_controller.rb M src/api/app/controllers/request_controller.rb M src/api/app/controllers/search_controller.rb M src/api/app/controllers/source_controller.rb M src/api/app/controllers/webui/feeds_controller.rb M src/api/app/controllers/webui/package_controller.rb M src/api/app/controllers/webui/patchinfo_controller.rb M src/api/app/controllers/webui/project_controller.rb M src/api/app/controllers/webui/repositories_controller.rb M src/api/app/controllers/webui/search_controller.rb M src/api/app/controllers/webui/webui_controller.rb M src/api/app/helpers/flag_helper.rb M src/api/app/helpers/maintenance_helper.rb M src/api/app/helpers/webui/buildresult_helper.rb M src/api/app/jobs/consistency_check_job.rb M src/api/app/mixins/has_attributes.rb M src/api/app/models/bs_request.rb M src/api/app/models/bs_request/find_for/user.rb M src/api/app/models/bs_request/find_for/user_group_mixin.rb M src/api/app/models/bs_request_action.rb M src/api/app/models/bs_request_action_accept_info.rb M src/api/app/models/bs_request_action_delete.rb M src/api/app/models/channel.rb M src/api/app/models/configuration.rb M src/api/app/models/event/comment_for_request.rb M src/api/app/models/event/commit.rb M src/api/app/models/event/delete_package.rb M src/api/app/models/event/undelete_package.rb M src/api/app/models/event/version_change.rb M src/api/app/models/flag.rb M src/api/app/models/history_element.rb M src/api/app/models/issue_tracker.rb M src/api/app/models/owner.rb M src/api/app/models/package.rb M src/api/app/models/patchinfo.rb M src/api/app/models/product.rb M src/api/app/models/project.rb M src/api/app/models/project/update_from_xml_command.rb M src/api/app/models/repository.rb M src/api/app/models/review.rb M src/api/app/models/service.rb M src/api/app/views/distributions/index.xml.builder M src/api/app/views/models/_package.xml.builder M src/api/app/views/models/_project.xml.builder M src/api/app/views/webui/feeds/commits.atom.builder M src/api/db/migrate/20140908125426_convert_request_history.rb M src/api/lib/activexml/transport.rb M src/api/lib/backend/test/tasks.rb M src/api/lib/tasks/databases.rake M src/api/test/functional/channel_maintenance_test.rb M src/api/test/functional/request_controller_test.rb Log Message: ----------- [frontend] Fix Rails/Present offense Mob-programming with @DavidKang Commit: 066db1b0e2d3e0d25e4cadcb8a7af6e19c5a8c86 https://github.com/openSUSE/open-build-service/commit/066db1b0e2d3e0d25e4cad... Author: Björn Geuken <bgeuken@suse.de> Date: 2017-12-15 (Fri, 15 Dec 2017) Changed paths: M .rubocop_todo.yml M docs/dev/model_template_example.rb M src/api/app/models/bs_request_counter.rb M src/api/db/migrate/20140908125426_convert_request_history.rb M src/api/db/migrate/20140908135426_incident_priority_attribute.rb M src/api/db/migrate/20140916135426_project_maintains.rb M src/api/db/migrate/20141107135426_embargo_attribute.rb M src/api/db/migrate/20141201135426_make_origin_older_attribute.rb M src/api/db/migrate/20150227063641_add_obs_branch_skip_repositories_attribute.rb M src/api/db/migrate/20150625105426_multiple_incident_counters.rb M src/api/db/migrate/20150716124906_add_type_to_project.rb M src/api/db/migrate/20160824132643_fix_bs_request_counter.rb M src/api/db/migrate/20161123124803_image_templates_attribute.rb M src/api/db/migrate/20161128115942_add_when_attribute_to_bs_request.rb Log Message: ----------- [frontend] Fix Rails/ApplicationRecord offense Mob-programming with @DavidKang Commit: 855a0ae25cd9f878b09a76be293e98d170cc41a7 https://github.com/openSUSE/open-build-service/commit/855a0ae25cd9f878b09a76... Author: Björn Geuken <bgeuken@suse.de> Date: 2017-12-15 (Fri, 15 Dec 2017) Changed paths: M .rubocop_todo.yml M src/api/app/models/bs_request.rb M src/api/app/models/event/base.rb M src/api/app/models/event_subscription.rb M src/api/app/models/project_log_entry.rb M src/api/app/models/review.rb M src/api/app/models/user.rb Log Message: ----------- [frontend] Fix Rails/ReadWriteAttribute offenses Mob-programming with @DavidKang Commit: 061bc72f46392176996f101627aea3515b9d5cfe https://github.com/openSUSE/open-build-service/commit/061bc72f46392176996f10... Author: Björn Geuken <bgeuken@suse.de> Date: 2017-12-15 (Fri, 15 Dec 2017) Changed paths: M .rubocop_todo.yml M src/api/app/views/message/_messages.xml.builder Log Message: ----------- [frontend] Fix Style/AndOr offense Mob-programming with @DavidKang Commit: dd9cf5d2ac9a2ea6056f6d05ad58e240401aad3c https://github.com/openSUSE/open-build-service/commit/dd9cf5d2ac9a2ea6056f6d... Author: Björn Geuken <bgeuken@suse.de> Date: 2017-12-15 (Fri, 15 Dec 2017) Changed paths: M .rubocop_todo.yml M src/api/app/controllers/webui/project_controller.rb M src/api/app/helpers/webui/project_helper.rb M src/api/app/helpers/webui/webui_helper.rb M src/api/app/mixins/request_source_diff.rb M src/api/app/models/channel.rb M src/api/app/models/owner.rb M src/api/app/models/package.rb M src/api/app/models/service.rb M src/api/lib/memory_dumper.rb M src/api/lib/tasks/databases.rake M src/api/lib/tasks/delayed_job.rake M src/api/script/import_database.rb M src/api/spec/controllers/person_controller_spec.rb M src/api/spec/controllers/webui/attributes_controller_spec.rb M src/api/spec/controllers/webui/download_on_demand_controller_spec.rb M src/api/spec/controllers/webui/feeds_controller_spec.rb M src/api/spec/controllers/webui/main_controller_spec.rb M src/api/spec/controllers/webui/package_controller_spec.rb M src/api/spec/controllers/webui/packages/build_reason_controller_spec.rb M src/api/spec/controllers/webui/project_controller_spec.rb M src/api/spec/controllers/webui/request_controller_spec.rb M src/api/spec/controllers/webui/user_controller_spec.rb M src/api/spec/controllers/webui/webui_controller_spec.rb M src/api/spec/features/webui/attributes_spec.rb M src/api/spec/features/webui/maintenance_workflow_spec.rb M src/api/spec/features/webui/packages_spec.rb M src/api/spec/features/webui/users/user_home_page_spec.rb M src/api/spec/features/webui/watchlists_spec.rb M src/api/spec/helpers/webui/package_helper_spec.rb M src/api/spec/mailers/event_mailer_spec.rb M src/api/spec/models/bs_request_action_spec.rb M src/api/spec/models/bs_request_spec.rb M src/api/spec/models/kiwi/repository_spec.rb M src/api/spec/models/package_spec.rb M src/api/spec/models/project/update_from_xml_command_spec.rb M src/api/spec/models/project_spec.rb M src/api/spec/models/user_spec.rb M src/api/spec/support/shared_examples/features/user_tab.rb Log Message: ----------- [frontend] Fix Style/BlockDelimiters offenses Mob-programming with @DavidKang Commit: 38ba8d162d9697bcb621e06a4544277c3a434f79 https://github.com/openSUSE/open-build-service/commit/38ba8d162d9697bcb621e0... Author: Moisés Déniz Alemán <mdeniz@suse.com> Date: 2017-12-18 (Mon, 18 Dec 2017) Changed paths: M .rubocop_todo.yml M docs/dev/model_template_example.rb M src/api/app/controllers/application_controller.rb M src/api/app/controllers/configurations_controller.rb M src/api/app/controllers/person_controller.rb M src/api/app/controllers/public_controller.rb M src/api/app/controllers/request_controller.rb M src/api/app/controllers/search_controller.rb M src/api/app/controllers/source_controller.rb M src/api/app/controllers/webui/feeds_controller.rb M src/api/app/controllers/webui/package_controller.rb M src/api/app/controllers/webui/patchinfo_controller.rb M src/api/app/controllers/webui/project_controller.rb M src/api/app/controllers/webui/repositories_controller.rb M src/api/app/controllers/webui/search_controller.rb M src/api/app/controllers/webui/webui_controller.rb M src/api/app/helpers/flag_helper.rb M src/api/app/helpers/maintenance_helper.rb M src/api/app/helpers/webui/buildresult_helper.rb M src/api/app/helpers/webui/project_helper.rb M src/api/app/helpers/webui/search_helper.rb M src/api/app/helpers/webui/webui_helper.rb M src/api/app/jobs/consistency_check_job.rb M src/api/app/mixins/has_attributes.rb M src/api/app/mixins/has_relationships.rb M src/api/app/mixins/request_source_diff.rb M src/api/app/models/bs_request.rb M src/api/app/models/bs_request/find_for/user.rb M src/api/app/models/bs_request/find_for/user_group_mixin.rb M src/api/app/models/bs_request_action.rb M src/api/app/models/bs_request_action_accept_info.rb M src/api/app/models/bs_request_action_delete.rb M src/api/app/models/bs_request_action_set_bugowner.rb M src/api/app/models/bs_request_counter.rb M src/api/app/models/channel.rb M src/api/app/models/channel_target.rb M src/api/app/models/configuration.rb M src/api/app/models/event/base.rb M src/api/app/models/event/comment_for_request.rb M src/api/app/models/event/commit.rb M src/api/app/models/event/delete_package.rb M src/api/app/models/event/undelete_package.rb M src/api/app/models/event/version_change.rb M src/api/app/models/event_subscription.rb M src/api/app/models/flag.rb M src/api/app/models/full_text_search.rb M src/api/app/models/history_element.rb M src/api/app/models/issue_tracker.rb M src/api/app/models/owner.rb M src/api/app/models/package.rb M src/api/app/models/patchinfo.rb M src/api/app/models/product.rb M src/api/app/models/project.rb M src/api/app/models/project/key_info.rb M src/api/app/models/project/update_from_xml_command.rb M src/api/app/models/project_log_entry.rb M src/api/app/models/relationship.rb M src/api/app/models/repository.rb M src/api/app/models/review.rb M src/api/app/models/service.rb M src/api/app/models/user.rb M src/api/app/models/user_ldap_strategy.rb M src/api/app/views/distributions/index.xml.builder M src/api/app/views/message/_messages.xml.builder M src/api/app/views/models/_package.xml.builder M src/api/app/views/models/_project.xml.builder M src/api/app/views/webui/feeds/commits.atom.builder M src/api/db/migrate/20140908125426_convert_request_history.rb M src/api/db/migrate/20140908135426_incident_priority_attribute.rb M src/api/db/migrate/20140916135426_project_maintains.rb M src/api/db/migrate/20141107135426_embargo_attribute.rb M src/api/db/migrate/20141201135426_make_origin_older_attribute.rb M src/api/db/migrate/20150227063641_add_obs_branch_skip_repositories_attribute.rb M src/api/db/migrate/20150625105426_multiple_incident_counters.rb M src/api/db/migrate/20150716124906_add_type_to_project.rb M src/api/db/migrate/20160824132643_fix_bs_request_counter.rb M src/api/db/migrate/20161123124803_image_templates_attribute.rb M src/api/db/migrate/20161128115942_add_when_attribute_to_bs_request.rb M src/api/lib/activexml/transport.rb M src/api/lib/backend/test/tasks.rb M src/api/lib/memory_dumper.rb M src/api/lib/tasks/databases.rake M src/api/lib/tasks/delayed_job.rake M src/api/script/import_database.rb M src/api/spec/controllers/person_controller_spec.rb M src/api/spec/controllers/webui/attributes_controller_spec.rb M src/api/spec/controllers/webui/download_on_demand_controller_spec.rb M src/api/spec/controllers/webui/feeds_controller_spec.rb M src/api/spec/controllers/webui/main_controller_spec.rb M src/api/spec/controllers/webui/package_controller_spec.rb M src/api/spec/controllers/webui/packages/build_reason_controller_spec.rb M src/api/spec/controllers/webui/project_controller_spec.rb M src/api/spec/controllers/webui/request_controller_spec.rb M src/api/spec/controllers/webui/user_controller_spec.rb M src/api/spec/controllers/webui/webui_controller_spec.rb M src/api/spec/features/webui/attributes_spec.rb M src/api/spec/features/webui/maintenance_workflow_spec.rb M src/api/spec/features/webui/packages_spec.rb M src/api/spec/features/webui/users/user_home_page_spec.rb M src/api/spec/features/webui/watchlists_spec.rb M src/api/spec/helpers/webui/package_helper_spec.rb M src/api/spec/mailers/event_mailer_spec.rb M src/api/spec/models/bs_request_action_spec.rb M src/api/spec/models/bs_request_spec.rb M src/api/spec/models/kiwi/repository_spec.rb M src/api/spec/models/package_spec.rb M src/api/spec/models/project/update_from_xml_command_spec.rb M src/api/spec/models/project_spec.rb M src/api/spec/models/user_spec.rb M src/api/spec/support/shared_examples/features/user_tab.rb M src/api/test/functional/channel_maintenance_test.rb M src/api/test/functional/request_controller_test.rb Log Message: ----------- Merge pull request #4237 from DavidKang/feature/rubocop/rubocop_part_9 Rubocop friendly cops part 6 Compare: https://github.com/openSUSE/open-build-service/compare/09881a431150...38ba8d...
participants (1)
-
Moisés Déniz Alemán