[openSUSE/open-build-service] ee0476: Identify all SCM events that create new commits
Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: ee04763364363e3f6fee26d142455c30ea3ad42d https://github.com/openSUSE/open-build-service/commit/ee04763364363e3f6fee26... Author: Henne Vogelsang <hvogel@opensuse.org> Date: 2023-08-29 (Tue, 29 Aug 2023) Changed paths: M src/api/.rubocop_todo.yml M src/api/app/models/scm_webhook.rb Log Message: ----------- Identify all SCM events that create new commits You can't open or sync a PR without a new commit. You can't push or add tags without a new commit. Commit: 814ffe2ee12ee5abaec5e10aef0c442c31ca2b55 https://github.com/openSUSE/open-build-service/commit/814ffe2ee12ee5abaec5e1... Author: Henne Vogelsang <hvogel@opensuse.org> Date: 2023-08-29 (Tue, 29 Aug 2023) Changed paths: M src/api/app/models/concerns/scm_sync_enabled_step.rb M src/api/app/models/workflow/step/branch_package_step.rb Log Message: ----------- Make .call readable .call is where the action happens, no need to move some of it into a separate method. Only makes this harder to follow. Commit: 434ee2eba038dccb738dcb74e114de498704d145 https://github.com/openSUSE/open-build-service/commit/434ee2eba038dccb738dcb... Author: Henne Vogelsang <hvogel@opensuse.org> Date: 2023-08-29 (Tue, 29 Aug 2023) Changed paths: M src/api/app/models/workflow/step/link_package_step.rb Log Message: ----------- Make .call readable .call is where the action happens, no need to move some of it into a separate methods. Only makes this harder to follow. Commit: c15b11ead45c04ee95a6089d37e38fb1a9ebe6b8 https://github.com/openSUSE/open-build-service/commit/c15b11ead45c04ee95a608... Author: Henne Vogelsang <hvogel@opensuse.org> Date: 2023-08-29 (Tue, 29 Aug 2023) Changed paths: M src/api/app/models/workflow/step.rb Log Message: ----------- Drop unused method Commit: 7871fcf46f200feb0035373d6991acf883210bcf https://github.com/openSUSE/open-build-service/commit/7871fcf46f200feb003537... Author: Henne Vogelsang <hvogel@opensuse.org> Date: 2023-08-29 (Tue, 29 Aug 2023) Changed paths: M src/api/app/models/workflow/step/branch_package_step.rb Log Message: ----------- Simplify create_branched_package Codeclimate complained rightfully... Commit: 5edb199772428ef79ca2dea65444e5b71a017775 https://github.com/openSUSE/open-build-service/commit/5edb199772428ef79ca2de... Author: Henne Vogelsang <hvogel@opensuse.org> Date: 2023-08-29 (Tue, 29 Aug 2023) Changed paths: M src/api/app/models/workflow/step/branch_package_step.rb M src/api/spec/models/workflow/step/branch_package_step_spec.rb Log Message: ----------- Clarify logic around add_repositories The default is to create them if add_repositories isn't set or set to *anything* other than 'enabled'. Commit: 11c69877c4763f453145e029c3933ca8ce4cbeac https://github.com/openSUSE/open-build-service/commit/11c69877c4763f453145e0... Author: Henne Vogelsang <hvogel@opensuse.org> Date: 2023-08-29 (Tue, 29 Aug 2023) Changed paths: R src/api/spec/cassettes/Workflow/_steps/with_several_supported_steps/creates_no_artifacts_because_an_exception_is_raised.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/but_we_don_t_provide_a_source_package/behaves_like_source_package_not_provided/1_1_1_2_1_1.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/but_we_don_t_provide_source_project/behaves_like_source_project_not_provided/1_1_1_1_1_1.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/for_a_new_PR_event/behaves_like_failed_when_source_package_does_not_exist/1_1_1_3_2_1.yml A src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/for_a_new_PR_event/behaves_like_failed_without_link_permissions/1_1_1_3_4_1.yml R src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/for_a_new_PR_event/behaves_like_failed_without_link_permissions/1_1_1_3_5_1.yml A src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/for_a_new_PR_event/behaves_like_insufficient_permission_on_target_project/1_1_1_3_5_1.yml R src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/for_a_new_PR_event/behaves_like_insufficient_permission_on_target_project/1_1_1_3_6_1.yml A src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/for_a_new_PR_event/behaves_like_insufficient_permission_to_create_new_target_project/1_1_1_3_6_1.yml R src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/for_a_new_PR_event/behaves_like_insufficient_permission_to_create_new_target_project/1_1_1_3_7_1.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/for_a_new_PR_event/behaves_like_project_and_package_does_not_exist/1_1_1_3_3_1.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/for_a_new_PR_event/behaves_like_successful_new_PR_or_MR_event/1_1_1_3_1_1.yml R src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/for_a_new_PR_event/behaves_like_successful_new_PR_or_MR_event/1_1_1_3_1_10.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/for_a_new_PR_event/behaves_like_successful_new_PR_or_MR_event/1_1_1_3_1_2.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/for_a_new_PR_event/behaves_like_successful_new_PR_or_MR_event/1_1_1_3_1_3.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/for_a_new_PR_event/behaves_like_successful_new_PR_or_MR_event/1_1_1_3_1_4.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/for_a_new_PR_event/behaves_like_successful_new_PR_or_MR_event/1_1_1_3_1_5.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/for_a_new_PR_event/behaves_like_successful_new_PR_or_MR_event/1_1_1_3_1_6.yml R src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/for_a_new_PR_event/behaves_like_successful_new_PR_or_MR_event/1_1_1_3_1_7.yml R src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/for_a_new_PR_event/behaves_like_successful_new_PR_or_MR_event/1_1_1_3_1_8.yml R src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/for_a_new_PR_event/behaves_like_successful_new_PR_or_MR_event/1_1_1_3_1_9.yml R src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/for_a_new_PR_event/behaves_like_target_package_already_exists/1_1_1_3_4_1.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/for_an_updated_PR_event/when_the_linked_package_already_existed/behaves_like_successful_update_event_when_the_linked_package_already_exists/1_1_1_4_1_1_1.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/for_an_updated_PR_event/when_the_linked_package_already_existed/behaves_like_successful_update_event_when_the_linked_package_already_exists/1_1_1_4_1_1_2.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/for_an_updated_PR_event/when_the_linked_package_already_existed/behaves_like_successful_update_event_when_the_linked_package_already_exists/1_1_1_4_1_1_3.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/for_an_updated_PR_event/when_the_linked_package_already_existed/behaves_like_successful_update_event_when_the_linked_package_already_exists/1_1_1_4_1_1_4.yml A src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/for_an_updated_PR_event/when_the_linked_package_already_existed/behaves_like_successful_update_event_when_the_linked_package_already_exists/1_1_1_4_1_1_5.yml R src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/for_an_updated_PR_event/when_the_linked_package_already_existed/behaves_like_successful_update_event_when_the_linked_package_already_exists/1_1_1_4_1_1_6.yml R src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/for_an_updated_PR_event/when_the_linked_package_already_existed/behaves_like_successful_update_event_when_the_linked_package_already_exists/1_1_1_4_1_1_7.yml R src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/for_an_updated_PR_event/when_the_linked_package_already_existed/behaves_like_successful_update_event_when_the_linked_package_already_exists/1_1_1_4_1_1_8.yml R src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/for_an_updated_PR_event/when_the_linked_package_already_existed/behaves_like_successful_update_event_when_the_linked_package_already_exists/updates__branch_request_file_including_new_commit_sha.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/for_an_updated_PR_event/when_the_linked_package_did_not_exist/behaves_like_non-existent_linked_package/1_1_1_4_2_1_1.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/for_an_updated_PR_event/when_the_linked_package_did_not_exist/behaves_like_non-existent_linked_package/1_1_1_4_2_1_2.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/with_a_push_event_for_a_commit/behaves_like_failed_when_source_package_does_not_exist/1_1_1_5_2_1.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/with_a_push_event_for_a_commit/behaves_like_failed_without_link_permissions/1_1_1_5_4_1.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/with_a_push_event_for_a_commit/behaves_like_insufficient_permission_on_target_project/1_1_1_5_5_1.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/with_a_push_event_for_a_commit/behaves_like_insufficient_permission_to_create_new_target_project/1_1_1_5_6_1.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/with_a_push_event_for_a_commit/behaves_like_project_and_package_does_not_exist/1_1_1_5_3_1.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/with_a_push_event_for_a_commit/behaves_like_successful_on_a_new_push_event/1_1_1_5_1_1.yml R src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/with_a_push_event_for_a_commit/behaves_like_successful_on_a_new_push_event/1_1_1_5_1_10.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/with_a_push_event_for_a_commit/behaves_like_successful_on_a_new_push_event/1_1_1_5_1_2.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/with_a_push_event_for_a_commit/behaves_like_successful_on_a_new_push_event/1_1_1_5_1_3.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/with_a_push_event_for_a_commit/behaves_like_successful_on_a_new_push_event/1_1_1_5_1_4.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/with_a_push_event_for_a_commit/behaves_like_successful_on_a_new_push_event/1_1_1_5_1_5.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/with_a_push_event_for_a_commit/behaves_like_successful_on_a_new_push_event/1_1_1_5_1_6.yml R src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/with_a_push_event_for_a_commit/behaves_like_successful_on_a_new_push_event/1_1_1_5_1_7.yml R src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/with_a_push_event_for_a_commit/behaves_like_successful_on_a_new_push_event/1_1_1_5_1_8.yml R src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/with_a_push_event_for_a_commit/behaves_like_successful_on_a_new_push_event/1_1_1_5_1_9.yml R src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/with_a_push_event_for_a_tag/1_1_1_6_10.yml R src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/with_a_push_event_for_a_tag/1_1_1_6_11.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/with_a_push_event_for_a_tag/1_1_1_6_2.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/with_a_push_event_for_a_tag/1_1_1_6_3.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/with_a_push_event_for_a_tag/1_1_1_6_4.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/with_a_push_event_for_a_tag/1_1_1_6_5.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/with_a_push_event_for_a_tag/1_1_1_6_6.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/with_a_push_event_for_a_tag/1_1_1_6_7.yml R src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/with_a_push_event_for_a_tag/1_1_1_6_8.yml R src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/with_a_push_event_for_a_tag/1_1_1_6_9.yml R src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/with_a_push_event_for_a_tag/behaves_like_failed_when_source_package_does_not_exist/1_1_1_6_12_1.yml A src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/with_a_push_event_for_a_tag/behaves_like_failed_when_source_package_does_not_exist/1_1_1_6_8_1.yml A src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/with_a_push_event_for_a_tag/behaves_like_failed_without_link_permissions/1_1_1_6_10_1.yml R src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/with_a_push_event_for_a_tag/behaves_like_failed_without_link_permissions/1_1_1_6_14_1.yml A src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/with_a_push_event_for_a_tag/behaves_like_insufficient_permission_on_target_project/1_1_1_6_11_1.yml R src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/with_a_push_event_for_a_tag/behaves_like_insufficient_permission_on_target_project/1_1_1_6_15_1.yml A src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/with_a_push_event_for_a_tag/behaves_like_insufficient_permission_to_create_new_target_project/1_1_1_6_12_1.yml R src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/with_a_push_event_for_a_tag/behaves_like_insufficient_permission_to_create_new_target_project/1_1_1_6_16_1.yml R src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/with_a_push_event_for_a_tag/behaves_like_project_and_package_does_not_exist/1_1_1_6_13_1.yml A src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/with_a_push_event_for_a_tag/behaves_like_project_and_package_does_not_exist/1_1_1_6_9_1.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/with_a_push_event_for_a_tag/does_not_report_back_to_the_SCM.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/but_we_don_t_provide_a_source_package/behaves_like_source_package_not_provided/1_1_2_2_1_1.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/but_we_don_t_provide_source_project/behaves_like_source_project_not_provided/1_1_2_1_1_1.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/for_a_new_MR_event/behaves_like_failed_when_source_package_does_not_exist/1_1_2_3_2_1.yml A src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/for_a_new_MR_event/behaves_like_failed_without_link_permissions/1_1_2_3_4_1.yml R src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/for_a_new_MR_event/behaves_like_failed_without_link_permissions/1_1_2_3_5_1.yml A src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/for_a_new_MR_event/behaves_like_insufficient_permission_on_target_project/1_1_2_3_5_1.yml R src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/for_a_new_MR_event/behaves_like_insufficient_permission_on_target_project/1_1_2_3_6_1.yml A src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/for_a_new_MR_event/behaves_like_insufficient_permission_to_create_new_target_project/1_1_2_3_6_1.yml R src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/for_a_new_MR_event/behaves_like_insufficient_permission_to_create_new_target_project/1_1_2_3_7_1.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/for_a_new_MR_event/behaves_like_project_and_package_does_not_exist/1_1_2_3_3_1.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/for_a_new_MR_event/behaves_like_successful_new_PR_or_MR_event/1_1_2_3_1_1.yml R src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/for_a_new_MR_event/behaves_like_successful_new_PR_or_MR_event/1_1_2_3_1_10.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/for_a_new_MR_event/behaves_like_successful_new_PR_or_MR_event/1_1_2_3_1_2.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/for_a_new_MR_event/behaves_like_successful_new_PR_or_MR_event/1_1_2_3_1_3.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/for_a_new_MR_event/behaves_like_successful_new_PR_or_MR_event/1_1_2_3_1_4.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/for_a_new_MR_event/behaves_like_successful_new_PR_or_MR_event/1_1_2_3_1_5.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/for_a_new_MR_event/behaves_like_successful_new_PR_or_MR_event/1_1_2_3_1_6.yml R src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/for_a_new_MR_event/behaves_like_successful_new_PR_or_MR_event/1_1_2_3_1_7.yml R src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/for_a_new_MR_event/behaves_like_successful_new_PR_or_MR_event/1_1_2_3_1_8.yml R src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/for_a_new_MR_event/behaves_like_successful_new_PR_or_MR_event/1_1_2_3_1_9.yml R src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/for_a_new_MR_event/behaves_like_target_package_already_exists/1_1_2_3_4_1.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/for_an_updated_MR_event/when_the_linked_package_already_existed/behaves_like_successful_update_event_when_the_linked_package_already_exists/1_1_2_4_1_1_1.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/for_an_updated_MR_event/when_the_linked_package_already_existed/behaves_like_successful_update_event_when_the_linked_package_already_exists/1_1_2_4_1_1_2.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/for_an_updated_MR_event/when_the_linked_package_already_existed/behaves_like_successful_update_event_when_the_linked_package_already_exists/1_1_2_4_1_1_3.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/for_an_updated_MR_event/when_the_linked_package_already_existed/behaves_like_successful_update_event_when_the_linked_package_already_exists/1_1_2_4_1_1_4.yml A src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/for_an_updated_MR_event/when_the_linked_package_already_existed/behaves_like_successful_update_event_when_the_linked_package_already_exists/1_1_2_4_1_1_5.yml R src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/for_an_updated_MR_event/when_the_linked_package_already_existed/behaves_like_successful_update_event_when_the_linked_package_already_exists/1_1_2_4_1_1_6.yml R src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/for_an_updated_MR_event/when_the_linked_package_already_existed/behaves_like_successful_update_event_when_the_linked_package_already_exists/1_1_2_4_1_1_7.yml R src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/for_an_updated_MR_event/when_the_linked_package_already_existed/behaves_like_successful_update_event_when_the_linked_package_already_exists/1_1_2_4_1_1_8.yml R src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/for_an_updated_MR_event/when_the_linked_package_already_existed/behaves_like_successful_update_event_when_the_linked_package_already_exists/updates__branch_request_file_including_new_commit_sha.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/for_an_updated_MR_event/when_the_linked_package_did_not_exist/behaves_like_non-existent_linked_package/1_1_2_4_2_1_1.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/for_an_updated_MR_event/when_the_linked_package_did_not_exist/behaves_like_non-existent_linked_package/1_1_2_4_2_1_2.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/with_a_push_event_for_a_commit/behaves_like_failed_when_source_package_does_not_exist/1_1_2_5_2_1.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/with_a_push_event_for_a_commit/behaves_like_failed_without_link_permissions/1_1_2_5_4_1.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/with_a_push_event_for_a_commit/behaves_like_insufficient_permission_on_target_project/1_1_2_5_5_1.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/with_a_push_event_for_a_commit/behaves_like_insufficient_permission_to_create_new_target_project/1_1_2_5_6_1.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/with_a_push_event_for_a_commit/behaves_like_project_and_package_does_not_exist/1_1_2_5_3_1.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/with_a_push_event_for_a_commit/behaves_like_successful_on_a_new_push_event/1_1_2_5_1_1.yml R src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/with_a_push_event_for_a_commit/behaves_like_successful_on_a_new_push_event/1_1_2_5_1_10.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/with_a_push_event_for_a_commit/behaves_like_successful_on_a_new_push_event/1_1_2_5_1_2.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/with_a_push_event_for_a_commit/behaves_like_successful_on_a_new_push_event/1_1_2_5_1_3.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/with_a_push_event_for_a_commit/behaves_like_successful_on_a_new_push_event/1_1_2_5_1_4.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/with_a_push_event_for_a_commit/behaves_like_successful_on_a_new_push_event/1_1_2_5_1_5.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/with_a_push_event_for_a_commit/behaves_like_successful_on_a_new_push_event/1_1_2_5_1_6.yml R src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/with_a_push_event_for_a_commit/behaves_like_successful_on_a_new_push_event/1_1_2_5_1_7.yml R src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/with_a_push_event_for_a_commit/behaves_like_successful_on_a_new_push_event/1_1_2_5_1_8.yml R src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/with_a_push_event_for_a_commit/behaves_like_successful_on_a_new_push_event/1_1_2_5_1_9.yml M src/api/spec/models/workflow/step/link_package_step_spec.rb M src/api/spec/models/workflow_spec.rb Log Message: ----------- Adopt spec to recent (and previous) changes - we don't fail anymore if the target package already exists, we just write the _link or _branch_request file. If people want to do things twice, let them. - we don't do _branch_request files anymore since 0ea76d549a276fa8585749f6c0c8435e4bf8a7bd Commit: 2b928d8e8374de93addeb4d2d30da986dcdcf54c https://github.com/openSUSE/open-build-service/commit/2b928d8e8374de93addeb4... Author: Lukas Krause <lkrause@suse.de> Date: 2023-08-30 (Wed, 30 Aug 2023) Changed paths: M src/api/.rubocop_todo.yml M src/api/app/models/concerns/scm_sync_enabled_step.rb M src/api/app/models/scm_webhook.rb M src/api/app/models/workflow/step.rb M src/api/app/models/workflow/step/branch_package_step.rb M src/api/app/models/workflow/step/link_package_step.rb R src/api/spec/cassettes/Workflow/_steps/with_several_supported_steps/creates_no_artifacts_because_an_exception_is_raised.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/but_we_don_t_provide_a_source_package/behaves_like_source_package_not_provided/1_1_1_2_1_1.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/but_we_don_t_provide_source_project/behaves_like_source_project_not_provided/1_1_1_1_1_1.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/for_a_new_PR_event/behaves_like_failed_when_source_package_does_not_exist/1_1_1_3_2_1.yml A src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/for_a_new_PR_event/behaves_like_failed_without_link_permissions/1_1_1_3_4_1.yml R src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/for_a_new_PR_event/behaves_like_failed_without_link_permissions/1_1_1_3_5_1.yml A src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/for_a_new_PR_event/behaves_like_insufficient_permission_on_target_project/1_1_1_3_5_1.yml R src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/for_a_new_PR_event/behaves_like_insufficient_permission_on_target_project/1_1_1_3_6_1.yml A src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/for_a_new_PR_event/behaves_like_insufficient_permission_to_create_new_target_project/1_1_1_3_6_1.yml R src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/for_a_new_PR_event/behaves_like_insufficient_permission_to_create_new_target_project/1_1_1_3_7_1.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/for_a_new_PR_event/behaves_like_project_and_package_does_not_exist/1_1_1_3_3_1.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/for_a_new_PR_event/behaves_like_successful_new_PR_or_MR_event/1_1_1_3_1_1.yml R src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/for_a_new_PR_event/behaves_like_successful_new_PR_or_MR_event/1_1_1_3_1_10.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/for_a_new_PR_event/behaves_like_successful_new_PR_or_MR_event/1_1_1_3_1_2.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/for_a_new_PR_event/behaves_like_successful_new_PR_or_MR_event/1_1_1_3_1_3.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/for_a_new_PR_event/behaves_like_successful_new_PR_or_MR_event/1_1_1_3_1_4.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/for_a_new_PR_event/behaves_like_successful_new_PR_or_MR_event/1_1_1_3_1_5.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/for_a_new_PR_event/behaves_like_successful_new_PR_or_MR_event/1_1_1_3_1_6.yml R src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/for_a_new_PR_event/behaves_like_successful_new_PR_or_MR_event/1_1_1_3_1_7.yml R src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/for_a_new_PR_event/behaves_like_successful_new_PR_or_MR_event/1_1_1_3_1_8.yml R src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/for_a_new_PR_event/behaves_like_successful_new_PR_or_MR_event/1_1_1_3_1_9.yml R src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/for_a_new_PR_event/behaves_like_target_package_already_exists/1_1_1_3_4_1.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/for_an_updated_PR_event/when_the_linked_package_already_existed/behaves_like_successful_update_event_when_the_linked_package_already_exists/1_1_1_4_1_1_1.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/for_an_updated_PR_event/when_the_linked_package_already_existed/behaves_like_successful_update_event_when_the_linked_package_already_exists/1_1_1_4_1_1_2.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/for_an_updated_PR_event/when_the_linked_package_already_existed/behaves_like_successful_update_event_when_the_linked_package_already_exists/1_1_1_4_1_1_3.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/for_an_updated_PR_event/when_the_linked_package_already_existed/behaves_like_successful_update_event_when_the_linked_package_already_exists/1_1_1_4_1_1_4.yml A src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/for_an_updated_PR_event/when_the_linked_package_already_existed/behaves_like_successful_update_event_when_the_linked_package_already_exists/1_1_1_4_1_1_5.yml R src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/for_an_updated_PR_event/when_the_linked_package_already_existed/behaves_like_successful_update_event_when_the_linked_package_already_exists/1_1_1_4_1_1_6.yml R src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/for_an_updated_PR_event/when_the_linked_package_already_existed/behaves_like_successful_update_event_when_the_linked_package_already_exists/1_1_1_4_1_1_7.yml R src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/for_an_updated_PR_event/when_the_linked_package_already_existed/behaves_like_successful_update_event_when_the_linked_package_already_exists/1_1_1_4_1_1_8.yml R src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/for_an_updated_PR_event/when_the_linked_package_already_existed/behaves_like_successful_update_event_when_the_linked_package_already_exists/updates__branch_request_file_including_new_commit_sha.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/for_an_updated_PR_event/when_the_linked_package_did_not_exist/behaves_like_non-existent_linked_package/1_1_1_4_2_1_1.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/for_an_updated_PR_event/when_the_linked_package_did_not_exist/behaves_like_non-existent_linked_package/1_1_1_4_2_1_2.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/with_a_push_event_for_a_commit/behaves_like_failed_when_source_package_does_not_exist/1_1_1_5_2_1.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/with_a_push_event_for_a_commit/behaves_like_failed_without_link_permissions/1_1_1_5_4_1.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/with_a_push_event_for_a_commit/behaves_like_insufficient_permission_on_target_project/1_1_1_5_5_1.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/with_a_push_event_for_a_commit/behaves_like_insufficient_permission_to_create_new_target_project/1_1_1_5_6_1.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/with_a_push_event_for_a_commit/behaves_like_project_and_package_does_not_exist/1_1_1_5_3_1.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/with_a_push_event_for_a_commit/behaves_like_successful_on_a_new_push_event/1_1_1_5_1_1.yml R src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/with_a_push_event_for_a_commit/behaves_like_successful_on_a_new_push_event/1_1_1_5_1_10.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/with_a_push_event_for_a_commit/behaves_like_successful_on_a_new_push_event/1_1_1_5_1_2.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/with_a_push_event_for_a_commit/behaves_like_successful_on_a_new_push_event/1_1_1_5_1_3.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/with_a_push_event_for_a_commit/behaves_like_successful_on_a_new_push_event/1_1_1_5_1_4.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/with_a_push_event_for_a_commit/behaves_like_successful_on_a_new_push_event/1_1_1_5_1_5.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/with_a_push_event_for_a_commit/behaves_like_successful_on_a_new_push_event/1_1_1_5_1_6.yml R src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/with_a_push_event_for_a_commit/behaves_like_successful_on_a_new_push_event/1_1_1_5_1_7.yml R src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/with_a_push_event_for_a_commit/behaves_like_successful_on_a_new_push_event/1_1_1_5_1_8.yml R src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/with_a_push_event_for_a_commit/behaves_like_successful_on_a_new_push_event/1_1_1_5_1_9.yml R src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/with_a_push_event_for_a_tag/1_1_1_6_10.yml R src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/with_a_push_event_for_a_tag/1_1_1_6_11.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/with_a_push_event_for_a_tag/1_1_1_6_2.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/with_a_push_event_for_a_tag/1_1_1_6_3.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/with_a_push_event_for_a_tag/1_1_1_6_4.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/with_a_push_event_for_a_tag/1_1_1_6_5.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/with_a_push_event_for_a_tag/1_1_1_6_6.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/with_a_push_event_for_a_tag/1_1_1_6_7.yml R src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/with_a_push_event_for_a_tag/1_1_1_6_8.yml R src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/with_a_push_event_for_a_tag/1_1_1_6_9.yml R src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/with_a_push_event_for_a_tag/behaves_like_failed_when_source_package_does_not_exist/1_1_1_6_12_1.yml A src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/with_a_push_event_for_a_tag/behaves_like_failed_when_source_package_does_not_exist/1_1_1_6_8_1.yml A src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/with_a_push_event_for_a_tag/behaves_like_failed_without_link_permissions/1_1_1_6_10_1.yml R src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/with_a_push_event_for_a_tag/behaves_like_failed_without_link_permissions/1_1_1_6_14_1.yml A src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/with_a_push_event_for_a_tag/behaves_like_insufficient_permission_on_target_project/1_1_1_6_11_1.yml R src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/with_a_push_event_for_a_tag/behaves_like_insufficient_permission_on_target_project/1_1_1_6_15_1.yml A src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/with_a_push_event_for_a_tag/behaves_like_insufficient_permission_to_create_new_target_project/1_1_1_6_12_1.yml R src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/with_a_push_event_for_a_tag/behaves_like_insufficient_permission_to_create_new_target_project/1_1_1_6_16_1.yml R src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/with_a_push_event_for_a_tag/behaves_like_project_and_package_does_not_exist/1_1_1_6_13_1.yml A src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/with_a_push_event_for_a_tag/behaves_like_project_and_package_does_not_exist/1_1_1_6_9_1.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/with_a_push_event_for_a_tag/does_not_report_back_to_the_SCM.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/but_we_don_t_provide_a_source_package/behaves_like_source_package_not_provided/1_1_2_2_1_1.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/but_we_don_t_provide_source_project/behaves_like_source_project_not_provided/1_1_2_1_1_1.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/for_a_new_MR_event/behaves_like_failed_when_source_package_does_not_exist/1_1_2_3_2_1.yml A src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/for_a_new_MR_event/behaves_like_failed_without_link_permissions/1_1_2_3_4_1.yml R src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/for_a_new_MR_event/behaves_like_failed_without_link_permissions/1_1_2_3_5_1.yml A src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/for_a_new_MR_event/behaves_like_insufficient_permission_on_target_project/1_1_2_3_5_1.yml R src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/for_a_new_MR_event/behaves_like_insufficient_permission_on_target_project/1_1_2_3_6_1.yml A src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/for_a_new_MR_event/behaves_like_insufficient_permission_to_create_new_target_project/1_1_2_3_6_1.yml R src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/for_a_new_MR_event/behaves_like_insufficient_permission_to_create_new_target_project/1_1_2_3_7_1.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/for_a_new_MR_event/behaves_like_project_and_package_does_not_exist/1_1_2_3_3_1.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/for_a_new_MR_event/behaves_like_successful_new_PR_or_MR_event/1_1_2_3_1_1.yml R src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/for_a_new_MR_event/behaves_like_successful_new_PR_or_MR_event/1_1_2_3_1_10.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/for_a_new_MR_event/behaves_like_successful_new_PR_or_MR_event/1_1_2_3_1_2.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/for_a_new_MR_event/behaves_like_successful_new_PR_or_MR_event/1_1_2_3_1_3.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/for_a_new_MR_event/behaves_like_successful_new_PR_or_MR_event/1_1_2_3_1_4.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/for_a_new_MR_event/behaves_like_successful_new_PR_or_MR_event/1_1_2_3_1_5.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/for_a_new_MR_event/behaves_like_successful_new_PR_or_MR_event/1_1_2_3_1_6.yml R src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/for_a_new_MR_event/behaves_like_successful_new_PR_or_MR_event/1_1_2_3_1_7.yml R src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/for_a_new_MR_event/behaves_like_successful_new_PR_or_MR_event/1_1_2_3_1_8.yml R src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/for_a_new_MR_event/behaves_like_successful_new_PR_or_MR_event/1_1_2_3_1_9.yml R src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/for_a_new_MR_event/behaves_like_target_package_already_exists/1_1_2_3_4_1.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/for_an_updated_MR_event/when_the_linked_package_already_existed/behaves_like_successful_update_event_when_the_linked_package_already_exists/1_1_2_4_1_1_1.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/for_an_updated_MR_event/when_the_linked_package_already_existed/behaves_like_successful_update_event_when_the_linked_package_already_exists/1_1_2_4_1_1_2.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/for_an_updated_MR_event/when_the_linked_package_already_existed/behaves_like_successful_update_event_when_the_linked_package_already_exists/1_1_2_4_1_1_3.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/for_an_updated_MR_event/when_the_linked_package_already_existed/behaves_like_successful_update_event_when_the_linked_package_already_exists/1_1_2_4_1_1_4.yml A src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/for_an_updated_MR_event/when_the_linked_package_already_existed/behaves_like_successful_update_event_when_the_linked_package_already_exists/1_1_2_4_1_1_5.yml R src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/for_an_updated_MR_event/when_the_linked_package_already_existed/behaves_like_successful_update_event_when_the_linked_package_already_exists/1_1_2_4_1_1_6.yml R src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/for_an_updated_MR_event/when_the_linked_package_already_existed/behaves_like_successful_update_event_when_the_linked_package_already_exists/1_1_2_4_1_1_7.yml R src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/for_an_updated_MR_event/when_the_linked_package_already_existed/behaves_like_successful_update_event_when_the_linked_package_already_exists/1_1_2_4_1_1_8.yml R src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/for_an_updated_MR_event/when_the_linked_package_already_existed/behaves_like_successful_update_event_when_the_linked_package_already_exists/updates__branch_request_file_including_new_commit_sha.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/for_an_updated_MR_event/when_the_linked_package_did_not_exist/behaves_like_non-existent_linked_package/1_1_2_4_2_1_1.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/for_an_updated_MR_event/when_the_linked_package_did_not_exist/behaves_like_non-existent_linked_package/1_1_2_4_2_1_2.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/with_a_push_event_for_a_commit/behaves_like_failed_when_source_package_does_not_exist/1_1_2_5_2_1.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/with_a_push_event_for_a_commit/behaves_like_failed_without_link_permissions/1_1_2_5_4_1.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/with_a_push_event_for_a_commit/behaves_like_insufficient_permission_on_target_project/1_1_2_5_5_1.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/with_a_push_event_for_a_commit/behaves_like_insufficient_permission_to_create_new_target_project/1_1_2_5_6_1.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/with_a_push_event_for_a_commit/behaves_like_project_and_package_does_not_exist/1_1_2_5_3_1.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/with_a_push_event_for_a_commit/behaves_like_successful_on_a_new_push_event/1_1_2_5_1_1.yml R src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/with_a_push_event_for_a_commit/behaves_like_successful_on_a_new_push_event/1_1_2_5_1_10.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/with_a_push_event_for_a_commit/behaves_like_successful_on_a_new_push_event/1_1_2_5_1_2.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/with_a_push_event_for_a_commit/behaves_like_successful_on_a_new_push_event/1_1_2_5_1_3.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/with_a_push_event_for_a_commit/behaves_like_successful_on_a_new_push_event/1_1_2_5_1_4.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/with_a_push_event_for_a_commit/behaves_like_successful_on_a_new_push_event/1_1_2_5_1_5.yml M src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/with_a_push_event_for_a_commit/behaves_like_successful_on_a_new_push_event/1_1_2_5_1_6.yml R src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/with_a_push_event_for_a_commit/behaves_like_successful_on_a_new_push_event/1_1_2_5_1_7.yml R src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/with_a_push_event_for_a_commit/behaves_like_successful_on_a_new_push_event/1_1_2_5_1_8.yml R src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitLab/with_a_push_event_for_a_commit/behaves_like_successful_on_a_new_push_event/1_1_2_5_1_9.yml M src/api/spec/models/workflow/step/branch_package_step_spec.rb M src/api/spec/models/workflow/step/link_package_step_spec.rb M src/api/spec/models/workflow_spec.rb Log Message: ----------- Merge pull request #14834 from hennevogel/refactoring/readable-call Make BranchPackageStep/LinkPackageStep.call readable Compare: https://github.com/openSUSE/open-build-service/compare/fc37021e1055...2b928d...
participants (1)
-
Lukas Krause