[obs-commits] [openSUSE/open-build-service] 54d2b6: [webui] Check should be unnecessary, condition is ...
Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 54d2b6b3b8e133f327e4ead6b3ffaf0417b2882d https://github.com/openSUSE/open-build-service/commit/54d2b6b3b8e133f327e4ea... Author: Sascha Peilicke <saschpe@suse.de> Date: 2012-04-02 (Mon, 02 Apr 2012) Changed paths: M src/webui/app/views/request/show.html.erb Log Message: ----------- [webui] Check should be unnecessary, condition is also part of @can_handle_request Commit: 19c7fc76b9a6a37c5869a21ef0d8ee5f898e6e62 https://github.com/openSUSE/open-build-service/commit/19c7fc76b9a6a37c5869a2... Author: Sascha Peilicke <saschpe@suse.de> Date: 2012-04-02 (Mon, 02 Apr 2012) Changed paths: M src/webui/app/views/request/show.html.erb Log Message: ----------- [webui] Show advanced request controls only to target maintainers Commit: 0657cdcf0815d5a48e767ce7816809ecc1616b95 https://github.com/openSUSE/open-build-service/commit/0657cdcf0815d5a48e767c... Author: Sascha Peilicke <saschpe@suse.de> Date: 2012-04-02 (Mon, 02 Apr 2012) Changed paths: M src/webui/app/controllers/package_controller.rb M src/webui/app/helpers/application_helper.rb M src/webui/app/views/package/live_build_log.rhtml M src/webui/app/views/request/_recent_events_table.html.erb M src/webui/public/stylesheets/obs.min.css M src/webui/public/themes Log Message: ----------- [webui] Use <pre> tag in live build log instead of <code> This obsoletes the helper 'escape_and_transform_nonprintables'. However, a simplified version is still used to display newlines in request review comments (the API could do the replacement too, btw.). That said, we should simply refuse to sanitize any pre-formatted text (excluding named newlines) that users like to put here and there, it's just wrong. Lastly, our Bento theme's <pre> tags now wrap long lines (across browsers), so the resulting build log should be closer to the raw log. Compare: https://github.com/openSUSE/open-build-service/compare/b7ab8a7...0657cdc
participants (1)
-
Sascha Peilicke